* [PATCH] isdn: Build telespci and hfc_pci only for little endian CPUs
@ 2014-01-05 17:50 Guenter Roeck
2014-01-05 18:30 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2014-01-05 17:50 UTC (permalink / raw)
To: Karsten Keil; +Cc: netdev, linux-kernel, Guenter Roeck
With arm:allmodconfig, building the Teles PCI driver fails with
telespci.c:294:2: error: #error "not running on big endian machines now"
Similar, building the driver for HFC PCI-Bus cards fails with
hfc_pci.c:1647:2: error: #error "not running on big endian machines now"
Limit both drivers to only build on little endian machines.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/isdn/hisax/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/isdn/hisax/Kconfig b/drivers/isdn/hisax/Kconfig
index d9edcc9..5e4f67d 100644
--- a/drivers/isdn/hisax/Kconfig
+++ b/drivers/isdn/hisax/Kconfig
@@ -109,7 +109,7 @@ config HISAX_16_3
config HISAX_TELESPCI
bool "Teles PCI"
- depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
+ depends on CPU_LITTLE_ENDIAN && PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || MIPS || FRV || XTENSA))
help
This enables HiSax support for the Teles PCI.
See <file:Documentation/isdn/README.HiSax> on how to configure it.
@@ -318,7 +318,7 @@ config HISAX_GAZEL
config HISAX_HFC_PCI
bool "HFC PCI-Bus cards"
- depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
+ depends on CPU_LITTLE_ENDIAN && PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || MIPS || FRV || XTENSA))
help
This enables HiSax support for the HFC-S PCI 2BDS0 based cards.
--
1.7.9.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] isdn: Build telespci and hfc_pci only for little endian CPUs
2014-01-05 17:50 [PATCH] isdn: Build telespci and hfc_pci only for little endian CPUs Guenter Roeck
@ 2014-01-05 18:30 ` Geert Uytterhoeven
2014-01-05 18:57 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2014-01-05 18:30 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Karsten Keil, netdev, linux-kernel, linux-kbuild
On Sun, Jan 5, 2014 at 6:50 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> - depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
> + depends on CPU_LITTLE_ENDIAN && PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || MIPS || FRV || XTENSA))
Unfortunately CPU_LITTLE_ENDIAN is only available on architectures
that support two endiannesses. So the above will preclude e.g. x86, which is
where most ISDN users are.
One solution is to move CPU_LITTLE_ENDIAN and CPU_BIG_ENDIAN to the
common Kconfig parts. After that, the dependency above can just become
depends on CPU_LITTLE_ENDIAN && PCI.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] isdn: Build telespci and hfc_pci only for little endian CPUs
2014-01-05 18:30 ` Geert Uytterhoeven
@ 2014-01-05 18:57 ` Guenter Roeck
0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2014-01-05 18:57 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Karsten Keil, netdev, linux-kernel, linux-kbuild
On 01/05/2014 10:30 AM, Geert Uytterhoeven wrote:
> On Sun, Jan 5, 2014 at 6:50 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>> - depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
>> + depends on CPU_LITTLE_ENDIAN && PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || MIPS || FRV || XTENSA))
>
> Unfortunately CPU_LITTLE_ENDIAN is only available on architectures
> that support two endiannesses. So the above will preclude e.g. x86, which is
> where most ISDN users are.
>
> One solution is to move CPU_LITTLE_ENDIAN and CPU_BIG_ENDIAN to the
> common Kconfig parts. After that, the dependency above can just become
>
> depends on CPU_LITTLE_ENDIAN && PCI.
>
Excellent idea, but more invasive than I want to get into. I'll mark the build for the drivers
as broken for big endian ARM machines instead. The cleanup you suggested can then go in as
separate patch (if wanted).
Thanks,
Guenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-05 18:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-05 17:50 [PATCH] isdn: Build telespci and hfc_pci only for little endian CPUs Guenter Roeck
2014-01-05 18:30 ` Geert Uytterhoeven
2014-01-05 18:57 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).