From: David Ahern <dsahern@gmail.com>
To: Ido Schimmel <idosch@idosch.org>, netdev@vger.kernel.org
Cc: davem@davemloft.net, jiri@mellanox.com,
jakub.kicinski@netronome.com, saeedm@mellanox.com,
mlxsw@mellanox.com, Ido Schimmel <idosch@mellanox.com>
Subject: Re: [RFC PATCH net-next 02/15] ipv4: Notify route after insertion to the routing table
Date: Wed, 2 Oct 2019 19:34:35 -0600 [thread overview]
Message-ID: <576d658d-6aab-558c-0a20-13133217d3b6@gmail.com> (raw)
In-Reply-To: <20191002084103.12138-3-idosch@idosch.org>
On 10/2/19 2:40 AM, Ido Schimmel wrote:
> @@ -1269,14 +1269,19 @@ int fib_table_insert(struct net *net, struct fib_table *tb,
> new_fa->tb_id = tb->tb_id;
> new_fa->fa_default = -1;
>
> - err = call_fib_entry_notifiers(net, event, key, plen, new_fa, extack);
> + /* Insert new entry to the list. */
> + err = fib_insert_alias(t, tp, l, new_fa, fa, key);
> if (err)
> goto out_free_new_fa;
>
> - /* Insert new entry to the list. */
> - err = fib_insert_alias(t, tp, l, new_fa, fa, key);
> + /* The alias was already inserted, so the node must exist. */
> + l = fib_find_node(t, &tp, key);
> + if (WARN_ON_ONCE(!l))
> + goto out_free_new_fa;
Maybe I am missing something but, the 'l' is only needed for the error
path, so optimize for the success case and only lookup the node if the
notifier fails.
> +
> + err = call_fib_entry_notifiers(net, event, key, plen, new_fa, extack);
> if (err)
> - goto out_fib_notif;
> + goto out_remove_new_fa;
>
> if (!plen)
> tb->tb_num_default++;
> @@ -1287,14 +1292,8 @@ int fib_table_insert(struct net *net, struct fib_table *tb,
> succeeded:
> return 0;
>
> -out_fib_notif:
> - /* notifier was sent that entry would be added to trie, but
> - * the add failed and need to recover. Only failure for
> - * fib_insert_alias is ENOMEM.
> - */
> - NL_SET_ERR_MSG(extack, "Failed to insert route into trie");
> - call_fib_entry_notifiers(net, FIB_EVENT_ENTRY_DEL, key,
> - plen, new_fa, NULL);
> +out_remove_new_fa:
> + fib_remove_alias(t, tp, l, new_fa);
> out_free_new_fa:
> kmem_cache_free(fn_alias_kmem, new_fa);
> out:
>
next prev parent reply other threads:[~2019-10-03 1:34 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 8:40 [RFC PATCH net-next 00/15] Simplify IPv4 route offload API Ido Schimmel
2019-10-02 8:40 ` [RFC PATCH net-next 01/15] ipv4: Add temporary events to the FIB notification chain Ido Schimmel
2019-10-02 8:40 ` [RFC PATCH net-next 02/15] ipv4: Notify route after insertion to the routing table Ido Schimmel
2019-10-03 1:34 ` David Ahern [this message]
2019-10-03 5:16 ` Ido Schimmel
2019-10-02 8:40 ` [RFC PATCH net-next 03/15] ipv4: Notify route if replacing currently offloaded one Ido Schimmel
2019-10-02 8:40 ` [RFC PATCH net-next 04/15] ipv4: Notify newly added route if should be offloaded Ido Schimmel
2019-10-02 8:40 ` [RFC PATCH net-next 05/15] ipv4: Handle route deletion notification Ido Schimmel
2019-10-02 8:40 ` [RFC PATCH net-next 06/15] ipv4: Handle route deletion notification during flush Ido Schimmel
2019-10-02 8:40 ` [RFC PATCH net-next 07/15] ipv4: Only Replay routes of interest to new listeners Ido Schimmel
2019-10-02 17:44 ` Jiri Pirko
2019-10-03 13:04 ` Ido Schimmel
2019-10-02 8:40 ` [RFC PATCH net-next 08/15] mlxsw: spectrum_router: Start using new IPv4 route notifications Ido Schimmel
2019-10-02 17:52 ` Jiri Pirko
2019-10-02 18:01 ` Jiri Pirko
2019-10-03 15:10 ` Ido Schimmel
2019-10-02 8:40 ` [RFC PATCH net-next 09/15] ipv4: Remove old route notifications and convert listeners Ido Schimmel
2019-10-02 8:40 ` [RFC PATCH net-next 10/15] ipv4: Replace route in list before notifying Ido Schimmel
2019-10-02 8:40 ` [RFC PATCH net-next 11/15] ipv4: Encapsulate function arguments in a struct Ido Schimmel
2019-10-02 8:41 ` [RFC PATCH net-next 12/15] ipv4: Add "in hardware" indication to routes Ido Schimmel
2019-10-02 15:58 ` Roopa Prabhu
2019-10-02 18:21 ` Jiri Pirko
2019-10-03 2:34 ` David Ahern
2019-10-03 5:37 ` Ido Schimmel
2019-10-04 1:55 ` David Ahern
2019-10-04 14:43 ` Ido Schimmel
2019-10-04 16:38 ` David Ahern
2019-10-04 17:43 ` Roopa Prabhu
2019-10-04 23:20 ` David Ahern
2019-10-03 5:40 ` Jiri Pirko
2019-10-03 12:59 ` Ido Schimmel
2019-10-04 4:25 ` Roopa Prabhu
2019-10-02 8:41 ` [RFC PATCH net-next 13/15] mlxsw: spectrum_router: Mark routes as "in hardware" Ido Schimmel
2019-10-02 18:27 ` Jiri Pirko
2019-10-03 15:16 ` Ido Schimmel
2019-10-02 8:41 ` [RFC PATCH net-next 14/15] netdevsim: fib: " Ido Schimmel
2019-10-02 8:41 ` [RFC PATCH net-next 15/15] selftests: netdevsim: Add test for route offload API Ido Schimmel
2019-10-02 18:17 ` [RFC PATCH net-next 00/15] Simplify IPv4 " Jiri Pirko
2019-10-03 5:18 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576d658d-6aab-558c-0a20-13133217d3b6@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).