From: "Saleem, Shiraz" <shiraz.saleem@intel.com>
To: Leon Romanovsky <leon@kernel.org>, Jason Gunthorpe <jgg@nvidia.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Ertman, David M" <david.m.ertman@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Subject: RE: [PATCH v4 01/23] iidc: Introduce iidc.h
Date: Fri, 9 Apr 2021 01:38:37 +0000 [thread overview]
Message-ID: <61852f3ff556421c9fd89edc0ee50417@intel.com> (raw)
In-Reply-To: <YG6tZ/iRFpt3OELK@unreal>
> Subject: Re: [PATCH v4 01/23] iidc: Introduce iidc.h
>
> On Wed, Apr 07, 2021 at 07:43:24PM -0300, Jason Gunthorpe wrote:
> > On Wed, Apr 07, 2021 at 08:58:49PM +0000, Saleem, Shiraz wrote:
> > > > Subject: Re: [PATCH v4 01/23] iidc: Introduce iidc.h
> > > >
> > > > On Tue, Apr 06, 2021 at 04:01:03PM -0500, Shiraz Saleem wrote:
> > > >
> > > > > +/* Following APIs are implemented by core PCI driver */ struct
> > > > > +iidc_core_ops {
> > > > > + /* APIs to allocate resources such as VEB, VSI, Doorbell queues,
> > > > > + * completion queues, Tx/Rx queues, etc...
> > > > > + */
> > > > > + int (*alloc_res)(struct iidc_core_dev_info *cdev_info,
> > > > > + struct iidc_res *res,
> > > > > + int partial_acceptable);
> > > > > + int (*free_res)(struct iidc_core_dev_info *cdev_info,
> > > > > + struct iidc_res *res);
> > > > > +
> > > > > + int (*request_reset)(struct iidc_core_dev_info *cdev_info,
> > > > > + enum iidc_reset_type reset_type);
> > > > > +
> > > > > + int (*update_vport_filter)(struct iidc_core_dev_info *cdev_info,
> > > > > + u16 vport_id, bool enable);
> > > > > + int (*vc_send)(struct iidc_core_dev_info *cdev_info, u32 vf_id, u8
> *msg,
> > > > > + u16 len);
> > > > > +};
> > > >
> > > > What is this? There is only one implementation:
> > > >
> > > > static const struct iidc_core_ops ops = {
> > > > .alloc_res = ice_cdev_info_alloc_res,
> > > > .free_res = ice_cdev_info_free_res,
> > > > .request_reset = ice_cdev_info_request_reset,
> > > > .update_vport_filter = ice_cdev_info_update_vsi_filter,
> > > > .vc_send = ice_cdev_info_vc_send,
> > > > };
> > > >
> > > > So export and call the functions directly.
> > >
> > > No. Then we end up requiring ice to be loaded even when just want to
> > > use irdma with x722 [whose ethernet driver is "i40e"].
> >
> > So what? What does it matter to load a few extra kb of modules?
>
> And if user cares about it, he will blacklist that module anyway.
>
blacklist ice when you just have an x722 card? How does that solve anything? You wont be able to load irdma then.
Shiraz
next prev parent reply other threads:[~2021-04-09 1:38 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 21:01 [PATCH v4 00/23] Add Intel Ethernet Protocol Driver for RDMA (irdma) Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 01/23] iidc: Introduce iidc.h Shiraz Saleem
2021-04-07 15:44 ` Jason Gunthorpe
2021-04-07 20:58 ` Saleem, Shiraz
2021-04-07 22:43 ` Jason Gunthorpe
2021-04-08 7:14 ` Leon Romanovsky
2021-04-09 1:38 ` Saleem, Shiraz [this message]
2021-04-11 11:48 ` Leon Romanovsky
2021-04-12 14:50 ` Saleem, Shiraz
2021-04-12 16:12 ` Jason Gunthorpe
2021-04-15 17:36 ` Saleem, Shiraz
2021-04-07 17:35 ` Jason Gunthorpe
2021-04-12 14:51 ` Saleem, Shiraz
2021-04-06 21:01 ` [PATCH v4 02/23] ice: Initialize RDMA support Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 03/23] ice: Implement iidc operations Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 04/23] ice: Register auxiliary device to provide RDMA Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 05/23] ice: Add devlink params support Shiraz Saleem
2021-04-07 14:57 ` Jason Gunthorpe
2021-04-07 20:58 ` Saleem, Shiraz
2021-04-07 22:46 ` Jason Gunthorpe
2021-04-12 14:50 ` Saleem, Shiraz
2021-04-12 19:07 ` Parav Pandit
2021-04-13 4:03 ` Parav Pandit
2021-04-13 14:40 ` Saleem, Shiraz
2021-04-13 17:36 ` Parav Pandit
2021-04-14 0:21 ` Saleem, Shiraz
2021-04-14 5:27 ` Parav Pandit
2021-04-18 11:51 ` Leon Romanovsky
2021-04-06 21:01 ` [PATCH v4 06/23] i40e: Prep i40e header for aux bus conversion Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 07/23] i40e: Register auxiliary devices to provide RDMA Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 08/23] RDMA/irdma: Register auxiliary driver and implement private channel OPs Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 09/23] RDMA/irdma: Implement device initialization definitions Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 10/23] RDMA/irdma: Implement HW Admin Queue OPs Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 11/23] RDMA/irdma: Add HMC backing store setup functions Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 12/23] RDMA/irdma: Add privileged UDA queue implementation Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 13/23] RDMA/irdma: Add QoS definitions Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 14/23] RDMA/irdma: Add connection manager Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 15/23] RDMA/irdma: Add PBLE resource manager Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 16/23] RDMA/irdma: Implement device supported verb APIs Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 17/23] RDMA/irdma: Add RoCEv2 UD OP support Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 18/23] RDMA/irdma: Add user/kernel shared libraries Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 19/23] RDMA/irdma: Add miscellaneous utility definitions Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 20/23] RDMA/irdma: Add dynamic tracing for CM Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 21/23] RDMA/irdma: Add ABI definitions Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 22/23] RDMA/irdma: Add irdma Kconfig/Makefile and remove i40iw Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 23/23] RDMA/irdma: Update MAINTAINERS file Shiraz Saleem
2021-04-06 21:05 ` [PATCH v4 00/23] Add Intel Ethernet Protocol Driver for RDMA (irdma) Saleem, Shiraz
2021-04-06 23:15 ` Jason Gunthorpe
2021-04-06 23:30 ` Saleem, Shiraz
2021-04-07 0:18 ` Saleem, Shiraz
2021-04-07 11:31 ` Jason Gunthorpe
2021-04-07 15:06 ` Saleem, Shiraz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61852f3ff556421c9fd89edc0ee50417@intel.com \
--to=shiraz.saleem@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).