From: "Saleem, Shiraz" <shiraz.saleem@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"Lacombe, John S" <john.s.lacombe@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Ertman, David M" <david.m.ertman@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"Hefty, Sean" <sean.hefty@intel.com>,
"Keller, Jacob E" <jacob.e.keller@intel.com>
Subject: RE: [PATCH v4 05/23] ice: Add devlink params support
Date: Mon, 12 Apr 2021 14:50:51 +0000 [thread overview]
Message-ID: <c5a38fcf137e49c0af0bfa6edd3ec605@intel.com> (raw)
In-Reply-To: <20210407224631.GI282464@nvidia.com>
> Subject: Re: [PATCH v4 05/23] ice: Add devlink params support
>
> On Wed, Apr 07, 2021 at 08:58:25PM +0000, Saleem, Shiraz wrote:
> > > Subject: Re: [PATCH v4 05/23] ice: Add devlink params support
> > >
> > > On Tue, Apr 06, 2021 at 04:01:07PM -0500, Shiraz Saleem wrote:
> > > > Add a new generic runtime devlink parameter 'rdma_protocol'
> > > > and use it in ice PCI driver. Configuration changes result in
> > > > unplugging the auxiliary RDMA device and re-plugging it with
> > > > updated values for irdma auxiiary driver to consume at
> > > > drv.probe()
> > > >
> > > > Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
> > > > .../networking/devlink/devlink-params.rst | 6 ++
> > > > Documentation/networking/devlink/ice.rst | 13 +++
> > > > drivers/net/ethernet/intel/ice/ice_devlink.c | 92
> +++++++++++++++++++++-
> > > > drivers/net/ethernet/intel/ice/ice_devlink.h | 5 ++
> > > > drivers/net/ethernet/intel/ice/ice_main.c | 2 +
> > > > include/net/devlink.h | 4 +
> > > > net/core/devlink.c | 5 ++
> > > > 7 files changed, 125 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/Documentation/networking/devlink/devlink-params.rst
> > > > b/Documentation/networking/devlink/devlink-params.rst
> > > > index 54c9f10..0b454c3 100644
> > > > +++ b/Documentation/networking/devlink/devlink-params.rst
> > > > @@ -114,3 +114,9 @@ own name.
> > > > will NACK any attempt of other host to reset the device. This parameter
> > > > is useful for setups where a device is shared by different hosts, such
> > > > as multi-host setup.
> > > > + * - ``rdma_protocol``
> > > > + - string
> > > > + - Selects the RDMA protocol selected for multi-protocol devices.
> > > > + - ``iwarp`` iWARP
> > > > + - ``roce`` RoCE
> > > > + - ``ib`` Infiniband
> > >
> > > I'm still not sure this belongs in devlink.
> >
> > I believe you suggested we use devlink for protocol switch.
>
> Yes, devlink is the right place, but selecting a *single* protocol doesn't seem right,
> or general enough.
>
> Parav is talking about generic ways to customize the aux devices created and that
> would seem to serve the same function as this.
Is there an RFC or something posted for us to look at?
>
> > > I know Parav is looking at the general problem of how to customize
> > > what aux devices are created, that may be a better fit for this.
> > >
> > > Can you remove the devlink parts to make progress?
> >
> > It is important since otherwise the customer will have no way to use RoCEv2 on
> this device.
>
> I'm not saying to not having it eventually, I'm just getting tired of looking at 23
> patches. You can argue it out after
>
Since this device cannot do concurrent protocols per function,
is having a driver specific devlink to switch between the 2 also a NACK?
There is something similar in another PCI driver.
https://www.kernel.org/doc/html/latest/networking/devlink/qed.html
Can we not adapt to Parav's solution (if it's a good fit) when it becomes available?
Shiraz
next prev parent reply other threads:[~2021-04-12 14:51 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 21:01 [PATCH v4 00/23] Add Intel Ethernet Protocol Driver for RDMA (irdma) Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 01/23] iidc: Introduce iidc.h Shiraz Saleem
2021-04-07 15:44 ` Jason Gunthorpe
2021-04-07 20:58 ` Saleem, Shiraz
2021-04-07 22:43 ` Jason Gunthorpe
2021-04-08 7:14 ` Leon Romanovsky
2021-04-09 1:38 ` Saleem, Shiraz
2021-04-11 11:48 ` Leon Romanovsky
2021-04-12 14:50 ` Saleem, Shiraz
2021-04-12 16:12 ` Jason Gunthorpe
2021-04-15 17:36 ` Saleem, Shiraz
2021-04-07 17:35 ` Jason Gunthorpe
2021-04-12 14:51 ` Saleem, Shiraz
2021-04-06 21:01 ` [PATCH v4 02/23] ice: Initialize RDMA support Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 03/23] ice: Implement iidc operations Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 04/23] ice: Register auxiliary device to provide RDMA Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 05/23] ice: Add devlink params support Shiraz Saleem
2021-04-07 14:57 ` Jason Gunthorpe
2021-04-07 20:58 ` Saleem, Shiraz
2021-04-07 22:46 ` Jason Gunthorpe
2021-04-12 14:50 ` Saleem, Shiraz [this message]
2021-04-12 19:07 ` Parav Pandit
2021-04-13 4:03 ` Parav Pandit
2021-04-13 14:40 ` Saleem, Shiraz
2021-04-13 17:36 ` Parav Pandit
2021-04-14 0:21 ` Saleem, Shiraz
2021-04-14 5:27 ` Parav Pandit
2021-04-18 11:51 ` Leon Romanovsky
2021-04-06 21:01 ` [PATCH v4 06/23] i40e: Prep i40e header for aux bus conversion Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 07/23] i40e: Register auxiliary devices to provide RDMA Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 08/23] RDMA/irdma: Register auxiliary driver and implement private channel OPs Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 09/23] RDMA/irdma: Implement device initialization definitions Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 10/23] RDMA/irdma: Implement HW Admin Queue OPs Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 11/23] RDMA/irdma: Add HMC backing store setup functions Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 12/23] RDMA/irdma: Add privileged UDA queue implementation Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 13/23] RDMA/irdma: Add QoS definitions Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 14/23] RDMA/irdma: Add connection manager Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 15/23] RDMA/irdma: Add PBLE resource manager Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 16/23] RDMA/irdma: Implement device supported verb APIs Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 17/23] RDMA/irdma: Add RoCEv2 UD OP support Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 18/23] RDMA/irdma: Add user/kernel shared libraries Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 19/23] RDMA/irdma: Add miscellaneous utility definitions Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 20/23] RDMA/irdma: Add dynamic tracing for CM Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 21/23] RDMA/irdma: Add ABI definitions Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 22/23] RDMA/irdma: Add irdma Kconfig/Makefile and remove i40iw Shiraz Saleem
2021-04-06 21:01 ` [PATCH v4 23/23] RDMA/irdma: Update MAINTAINERS file Shiraz Saleem
2021-04-06 21:05 ` [PATCH v4 00/23] Add Intel Ethernet Protocol Driver for RDMA (irdma) Saleem, Shiraz
2021-04-06 23:15 ` Jason Gunthorpe
2021-04-06 23:30 ` Saleem, Shiraz
2021-04-07 0:18 ` Saleem, Shiraz
2021-04-07 11:31 ` Jason Gunthorpe
2021-04-07 15:06 ` Saleem, Shiraz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5a38fcf137e49c0af0bfa6edd3ec605@intel.com \
--to=shiraz.saleem@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=dledford@redhat.com \
--cc=jacob.e.keller@intel.com \
--cc=jgg@nvidia.com \
--cc=john.s.lacombe@intel.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).