From: lyl2019@mail.ustc.edu.cn
To: benve@cisco.com, _govind@gmx.com, davem@davemloft.net, kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [BUG] ethernet:enic: A use after free bug in enic_hard_start_xmit
Date: Tue, 27 Apr 2021 10:55:06 +0800 (GMT+08:00) [thread overview]
Message-ID: <65becad9.62766.17911406ff0.Coremail.lyl2019@mail.ustc.edu.cn> (raw)
Hi, maintainers.
Our code analyzer reported a uaf bug, but it is a little
difficult for me to fix it directly.
File: drivers/net/ethernet/cisco/enic/enic_main.c
In enic_hard_start_xmit, it calls enic_queue_wq_skb(). Inside
enic_queue_wq_skb, if some error happens, the skb will be freed
by dev_kfree_skb(skb). But the freed skb is still used in
skb_tx_timestamp(skb).
```
enic_queue_wq_skb(enic, wq, skb);// skb could freed here
if (vnic_wq_desc_avail(wq) < MAX_SKB_FRAGS + ENIC_DESC_MAX_SPLITS)
netif_tx_stop_queue(txq);
skb_tx_timestamp(skb); // freed skb is used here.
```
Bug introduced by fb7516d42478e ("enic: add sw timestamp support").
Thanks for your time, looking forwarding to your reply.
Lv Yunlong <lyl2019@mail.ustc.edu.cn>
next reply other threads:[~2021-04-27 2:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 2:55 lyl2019 [this message]
2021-05-01 0:10 ` [BUG] ethernet:enic: A use after free bug in enic_hard_start_xmit Govindarajulu Varadarajan
2021-05-01 15:34 ` lyl2019
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65becad9.62766.17911406ff0.Coremail.lyl2019@mail.ustc.edu.cn \
--to=lyl2019@mail.ustc.edu.cn \
--cc=_govind@gmx.com \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).