netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: lyl2019@mail.ustc.edu.cn
To: "Govindarajulu Varadarajan" <govind.varadar@gmail.com>
Cc: benve@cisco.com, davem@davemloft.net, kuba@kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Re: [BUG] ethernet:enic: A use after free bug in enic_hard_start_xmit
Date: Sat, 1 May 2021 23:34:21 +0800 (GMT+08:00)	[thread overview]
Message-ID: <8601748.6d378.1792890fe2f.Coremail.lyl2019@mail.ustc.edu.cn> (raw)
In-Reply-To: <8e420732d2aabccca8b5e932b589ce90d9f70d6b.camel@gmail.com>




> -----原始邮件-----
> 发件人: "Govindarajulu Varadarajan" <govind.varadar@gmail.com>
> 发送时间: 2021-05-01 08:10:02 (星期六)
> 收件人: lyl2019@mail.ustc.edu.cn, benve@cisco.com, davem@davemloft.net, kuba@kernel.org
> 抄送: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
> 主题: Re: [BUG] ethernet:enic: A use after free bug in enic_hard_start_xmit
> 
> On Tue, 2021-04-27 at 10:55 +0800, lyl2019@mail.ustc.edu.cn wrote:
> > Hi, maintainers.
> >     Our code analyzer reported a uaf bug, but it is a little
> > difficult for me to fix it directly.
> > 
> > File: drivers/net/ethernet/cisco/enic/enic_main.c
> > In enic_hard_start_xmit, it calls enic_queue_wq_skb(). Inside
> > enic_queue_wq_skb, if some error happens, the skb will be freed
> > by dev_kfree_skb(skb). But the freed skb is still used in 
> > skb_tx_timestamp(skb).
> > 
> > ```
> >         enic_queue_wq_skb(enic, wq, skb);// skb could freed here
> > 
> >         if (vnic_wq_desc_avail(wq) < MAX_SKB_FRAGS + ENIC_DESC_MAX_SPLITS)
> >                 netif_tx_stop_queue(txq);
> >         skb_tx_timestamp(skb); // freed skb is used here.
> > ```
> > Bug introduced by fb7516d42478e ("enic: add sw timestamp support").
> 
> Thank you for reporting this.
> 
> One solution is to make enic_queue_wq_skb() return error and goto spin_unlock()
> incase of error.
> 
> Would you like to send the fix for this?
> 
> --
> Govind
> 

It is my pleasure, i have submitted this fix.
See https://lore.kernel.org/patchwork/patch/1420692/.

Thanks.

      reply	other threads:[~2021-05-01 15:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27  2:55 [BUG] ethernet:enic: A use after free bug in enic_hard_start_xmit lyl2019
2021-05-01  0:10 ` Govindarajulu Varadarajan
2021-05-01 15:34   ` lyl2019 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8601748.6d378.1792890fe2f.Coremail.lyl2019@mail.ustc.edu.cn \
    --to=lyl2019@mail.ustc.edu.cn \
    --cc=benve@cisco.com \
    --cc=davem@davemloft.net \
    --cc=govind.varadar@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).