From: Johannes Berg <johannes@sipsolutions.net>
To: Tejun Heo <tj@kernel.org>
Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org,
kernel-team@meta.com, Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Gregory Greenman <gregory.greenman@intel.com>,
Avraham Stern <avraham.stern@intel.com>,
Kees Cook <keescook@chromium.org>,
Mordechay Goodstein <mordechay.goodstein@intel.com>,
"Haim, Dreyfuss" <haim.dreyfuss@intel.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] wifi: iwlwifi: Use default @max_active for trans_pcie->rba.alloc_wq
Date: Mon, 08 May 2023 18:05:11 +0200 [thread overview]
Message-ID: <68404955637d963f3111a60d3d99c1be8b5d4045.camel@sipsolutions.net> (raw)
In-Reply-To: <ZFWIpN7HN431MVSI@slm.duckdns.org>
On Fri, 2023-05-05 at 12:52 -1000, Tejun Heo wrote:
> trans_pcie->rba.alloc_wq only hosts a single work item and thus doesn't need
> explicit concurrency limit. Let's use the default @max_active. This doesn't
> cost anything and clearly expresses that @max_active doesn't matter.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Kalle Valo <kvalo@kernel.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Gregory Greenman <gregory.greenman@intel.com>
> Cc: Johannes Berg <johannes.berg@intel.com>
> Cc: Avraham Stern <avraham.stern@intel.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Mordechay Goodstein <mordechay.goodstein@intel.com>
> Cc: "Haim, Dreyfuss" <haim.dreyfuss@intel.com>
> Cc: linux-wireless@vger.kernel.org
> Cc: netdev@vger.kernel.org
>
Sure, that seems fine too.
Acked-by: Johannes Berg <johannes.berg@intel.com>
For whatever that's worth, might better to get Gregory ;-)
johannes
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
> @@ -3577,7 +3577,7 @@ struct iwl_trans *iwl_trans_pcie_alloc(s
> init_waitqueue_head(&trans_pcie->imr_waitq);
>
> trans_pcie->rba.alloc_wq = alloc_workqueue("rb_allocator",
> - WQ_HIGHPRI | WQ_UNBOUND, 1);
> + WQ_HIGHPRI | WQ_UNBOUND, 0);
> if (!trans_pcie->rba.alloc_wq) {
> ret = -ENOMEM;
> goto out_free_trans;
>
next prev parent reply other threads:[~2023-05-08 16:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230421025046.4008499-1-tj@kernel.org>
2023-04-21 2:50 ` [PATCH 06/22] net: thunderx: Use alloc_ordered_workqueue() to create ordered workqueues Tejun Heo
2023-04-21 6:19 ` [EXT] " Sunil Kovvuri Goutham
2023-04-21 14:01 ` Jakub Kicinski
2023-04-21 14:13 ` Tejun Heo
2023-04-21 14:28 ` Jakub Kicinski
2023-05-08 23:57 ` Tejun Heo
2023-04-21 2:50 ` [PATCH 07/22] net: octeontx2: " Tejun Heo
2023-04-21 6:16 ` [EXT] " Sunil Kovvuri Goutham
2023-05-08 23:56 ` Tejun Heo
2023-04-21 2:50 ` [PATCH 08/22] wifi: ath10/11/12k: " Tejun Heo
2023-04-21 2:50 ` [PATCH 09/22] wifi: iwlwifi: " Tejun Heo
2023-04-24 17:31 ` Johannes Berg
2023-05-05 22:52 ` [PATCH] wifi: iwlwifi: Use default @max_active for trans_pcie->rba.alloc_wq Tejun Heo
2023-05-08 16:05 ` Johannes Berg [this message]
2023-05-08 23:59 ` [PATCH 09/22] wifi: iwlwifi: Use alloc_ordered_workqueue() to create ordered workqueues Tejun Heo
2023-05-09 15:25 ` Tejun Heo
2023-04-21 2:50 ` [PATCH 10/22] wifi: mwifiex: " Tejun Heo
2023-04-25 18:14 ` Brian Norris
2023-05-05 22:53 ` [PATCH] wifi: mwifiex: Use default @max_active for workqueues Tejun Heo
2023-04-21 2:50 ` [PATCH 11/22] net: wwan: t7xx: Use alloc_ordered_workqueue() to create ordered workqueues Tejun Heo
2023-04-21 2:50 ` [PATCH 18/22] net: qrtr: " Tejun Heo
2023-04-21 2:50 ` [PATCH 19/22] rxrpc: " Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68404955637d963f3111a60d3d99c1be8b5d4045.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=avraham.stern@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregory.greenman@intel.com \
--cc=haim.dreyfuss@intel.com \
--cc=jiangshanlai@gmail.com \
--cc=keescook@chromium.org \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mordechay.goodstein@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).