From: Johannes Berg <johannes@sipsolutions.net>
To: Tejun Heo <tj@kernel.org>, jiangshanlai@gmail.com
Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com,
Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Gregory Greenman <gregory.greenman@intel.com>,
Avraham Stern <avraham.stern@intel.com>,
Kees Cook <keescook@chromium.org>,
Mordechay Goodstein <mordechay.goodstein@intel.com>,
"Haim, Dreyfuss" <haim.dreyfuss@intel.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 09/22] wifi: iwlwifi: Use alloc_ordered_workqueue() to create ordered workqueues
Date: Mon, 24 Apr 2023 19:31:22 +0200 [thread overview]
Message-ID: <fffb3e6ad76a26a9633728501b5d606864235e65.camel@sipsolutions.net> (raw)
In-Reply-To: <20230421025046.4008499-10-tj@kernel.org>
On Thu, 2023-04-20 at 16:50 -1000, Tejun Heo wrote:
> This patch series audits all callsites that create an UNBOUND workqueue w/
> @max_active==1 and converts them to alloc_ordered_workqueue() as necessary.
>
> WHAT TO LOOK FOR
> ================
>
> The conversions are from
>
> alloc_workqueue(WQ_UNBOUND | flags, 1, args..)
>
> to
>
> alloc_ordered_workqueue(flags, args...)
>
> which don't cause any functional changes. If you know that fully ordered
> execution is not ncessary, please let me know. I'll drop the conversion and
> instead add a comment noting the fact to reduce confusion while conversion
> is in progress.
This workqueue only has a single work struct queued on it, I'm not
_entirely_ sure why there's even a separate workqueue (possibly for
priority reasons etc.), but surely with just a single work struct, order
cannot really matter.
johannes
next prev parent reply other threads:[~2023-04-24 17:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230421025046.4008499-1-tj@kernel.org>
2023-04-21 2:50 ` [PATCH 06/22] net: thunderx: Use alloc_ordered_workqueue() to create ordered workqueues Tejun Heo
2023-04-21 6:19 ` [EXT] " Sunil Kovvuri Goutham
2023-04-21 14:01 ` Jakub Kicinski
2023-04-21 14:13 ` Tejun Heo
2023-04-21 14:28 ` Jakub Kicinski
2023-05-08 23:57 ` Tejun Heo
2023-04-21 2:50 ` [PATCH 07/22] net: octeontx2: " Tejun Heo
2023-04-21 6:16 ` [EXT] " Sunil Kovvuri Goutham
2023-05-08 23:56 ` Tejun Heo
2023-04-21 2:50 ` [PATCH 08/22] wifi: ath10/11/12k: " Tejun Heo
2023-04-21 2:50 ` [PATCH 09/22] wifi: iwlwifi: " Tejun Heo
2023-04-24 17:31 ` Johannes Berg [this message]
2023-05-05 22:52 ` [PATCH] wifi: iwlwifi: Use default @max_active for trans_pcie->rba.alloc_wq Tejun Heo
2023-05-08 16:05 ` Johannes Berg
2023-05-08 23:59 ` [PATCH 09/22] wifi: iwlwifi: Use alloc_ordered_workqueue() to create ordered workqueues Tejun Heo
2023-05-09 15:25 ` Tejun Heo
2023-04-21 2:50 ` [PATCH 10/22] wifi: mwifiex: " Tejun Heo
2023-04-25 18:14 ` Brian Norris
2023-05-05 22:53 ` [PATCH] wifi: mwifiex: Use default @max_active for workqueues Tejun Heo
2023-04-21 2:50 ` [PATCH 11/22] net: wwan: t7xx: Use alloc_ordered_workqueue() to create ordered workqueues Tejun Heo
2023-04-21 2:50 ` [PATCH 18/22] net: qrtr: " Tejun Heo
2023-04-21 2:50 ` [PATCH 19/22] rxrpc: " Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fffb3e6ad76a26a9633728501b5d606864235e65.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=avraham.stern@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregory.greenman@intel.com \
--cc=haim.dreyfuss@intel.com \
--cc=jiangshanlai@gmail.com \
--cc=keescook@chromium.org \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mordechay.goodstein@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).