* [PATCH net-next] r8169: use netif_start_queue instead of netif_wake_qeueue in rtl8169_start_xmit
@ 2019-03-21 20:41 Heiner Kallweit
2019-03-22 14:35 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2019-03-21 20:41 UTC (permalink / raw)
To: Realtek linux nic maintainers, David Miller; +Cc: Alexander Duyck, netdev
Replace the call to netif_wake_queue in rtl8169_start_xmit with
netif_start_queue as we don't need to actually wake up the queue since
we are still in mid transmit so we just need to reset the bit so it
doesn't prevent the next transmit.
(Description shamelessly copied from a mail sent by Alex.)
Suggested-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 9dd1cd2c0..a542cd121 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -6267,7 +6267,7 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb,
*/
smp_mb();
if (rtl_tx_slots_avail(tp, MAX_SKB_FRAGS))
- netif_wake_queue(dev);
+ netif_start_queue(dev);
}
return NETDEV_TX_OK;
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] r8169: use netif_start_queue instead of netif_wake_qeueue in rtl8169_start_xmit
2019-03-21 20:41 [PATCH net-next] r8169: use netif_start_queue instead of netif_wake_qeueue in rtl8169_start_xmit Heiner Kallweit
@ 2019-03-22 14:35 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-03-22 14:35 UTC (permalink / raw)
To: hkallweit1; +Cc: nic_swsd, alexander.h.duyck, netdev
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Thu, 21 Mar 2019 21:41:48 +0100
> Replace the call to netif_wake_queue in rtl8169_start_xmit with
> netif_start_queue as we don't need to actually wake up the queue since
> we are still in mid transmit so we just need to reset the bit so it
> doesn't prevent the next transmit.
> (Description shamelessly copied from a mail sent by Alex.)
>
> Suggested-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-22 14:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-21 20:41 [PATCH net-next] r8169: use netif_start_queue instead of netif_wake_qeueue in rtl8169_start_xmit Heiner Kallweit
2019-03-22 14:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).