From: "Jonathan Lemon" <jonathan.lemon@gmail.com>
To: "Eric Dumazet" <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
"Eric Dumazet" <eric.dumazet@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jonathan Looney" <jtl@netflix.com>,
"Neal Cardwell" <ncardwell@google.com>,
"Tyler Hicks" <tyhicks@canonical.com>,
"Yuchung Cheng" <ycheng@google.com>,
"Bruce Curtis" <brucec@netflix.com>
Subject: Re: [PATCH net 1/4] tcp: limit payload size of sacked skbs
Date: Mon, 17 Jun 2019 10:14:12 -0700 [thread overview]
Message-ID: <A4CFC6DF-2519-4286-9CF2-6994500EFB86@gmail.com> (raw)
In-Reply-To: <20190617170354.37770-2-edumazet@google.com>
On 17 Jun 2019, at 10:03, Eric Dumazet wrote:
> Jonathan Looney reported that TCP can trigger the following crash
> in tcp_shifted_skb() :
>
> BUG_ON(tcp_skb_pcount(skb) < pcount);
>
> This can happen if the remote peer has advertized the smallest
> MSS that linux TCP accepts : 48
>
> An skb can hold 17 fragments, and each fragment can hold 32KB
> on x86, or 64KB on PowerPC.
>
> This means that the 16bit witdh of TCP_SKB_CB(skb)->tcp_gso_segs
> can overflow.
>
> Note that tcp_sendmsg() builds skbs with less than 64KB
> of payload, so this problem needs SACK to be enabled.
> SACK blocks allow TCP to coalesce multiple skbs in the retransmit
> queue, thus filling the 17 fragments to maximal capacity.
>
> CVE-2019-11477 -- u16 overflow of TCP_SKB_CB(skb)->tcp_gso_segs
>
> Fixes: 832d11c5cd07 ("tcp: Try to restore large SKBs while SACK
> processing")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Jonathan Looney <jtl@netflix.com>
> Acked-by: Neal Cardwell <ncardwell@google.com>
> Reviewed-by: Tyler Hicks <tyhicks@canonical.com>
Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com>
next prev parent reply other threads:[~2019-06-17 17:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 17:03 [PATCH net 0/4] tcp: make sack processing more robust Eric Dumazet
2019-06-17 17:03 ` [PATCH net 1/4] tcp: limit payload size of sacked skbs Eric Dumazet
2019-06-17 17:14 ` Jonathan Lemon [this message]
2019-06-17 17:03 ` [PATCH net 2/4] tcp: tcp_fragment() should apply sane memory limits Eric Dumazet
2019-06-17 17:14 ` Jonathan Lemon
2019-06-18 0:18 ` Christoph Paasch
2019-06-18 2:28 ` Eric Dumazet
2019-06-18 3:19 ` Christoph Paasch
2019-06-18 3:44 ` Eric Dumazet
2019-06-18 3:53 ` Christoph Paasch
2019-06-18 4:08 ` Eric Dumazet
2019-07-10 18:23 ` Prout, Andrew - LLSC - MITLL
2019-07-10 18:28 ` Eric Dumazet
2019-07-10 18:53 ` Prout, Andrew - LLSC - MITLL
2019-07-10 19:26 ` Eric Dumazet
2019-07-11 7:28 ` Christoph Paasch
2019-07-11 9:19 ` Eric Dumazet
2019-07-11 18:26 ` Michal Kubecek
2019-07-11 18:50 ` Eric Dumazet
2019-07-11 10:18 ` Eric Dumazet
2019-07-11 17:14 ` Prout, Andrew - LLSC - MITLL
2019-07-11 18:28 ` Eric Dumazet
2019-07-11 19:04 ` Jonathan Lemon
2019-07-12 7:05 ` Eric Dumazet
2019-07-16 15:13 ` Prout, Andrew - LLSC - MITLL
2019-06-17 17:03 ` [PATCH net 3/4] tcp: add tcp_min_snd_mss sysctl Eric Dumazet
2019-06-17 17:15 ` Jonathan Lemon
2019-06-17 17:18 ` Tyler Hicks
2019-06-17 17:03 ` [PATCH net 4/4] tcp: enforce tcp_min_snd_mss in tcp_mtu_probing() Eric Dumazet
2019-06-17 17:16 ` Jonathan Lemon
2019-06-17 17:18 ` Tyler Hicks
2019-06-17 17:41 ` [PATCH net 0/4] tcp: make sack processing more robust David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A4CFC6DF-2519-4286-9CF2-6994500EFB86@gmail.com \
--to=jonathan.lemon@gmail.com \
--cc=brucec@netflix.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jtl@netflix.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=tyhicks@canonical.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).