From: Holger Brunck <holger.brunck@hitachienergy.com>
To: "Marek Behún" <kabel@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Andrew Lunn <andrew@lunn.ch>
Subject: RE: [v3 2/2] dsa: mv88e6xxx: make serdes SGMII/Fiber output amplitude configurable
Date: Thu, 20 Jan 2022 07:52:01 +0000 [thread overview]
Message-ID: <AM0PR0602MB36663B72C5574E30DF7A6805F75A9@AM0PR0602MB3666.eurprd06.prod.outlook.com> (raw)
In-Reply-To: <20211215215350.7a8b353a@thinkpad>
Hi Marek,
> >
> > > > This gets interesting when PCIe and USB needs to use this
> > > > property, what names are used, and if it is possible to combine
> > > > two different lists?
> > >
> > > I don't think it is possible, I tried that once and couldn't get it to work.
> > >
> > > I am going to try write the proposal. But unfortunately PHY binding
> > > is not converted to YAML yet :(
> > >
> >
> > I saw you recent patches to convert this. Thanks!
> >
> > This make my serdes.yaml obsolete then, correct? Should I then only
> > re-post my driver code, once your patches are accepted?
>
> Yes, please let's do it this way. It may take some time for Rob to review this,
> though, and he may require some changes.
>
I saw your v3 patch for the bindings and I would adapt then my patch
accordingly to tx-p2p-microvolt.
> Also I was thinking whether it wouldn't be better to put the property into a
> separate SerDes PHY node, i.e.
>
> switch {
> compatible = "marvell,mv88e6085";
> ...
>
> ports {
> port@6 {
> reg = <0x6>;
> phy-handle = <&switch_serdes_phy>;
> };
>
> ...
> };
>
> mdio {
> switch_serdes_phy: ethernet-phy@f {
> reg = <0xf>;
> tx-amplitude-microvolt = <1234567>;
> };
>
> ...
> };
> };
this would mean in regard to my patch instead of checking directly for the
property in mv88e6xxx_setup_port I would parse for the phy-handle first
and then for the property?
Should I wait until your patch is accepted and merged?
Best regards
Holger
next prev parent reply other threads:[~2022-01-20 7:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 19:07 [v3 1/2] Docs/devicetree: add serdes.yaml Holger Brunck
2021-12-07 19:07 ` [v3 2/2] dsa: mv88e6xxx: make serdes SGMII/Fiber output amplitude configurable Holger Brunck
2021-12-07 19:27 ` Marek Behún
2021-12-08 12:29 ` Holger Brunck
2021-12-08 15:28 ` Marek Behún
2021-12-08 15:49 ` Holger Brunck
2021-12-08 16:17 ` Marek Behún
2021-12-08 16:21 ` Marek Behún
2021-12-08 16:41 ` Vladimir Oltean
2021-12-08 16:49 ` Vladimir Oltean
2021-12-08 17:00 ` Marek Behún
2021-12-08 17:19 ` Vladimir Oltean
2021-12-08 17:36 ` Marek Behún
2021-12-08 17:55 ` Andrew Lunn
2021-12-08 18:15 ` Marek Behún
2021-12-08 16:51 ` Marek Behún
2021-12-08 16:59 ` Vladimir Oltean
2021-12-08 17:10 ` Marek Behún
2021-12-08 17:12 ` Marek Behún
2021-12-08 17:20 ` Vladimir Oltean
2021-12-08 17:00 ` Andrew Lunn
2021-12-08 17:16 ` Marek Behún
2021-12-15 10:27 ` Holger Brunck
2021-12-15 20:53 ` Marek Behún
2022-01-20 7:52 ` Holger Brunck [this message]
2022-01-20 17:57 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0602MB36663B72C5574E30DF7A6805F75A9@AM0PR0602MB3666.eurprd06.prod.outlook.com \
--to=holger.brunck@hitachienergy.com \
--cc=andrew@lunn.ch \
--cc=kabel@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).