From: Michael Chan <michael.chan@broadcom.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Pavan Chebbi <pavan.chebbi@broadcom.com>,
Andrea Fois <andrea.fois@eventsense.it>,
Michael Chan <mchan@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
George Shuklin <george.shuklin@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tg3: add new module param to force device power down on reboot
Date: Wed, 10 Jan 2024 09:01:28 -0800 [thread overview]
Message-ID: <CACKFLikZoXq17tp_152Oi4eYPd8BQLAv+LTxDgb4sHxX+8XiSA@mail.gmail.com> (raw)
In-Reply-To: <a26b3079-f5fa-47b0-8b83-42db9fbbf3c4@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 533 bytes --]
On Tue, Jan 9, 2024 at 11:34 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> On 10.01.2024 08:17, Michael Chan wrote:
> > We already call dev_close() which will call tg3_close() -> tg3_stop()
> > a few lines above.
>
> tg3_stop() calls tg3_disable_ints(), so I wonder how a MSI interrupt can
> occur after that. Does tg3_disable_ints() disable interrupts synchronously?
> Or maybe some kind of commit is needed?
>
Yes, it is synchronous. The tg3_full_lock() call before
tg3_disable_ints() makes it synchronous.
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
prev parent reply other threads:[~2024-01-10 17:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 19:45 [PATCH] tg3: add new module param to force device power down on reboot Andrea Fois
2024-01-09 20:31 ` Heiner Kallweit
2024-01-10 4:12 ` Pavan Chebbi
2024-01-10 7:09 ` Heiner Kallweit
2024-01-10 7:17 ` Michael Chan
2024-01-10 7:34 ` Heiner Kallweit
2024-01-10 17:01 ` Michael Chan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACKFLikZoXq17tp_152Oi4eYPd8BQLAv+LTxDgb4sHxX+8XiSA@mail.gmail.com \
--to=michael.chan@broadcom.com \
--cc=andrea.fois@eventsense.it \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=george.shuklin@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).