Re: [PATCH] tg3: add new module param to force device power down on reboot

From: Michael Chan <michael.chan@broadcom.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Pavan Chebbi <pavan.chebbi@broadcom.com>,
	Andrea Fois <andrea.fois@eventsense.it>,
	 Michael Chan <mchan@broadcom.com>,
	"David S. Miller" <davem@davemloft.net>,
	 Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	 George Shuklin <george.shuklin@gmail.com>,
	netdev@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tg3: add new module param to force device power down on reboot
Date: Tue, 9 Jan 2024 23:17:36 -0800	[thread overview]
Message-ID: <CACKFLinZ=pkRn7oertS8W96bGmMjr8T+BvqSAN3BZ7SiEm5gxQ@mail.gmail.com> (raw)
In-Reply-To: <18249a21-7aec-4a66-bc5a-3aa077c2b190@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 909 bytes --]

On Tue, Jan 9, 2024 at 11:09 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> On 10.01.2024 05:12, Pavan Chebbi wrote:
> > I think the second suggestion could be a better solution. Helps to
> > solve the issue 9fc3bc764334 is trying to fix.
> > But I am not sure how easy it is to test. As I recall, Goerge was
> > unable to reach out to the author of 2ca1c94ce0b6 when he wanted to
> > test his patch for regression.
> > We did discuss the risk of this regression.
> > https://patchwork.kernel.org/project/netdevbpf/patch/20231101130418.44164-1-george.shuklin@gmail.com/
> > Unfortunately, looks like it has come true :(
>
> If the culprit is an unexpected MSI interrupt, then you may also address
> this directly by disabling interrupts in the device. tg3_stop() may be
> a candidate here.
>

We already call dev_close() which will call tg3_close() -> tg3_stop()
a few lines above.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]