* [PATCH] net: fix build warning in trans_rdma.c
@ 2013-07-30 9:15 Xishi Qiu
2013-07-30 9:27 ` Daniel Baluta
0 siblings, 1 reply; 2+ messages in thread
From: Xishi Qiu @ 2013-07-30 9:15 UTC (permalink / raw)
To: ericvh, rminnich, lucho, davem, v9fs-developer, netdev, LKML
When building v3.11-rc3, I get the following warning:
...
net/9p/trans_rdma.c:594: warning: ‘rdma_cancelled’ defined but not used
...
As the function is not be used, so remove it.
Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
---
net/9p/trans_rdma.c | 11 -----------
1 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c
index 928f2bb..8f68df5 100644
--- a/net/9p/trans_rdma.c
+++ b/net/9p/trans_rdma.c
@@ -588,17 +588,6 @@ static int rdma_cancel(struct p9_client *client, struct p9_req_t *req)
return 1;
}
-/* A request has been fully flushed without a reply.
- * That means we have posted one buffer in excess.
- */
-static int rdma_cancelled(struct p9_client *client, struct p9_req_t *req)
-{
- struct p9_trans_rdma *rdma = client->trans;
-
- atomic_inc(&rdma->excess_rc);
- return 0;
-}
-
/**
* trans_create_rdma - Transport method for creating atransport instance
* @client: client instance
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: fix build warning in trans_rdma.c
2013-07-30 9:15 [PATCH] net: fix build warning in trans_rdma.c Xishi Qiu
@ 2013-07-30 9:27 ` Daniel Baluta
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Baluta @ 2013-07-30 9:27 UTC (permalink / raw)
To: Xishi Qiu; +Cc: ericvh, rminnich, lucho, davem, v9fs-developer, netdev, LKML
On Tue, Jul 30, 2013 at 12:15 PM, Xishi Qiu <qiuxishi@huawei.com> wrote:
> When building v3.11-rc3, I get the following warning:
> ...
> net/9p/trans_rdma.c:594: warning: ‘rdma_cancelled’ defined but not used
> ...
> As the function is not be used, so remove it.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> ---
> net/9p/trans_rdma.c | 11 -----------
> 1 files changed, 0 insertions(+), 11 deletions(-)
>
> diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c
> index 928f2bb..8f68df5 100644
> --- a/net/9p/trans_rdma.c
> +++ b/net/9p/trans_rdma.c
> @@ -588,17 +588,6 @@ static int rdma_cancel(struct p9_client *client, struct p9_req_t *req)
> return 1;
> }
>
> -/* A request has been fully flushed without a reply.
> - * That means we have posted one buffer in excess.
> - */
> -static int rdma_cancelled(struct p9_client *client, struct p9_req_t *req)
> -{
> - struct p9_trans_rdma *rdma = client->trans;
> -
> - atomic_inc(&rdma->excess_rc);
> - return 0;
> -}
> -
> /**
> * trans_create_rdma - Transport method for creating atransport instance
> * @client: client instance
Hi,
This is wrong.
Please check http://comments.gmane.org/gmane.linux.network/276261.
thanks,
Daniel.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-30 9:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-30 9:15 [PATCH] net: fix build warning in trans_rdma.c Xishi Qiu
2013-07-30 9:27 ` Daniel Baluta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).