* [PATCH -next] sfc: fix sparse non static symbol warning
@ 2013-12-17 3:08 Wei Yongjun
2013-12-19 20:00 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-12-17 3:08 UTC (permalink / raw)
To: linux-net-drivers, bhutchings; +Cc: yongjun_wei, netdev
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fixes the following sparse warning:
drivers/net/ethernet/sfc/falcon.c:2601:6: warning:
symbol 'falcon_pull_nic_stats' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/net/ethernet/sfc/falcon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/falcon.c b/drivers/net/ethernet/sfc/falcon.c
index 76699f4..1df52db 100644
--- a/drivers/net/ethernet/sfc/falcon.c
+++ b/drivers/net/ethernet/sfc/falcon.c
@@ -2598,7 +2598,7 @@ void falcon_start_nic_stats(struct efx_nic *efx)
/* We don't acutally pull stats on falcon. Wait 10ms so that
* they arrive when we call this just after start_stats
*/
-void falcon_pull_nic_stats(struct efx_nic *efx)
+static void falcon_pull_nic_stats(struct efx_nic *efx)
{
msleep(10);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] sfc: fix sparse non static symbol warning
2013-12-17 3:08 [PATCH -next] sfc: fix sparse non static symbol warning Wei Yongjun
@ 2013-12-19 20:00 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-12-19 20:00 UTC (permalink / raw)
To: weiyj.lk; +Cc: linux-net-drivers, bhutchings, yongjun_wei, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Tue, 17 Dec 2013 11:08:10 +0800
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fixes the following sparse warning:
>
> drivers/net/ethernet/sfc/falcon.c:2601:6: warning:
> symbol 'falcon_pull_nic_stats' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Looks good, applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-19 20:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-17 3:08 [PATCH -next] sfc: fix sparse non static symbol warning Wei Yongjun
2013-12-19 20:00 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).