RE: [RFC net-next] net: stmmac: should not modify RX descriptor when STMMAC resume

[Joakim Zhang <qiangqing.zhang@nxp.com>]

> -----Original Message-----
> From: Jon Hunter <jonathanh@nvidia.com>
> Sent: 2021年4月20日 21:34
> To: Joakim Zhang <qiangqing.zhang@nxp.com>; peppe.cavallaro@st.com;
> alexandre.torgue@foss.st.com; joabreu@synopsys.com;
> davem@davemloft.net; kuba@kernel.org; mcoquelin.stm32@gmail.com;
> andrew@lunn.ch; f.fainelli@gmail.com
> Cc: dl-linux-imx <linux-imx@nxp.com>; treding@nvidia.com;
> netdev@vger.kernel.org
> Subject: Re: [RFC net-next] net: stmmac: should not modify RX descriptor when
> STMMAC resume
> 
> 
> 
> On 20/04/2021 02:49, Joakim Zhang wrote:
> 
> ...
> 
> >> I have tested this patch, but unfortunately the board still fails to
> >> resume correctly. So it appears to suffer with the same issue we saw
> >> on the previous implementation.
> >
> > Could I double check with you? Have you reverted Commit 9c63faaa931e
> ("net: stmmac: re-init rx buffers when mac resume back") and then apply above
> patch to do the test?
> >
> > If yes, you still saw the same issue with Commit 9c63faaa931e? Let's recall
> the problem, system suspended, but system hang when STMMAC resume back,
> right?
>
> 
> I tested your patch on top of next-20210419 which has Thierry's revert of
> 9c63faaa931e. So yes this is reverted. Unfortunately, with this change
> resuming from suspend still does not work.


Hi Jakub, Andrew,

Could you please help review this patch? It's really beyond my comprehension, why this patch would affect Tegra186 Jetson TX2 board?
Thanks a lot!

Best Regards,
Joakim Zhang
> Jon
> 
> --
> nvpublic