* [PATCH net 2/4] net: wwan: iosm: fix dma_alloc_coherent incompatible pointer type
@ 2022-11-22 17:46 m.chetan.kumar
2022-11-23 21:58 ` Salvatore Bonaccorso
0 siblings, 1 reply; 2+ messages in thread
From: m.chetan.kumar @ 2022-11-22 17:46 UTC (permalink / raw)
To: netdev
Cc: kuba, davem, johannes, ryazanov.s.a, loic.poulain,
m.chetan.kumar, linuxwwan, edumazet, pabeni, didi.debian,
Bonaccorso Salvatore
From: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
Fix build error reported on armhf while preparing 6.1-rc5
for Debian.
iosm_ipc_protocol.c:244:36: error: passing argument 3 of
'dma_alloc_coherent' from incompatible pointer type.
Change phy_ap_shm type from phys_addr_t to dma_addr_t.
Fixes: faed4c6f6f48 ("net: iosm: shared memory protocol")
Reported-by: Bonaccorso Salvatore <carnil@debian.org>
Signed-off-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
---
drivers/net/wwan/iosm/iosm_ipc_protocol.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wwan/iosm/iosm_ipc_protocol.h b/drivers/net/wwan/iosm/iosm_ipc_protocol.h
index 9b3a6d86ece7..289397c4ea6c 100644
--- a/drivers/net/wwan/iosm/iosm_ipc_protocol.h
+++ b/drivers/net/wwan/iosm/iosm_ipc_protocol.h
@@ -122,7 +122,7 @@ struct iosm_protocol {
struct iosm_imem *imem;
struct ipc_rsp *rsp_ring[IPC_MEM_MSG_ENTRIES];
struct device *dev;
- phys_addr_t phy_ap_shm;
+ dma_addr_t phy_ap_shm;
u32 old_msg_tail;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net 2/4] net: wwan: iosm: fix dma_alloc_coherent incompatible pointer type
2022-11-22 17:46 [PATCH net 2/4] net: wwan: iosm: fix dma_alloc_coherent incompatible pointer type m.chetan.kumar
@ 2022-11-23 21:58 ` Salvatore Bonaccorso
0 siblings, 0 replies; 2+ messages in thread
From: Salvatore Bonaccorso @ 2022-11-23 21:58 UTC (permalink / raw)
To: m.chetan.kumar
Cc: netdev, kuba, davem, johannes, ryazanov.s.a, loic.poulain,
linuxwwan, edumazet, pabeni, didi.debian
Hi,
On Tue, Nov 22, 2022 at 11:16:57PM +0530, m.chetan.kumar@linux.intel.com wrote:
> From: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
>
> Fix build error reported on armhf while preparing 6.1-rc5
> for Debian.
>
> iosm_ipc_protocol.c:244:36: error: passing argument 3 of
> 'dma_alloc_coherent' from incompatible pointer type.
>
> Change phy_ap_shm type from phys_addr_t to dma_addr_t.
>
> Fixes: faed4c6f6f48 ("net: iosm: shared memory protocol")
> Reported-by: Bonaccorso Salvatore <carnil@debian.org>
> Signed-off-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
> ---
> drivers/net/wwan/iosm/iosm_ipc_protocol.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wwan/iosm/iosm_ipc_protocol.h b/drivers/net/wwan/iosm/iosm_ipc_protocol.h
> index 9b3a6d86ece7..289397c4ea6c 100644
> --- a/drivers/net/wwan/iosm/iosm_ipc_protocol.h
> +++ b/drivers/net/wwan/iosm/iosm_ipc_protocol.h
> @@ -122,7 +122,7 @@ struct iosm_protocol {
> struct iosm_imem *imem;
> struct ipc_rsp *rsp_ring[IPC_MEM_MSG_ENTRIES];
> struct device *dev;
> - phys_addr_t phy_ap_shm;
> + dma_addr_t phy_ap_shm;
> u32 old_msg_tail;
> };
The patch resolves the build failure we did notice. Only was able to
test the build though, no functional test on armhf.
Regards,
Salvatore
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-23 21:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-22 17:46 [PATCH net 2/4] net: wwan: iosm: fix dma_alloc_coherent incompatible pointer type m.chetan.kumar
2022-11-23 21:58 ` Salvatore Bonaccorso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).