From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tobias Brunner <tobias@strongswan.org>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH ipsec] af_key: Reject optional tunnel/BEET mode templates in outbound policies
Date: Mon, 8 May 2023 11:10:12 +0800 [thread overview]
Message-ID: <ZFhoFBrOREHcify3@gondor.apana.org.au> (raw)
In-Reply-To: <46fcb205-989e-4ea7-463d-e72b85db9e71@strongswan.org>
On Fri, May 05, 2023 at 01:36:15PM +0200, Tobias Brunner wrote:
> xfrm_state_find() uses `encap_family` of the current template with
> the passed local and remote addresses to find a matching state.
> If an optional tunnel or BEET mode template is skipped in a mixed-family
> scenario, there could be a mismatch causing an out-of-bounds read as
> the addresses were not replaced to match the family of the next template.
>
> While there are theoretical use cases for optional templates in outbound
> policies, the only practical one is to skip IPComp states in inbound
> policies if uncompressed packets are received that are handled by an
> implicitly created IPIP state instead.
>
> Signed-off-by: Tobias Brunner <tobias@strongswan.org>
> ---
> net/key/af_key.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2023-05-08 3:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 13:23 [PATCH ipsec] xfrm: Ensure consistent address families when resolving templates Tobias Brunner
2023-04-25 5:34 ` Herbert Xu
2023-04-25 6:47 ` Steffen Klassert
2023-04-25 8:26 ` Herbert Xu
2023-04-25 8:00 ` Tobias Brunner
2023-04-25 8:28 ` Herbert Xu
2023-05-05 10:16 ` [PATCH ipsec] xfrm: Reject optional tunnel/BEET mode templates in outbound policies Tobias Brunner
2023-05-05 10:43 ` Herbert Xu
2023-05-05 11:36 ` [PATCH ipsec] af_key: " Tobias Brunner
2023-05-08 3:10 ` Herbert Xu [this message]
2023-05-08 6:01 ` Steffen Klassert
2023-05-09 9:00 ` Tobias Brunner
2023-05-11 10:04 ` Steffen Klassert
2023-05-08 5:59 ` [PATCH ipsec] xfrm: " Steffen Klassert
2023-05-08 9:03 ` Tobias Brunner
2023-05-09 4:27 ` Steffen Klassert
2023-05-09 8:59 ` Tobias Brunner
2023-05-11 10:03 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFhoFBrOREHcify3@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=tobias@strongswan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).