From: Steffen Klassert <steffen.klassert@secunet.com>
To: Tobias Brunner <tobias@strongswan.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
<netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH ipsec] xfrm: Reject optional tunnel/BEET mode templates in outbound policies
Date: Tue, 9 May 2023 06:27:05 +0200 [thread overview]
Message-ID: <ZFnLmakCaADGVGV3@gauss3.secunet.de> (raw)
In-Reply-To: <c29e3424-f6ef-4d38-e150-fcf82d364ad2@strongswan.org>
On Mon, May 08, 2023 at 11:03:36AM +0200, Tobias Brunner wrote:
> On 08.05.23 07:59, Steffen Klassert wrote:
> > On Fri, May 05, 2023 at 12:16:16PM +0200, Tobias Brunner wrote:
> >> xfrm_state_find() uses `encap_family` of the current template with
> >> the passed local and remote addresses to find a matching state.
> >> If an optional tunnel or BEET mode template is skipped in a mixed-family
> >> scenario, there could be a mismatch causing an out-of-bounds read as
> >> the addresses were not replaced to match the family of the next template.
> >>
> >> While there are theoretical use cases for optional templates in outbound
> >> policies, the only practical one is to skip IPComp states in inbound
> >> policies if uncompressed packets are received that are handled by an
> >> implicitly created IPIP state instead.
> >>
> >> Signed-off-by: Tobias Brunner <tobias@strongswan.org>
> >
> > Your patch seems to be corrupt:
> >
> > warning: Patch sent with format=flowed; space at the end of lines might be lost.
> > Applying: af_key: Reject optional tunnel/BEET mode templates in outbound policies
> > error: corrupt patch at line 18
>
> Sorry about that, I'll resend.
>
> > Also, please add a 'Fixes' tag, so that it can be backported.
>
> What should the target commit be? I saw you used 1da177e4c3f4
> ("Linux-2.6.12-rc2") in your fix, but maybe the more recent 8444cf712c5f
> ("xfrm: Allow different selector family in temporary state") would fit
> better as that changed `family` to `encap_family` in
> `xfrm_state_find()`? (I guess it doesn't matter in practice as 2.6.36
> is way older than any LTS kernel this will get backported to.)
I think it was broken, even before 8444cf712c5f "xfrm: Allow different
selector family in temporary state"), so I used 1da177e4c3f4.
But as you said, it doesn't really matter. Both commits are
much older than any currently active LTS kernel.
next prev parent reply other threads:[~2023-05-09 4:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 13:23 [PATCH ipsec] xfrm: Ensure consistent address families when resolving templates Tobias Brunner
2023-04-25 5:34 ` Herbert Xu
2023-04-25 6:47 ` Steffen Klassert
2023-04-25 8:26 ` Herbert Xu
2023-04-25 8:00 ` Tobias Brunner
2023-04-25 8:28 ` Herbert Xu
2023-05-05 10:16 ` [PATCH ipsec] xfrm: Reject optional tunnel/BEET mode templates in outbound policies Tobias Brunner
2023-05-05 10:43 ` Herbert Xu
2023-05-05 11:36 ` [PATCH ipsec] af_key: " Tobias Brunner
2023-05-08 3:10 ` Herbert Xu
2023-05-08 6:01 ` Steffen Klassert
2023-05-09 9:00 ` Tobias Brunner
2023-05-11 10:04 ` Steffen Klassert
2023-05-08 5:59 ` [PATCH ipsec] xfrm: " Steffen Klassert
2023-05-08 9:03 ` Tobias Brunner
2023-05-09 4:27 ` Steffen Klassert [this message]
2023-05-09 8:59 ` Tobias Brunner
2023-05-11 10:03 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFnLmakCaADGVGV3@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=tobias@strongswan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).