From: Simon Horman <simon.horman@corigine.com>
To: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Marcin Wojtas <mw@semihalf.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH RFC net-next 1/4] net: add helpers for EEE configuration
Date: Fri, 9 Jun 2023 15:52:20 +0200 [thread overview]
Message-ID: <ZIMulJhSQWc7SFEv@corigine.com> (raw)
In-Reply-To: <E1q7Y9M-00DI8a-CV@rmk-PC.armlinux.org.uk>
On Fri, Jun 09, 2023 at 10:11:16AM +0100, Russell King (Oracle) wrote:
> Add helpers that phylib and phylink can use to manage EEE configuration
> and determine whether the MAC should be permitted to use LPI based on
> that configuration.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
> include/net/eee.h | 38 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 include/net/eee.h
>
> diff --git a/include/net/eee.h b/include/net/eee.h
> new file mode 100644
> index 000000000000..d353b79ae79f
> --- /dev/null
> +++ b/include/net/eee.h
> @@ -0,0 +1,38 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +#ifndef _EEE_H
> +#define _EEE_H
> +
> +#include <linux/types.h>
> +
> +struct eee_config {
> + u32 tx_lpi_timer;
> + bool tx_lpi_enabled;
> + bool eee_enabled;
> +};
> +
> +static inline bool eeecfg_mac_can_tx_lpi(const struct eee_config *eeecfg)
> +{
> + /* eee_enabled is the master on/off */
> + if (!eeecfg->eee_enabled || !eeecfg->tx_lpi_enabled)
> + return false;
> +
> + return true;
> +}
> +
> +static inline void eeecfg_to_eee(const struct eee_config *eeecfg,
> + struct ethtool_eee *eee)
Hi Russell,
a minor nit from my side: the indentation of the line above is a bit off.
> +{
> + eee->tx_lpi_timer = eeecfg->tx_lpi_timer;
> + eee->tx_lpi_enabled = eeecfg->tx_lpi_enabled;
> + eee->eee_enabled = eeecfg->eee_enabled;
> +}
> +
> +static inline void eee_to_eeecfg(const struct ethtool_eee *eee,
> + struct eee_config *eeecfg)
> +{
> + eeecfg->tx_lpi_timer = eee->tx_lpi_timer;
> + eeecfg->tx_lpi_enabled = eee->tx_lpi_enabled;
> + eeecfg->eee_enabled = eee->eee_enabled;
> +}
> +
> +#endif
> --
> 2.30.2
>
>
next prev parent reply other threads:[~2023-06-09 13:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 9:11 [PATCH RFC net-next 0/4] phylink EEE support Russell King (Oracle)
2023-06-09 9:11 ` [PATCH RFC net-next 1/4] net: add helpers for EEE configuration Russell King (Oracle)
2023-06-09 13:52 ` Simon Horman [this message]
2023-06-09 9:11 ` [PATCH RFC net-next 2/4] net: phylink: add EEE management Russell King (Oracle)
2023-06-11 21:28 ` Andrew Lunn
2023-06-11 21:37 ` Russell King (Oracle)
2023-06-11 22:25 ` Andrew Lunn
2023-06-13 9:13 ` Russell King (Oracle)
2023-06-13 12:26 ` Andrew Lunn
2023-06-13 14:10 ` Russell King (Oracle)
2023-06-09 9:11 ` [PATCH RFC net-next 3/4] net: mvneta: convert to phylink EEE implementation Russell King (Oracle)
2023-06-09 14:02 ` Simon Horman
2023-06-09 14:31 ` Russell King (Oracle)
2023-06-09 18:25 ` Simon Horman
2023-06-09 9:11 ` [PATCH RFC net-next 4/4] net: mvpp2: add " Russell King (Oracle)
2023-06-09 14:03 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIMulJhSQWc7SFEv@corigine.com \
--to=simon.horman@corigine.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).