From: Andrew Lunn <andrew@lunn.ch>
To: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Marcin Wojtas <mw@semihalf.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH RFC net-next 2/4] net: phylink: add EEE management
Date: Sun, 11 Jun 2023 23:28:32 +0200 [thread overview]
Message-ID: <bca7e7ec-3997-4d97-9803-16bfaf05d1f5@lunn.ch> (raw)
In-Reply-To: <E1q7Y9R-00DI8g-GF@rmk-PC.armlinux.org.uk>
On Fri, Jun 09, 2023 at 10:11:21AM +0100, Russell King (Oracle) wrote:
> Add EEE management to phylink.
Hi Russell
I've been working on my EEE patches. I have all pure phylib drivers
converted. I've incorporated these four patches as well, and make use
of the first patch in phylib.
Looking at this patch, i don't see a way for the MAC to indicate it
actually does support EEE. Am i missing it?
What i proposed last time is to add another bit to
pl->config->mac_capabilities. Does that work for you?
Do you have time to respin these patches to address the comments? It
is probably easier for my series to wait until these are merged.
Andrew
next prev parent reply other threads:[~2023-06-11 21:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 9:11 [PATCH RFC net-next 0/4] phylink EEE support Russell King (Oracle)
2023-06-09 9:11 ` [PATCH RFC net-next 1/4] net: add helpers for EEE configuration Russell King (Oracle)
2023-06-09 13:52 ` Simon Horman
2023-06-09 9:11 ` [PATCH RFC net-next 2/4] net: phylink: add EEE management Russell King (Oracle)
2023-06-11 21:28 ` Andrew Lunn [this message]
2023-06-11 21:37 ` Russell King (Oracle)
2023-06-11 22:25 ` Andrew Lunn
2023-06-13 9:13 ` Russell King (Oracle)
2023-06-13 12:26 ` Andrew Lunn
2023-06-13 14:10 ` Russell King (Oracle)
2023-06-09 9:11 ` [PATCH RFC net-next 3/4] net: mvneta: convert to phylink EEE implementation Russell King (Oracle)
2023-06-09 14:02 ` Simon Horman
2023-06-09 14:31 ` Russell King (Oracle)
2023-06-09 18:25 ` Simon Horman
2023-06-09 9:11 ` [PATCH RFC net-next 4/4] net: mvpp2: add " Russell King (Oracle)
2023-06-09 14:03 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bca7e7ec-3997-4d97-9803-16bfaf05d1f5@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).