From: Jose Abreu <jose.abreu@synopsys.com>
To: Simon Huelck <simonmail@gmx.de>,
Jose Abreu <jose.abreu@synopsys.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Emiliano Ingrassia <ingrassia@epigenesys.com>,
<Gpeppe.cavallaro@st.com>, <alexandre.torgue@st.com>,
<linux-amlogic@lists.infradead.org>, <netdev@vger.kernel.org>
Subject: Re: stmmac / meson8b-dwmac
Date: Mon, 18 Feb 2019 17:05:57 +0000 [thread overview]
Message-ID: <adafe6d7-e619-45e9-7ecb-76f003b0c7d9@synopsys.com> (raw)
In-Reply-To: <4493b245-de93-46cd-327b-8091a3babc3a@gmx.de>
On 2/18/2019 4:51 PM, Simon Huelck wrote:
> Hi,
>
> no im testing vanilla mainline kernel and against 4.14. where
> performance was ok. but turning off EEE via ethtool should have same
> results than removal of that patch.
>
> But, since it was mainlined recently , not long ago, i think this was
> tested ??
The thing is that phy_init_eee() is called by stmmac and this
function does not take into account the broken modes if it's
called too early which will cause driver to enable LPI in MAC.
And anyway, if you have lpi values in the ethtool stats then EEE
is being enabled by stmmac.
Please try the change I suggested.
Thanks,
Jose Miguel Abreu
next prev parent reply other threads:[~2019-02-18 17:06 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a38e643c-ed9f-c306-cc95-84f70ebc1f10@gmx.de>
[not found] ` <CAFBinCDebPOsmrhSXecx48nGWHh7g_OGPbr1Y0M+n_v9Ht91ew@mail.gmail.com>
2019-01-17 21:23 ` stmmac / meson8b-dwmac Simon Huelck
2019-02-04 14:34 ` Martin Blumenstingl
2019-02-06 10:36 ` Emiliano Ingrassia
2019-02-06 18:04 ` Simon Huelck
2019-02-06 21:21 ` Simon Huelck
2019-02-07 19:30 ` Simon Huelck
2019-02-09 1:09 ` Martin Blumenstingl
2019-02-11 13:44 ` Jose Abreu
2019-02-14 7:21 ` Simon Huelck
2019-02-17 14:48 ` Martin Blumenstingl
2019-02-17 19:13 ` Simon Huelck
2019-02-18 8:42 ` Jose Abreu
2019-02-18 8:45 ` Jose Abreu
2019-02-18 12:33 ` Simon Huelck
2019-02-18 12:41 ` Jose Abreu
2019-02-18 13:02 ` Jose Abreu
2019-02-18 15:29 ` Simon Huelck
2019-02-18 15:31 ` Jose Abreu
2019-02-18 15:53 ` Simon Huelck
2019-02-18 16:26 ` Jose Abreu
2019-02-18 16:40 ` Simon Huelck
2019-02-18 16:43 ` Jose Abreu
2019-02-18 16:51 ` Simon Huelck
2019-02-18 17:05 ` Jose Abreu [this message]
2019-02-18 18:05 ` Simon Huelck
2019-02-19 8:47 ` Jose Abreu
2019-02-19 19:41 ` Simon Huelck
2019-02-21 14:21 ` Jerome Brunet
2019-02-21 17:27 ` Simon Huelck
2019-02-21 17:46 ` Jerome Brunet
2019-02-21 19:34 ` Simon Huelck
2019-02-22 17:21 ` Anand Moon
2019-02-24 15:00 ` Simon Huelck
2019-02-24 15:02 ` Simon Huelck
2019-02-24 19:42 ` Sebastian Gottschall
2019-02-24 20:34 ` Simon Huelck
2019-02-27 11:09 ` Jose Abreu
2019-02-27 19:02 ` Simon Huelck
2019-03-01 9:23 ` Jose Abreu
2019-03-05 9:55 ` Simon Huelck
2019-03-06 11:35 ` Simon Huelck
2019-03-06 11:45 ` Simon Huelck
2019-05-11 14:53 ` Simon Huelck
2019-05-13 9:07 ` Jose Abreu
2019-05-22 12:48 ` Simon Huelck
2019-05-22 14:02 ` Neil Armstrong
2019-02-27 21:03 ` Simon Huelck
2019-02-18 17:05 ` Simon Huelck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adafe6d7-e619-45e9-7ecb-76f003b0c7d9@synopsys.com \
--to=jose.abreu@synopsys.com \
--cc=Gpeppe.cavallaro@st.com \
--cc=alexandre.torgue@st.com \
--cc=ingrassia@epigenesys.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=netdev@vger.kernel.org \
--cc=simonmail@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).