netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] wifi: brcmfmac: remove unused niclist structure
@ 2024-04-28 13:17 Christophe JAILLET
  2024-04-29 13:39 ` Simon Horman
  0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2024-04-28 13:17 UTC (permalink / raw)
  To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: linux-kernel, kernel-janitors, Christophe JAILLET, netdev

struct niclist was added in the initial commit f21fb3ed364b ("Add support
of Cavium Liquidio ethernet adapters").

Apparently it was never used.

So, remove the structure definition now. This saves a few lines of code.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only
---
 drivers/net/ethernet/cavium/liquidio/octeon_droq.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_droq.c b/drivers/net/ethernet/cavium/liquidio/octeon_droq.c
index 0d6ee30affb9..eef12fdd246d 100644
--- a/drivers/net/ethernet/cavium/liquidio/octeon_droq.c
+++ b/drivers/net/ethernet/cavium/liquidio/octeon_droq.c
@@ -30,11 +30,6 @@
 #include "cn23xx_pf_device.h"
 #include "cn23xx_vf_device.h"
 
-struct niclist {
-	struct list_head list;
-	void *ptr;
-};
-
 struct __dispatch {
 	struct list_head list;
 	struct octeon_recv_info *rinfo;
-- 
2.44.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] wifi: brcmfmac: remove unused niclist structure
  2024-04-28 13:17 [PATCH] wifi: brcmfmac: remove unused niclist structure Christophe JAILLET
@ 2024-04-29 13:39 ` Simon Horman
  0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2024-04-29 13:39 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	linux-kernel, kernel-janitors, netdev

On Sun, Apr 28, 2024 at 03:17:04PM +0200, Christophe JAILLET wrote:
> struct niclist was added in the initial commit f21fb3ed364b ("Add support
> of Cavium Liquidio ethernet adapters").
> 
> Apparently it was never used.
> 
> So, remove the structure definition now. This saves a few lines of code.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only

Reviewed-by: Simon Horman <horms@kernel.org>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-04-29 13:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-28 13:17 [PATCH] wifi: brcmfmac: remove unused niclist structure Christophe JAILLET
2024-04-29 13:39 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).