From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Vincent Prince <vincent.prince.fr@gmail.com>
Cc: jiri@resnulli.us, jhs@mojatatu.com, netdev@vger.kernel.org,
dave.taht@gmail.com, linux-can@vger.kernel.org,
kernel@pengutronix.de, xiyou.wangcong@gmail.com,
davem@davemloft.net
Subject: Re: [PATCH] net: sch_generic: Use pfifo_fast as fallback scheduler for CAN hardware
Date: Tue, 22 Oct 2019 14:58:33 +0200 [thread overview]
Message-ID: <d6902a1c-af8f-7d47-4f9b-d037c6be70d5@pengutronix.de> (raw)
In-Reply-To: <1571748448-11190-1-git-send-email-vincent.prince.fr@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1095 bytes --]
On 10/22/19 2:47 PM, Vincent Prince wrote:
> Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
Please add the patch description, preferred that one from my original patch.
> ---
> net/sched/sch_generic.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
> index 77b289d..bff43de 100644
> --- a/net/sched/sch_generic.c
> +++ b/net/sched/sch_generic.c
> @@ -1008,6 +1008,8 @@ static void attach_one_default_qdisc(struct net_device *dev,
>
> if (dev->priv_flags & IFF_NO_QUEUE)
> ops = &noqueue_qdisc_ops;
> + else if(dev->type == ARPHRD_CAN)
^^^^^^^^^^^^^^^
use one tab to indent.
> + ops = &pfifo_fast_ops;
>
> qdisc = qdisc_create_dflt(dev_queue, ops, TC_H_ROOT, NULL);
> if (!qdisc) {
>
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-10-22 12:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 16:56 [RFC] net: sch_generic: fq_codel vs pfifo_fast Marc Kleine-Budde
2019-03-27 16:56 ` [PATCH 1/2] net: sch_generic: add flag IFF_FIFO_QUEUE to use pfifo_fast as default scheduler Marc Kleine-Budde
2019-03-27 17:14 ` Cong Wang
2019-03-27 20:11 ` Marc Kleine-Budde
2019-03-27 20:53 ` Cong Wang
2019-04-02 17:22 ` Toke Høiland-Jørgensen
2019-03-27 18:53 ` Uwe Kleine-König
2019-03-27 19:27 ` Marc Kleine-Budde
2019-03-27 16:56 ` [PATCH 2/2] can: dev: let all CAN devices " Marc Kleine-Budde
2019-03-27 18:30 ` [RFC] net: sch_generic: fq_codel vs pfifo_fast Stephen Hemminger
2019-03-27 19:24 ` Marc Kleine-Budde
2019-10-22 12:47 ` [PATCH] net: sch_generic: Use pfifo_fast as fallback scheduler for CAN hardware Vincent Prince
2019-10-22 12:58 ` Marc Kleine-Budde [this message]
2019-10-22 13:23 ` [PATCH v2] " Vincent Prince
2019-10-22 14:53 ` Marc Kleine-Budde
2019-10-22 14:55 ` Marc Kleine-Budde
2019-10-22 16:42 ` Stephen Hemminger
2019-10-22 16:48 ` Marc Kleine-Budde
2019-10-22 17:28 ` Eric Dumazet
2019-10-22 18:21 ` Oliver Hartkopp
2019-10-22 15:09 ` [PATCH v3] " Vincent Prince
2019-10-23 10:52 ` [PATCH v4] " Vincent Prince
2019-10-23 11:13 ` Dave Taht
2019-10-23 13:44 ` [PATCH v5] " Vincent Prince
2019-10-26 2:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6902a1c-af8f-7d47-4f9b-d037c6be70d5@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vincent.prince.fr@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).