* [PATCH net-next] net: phy: Add more 1000BaseX support detection
@ 2019-06-11 22:06 Robert Hancock
2019-06-11 22:55 ` Florian Fainelli
2019-06-15 1:47 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Robert Hancock @ 2019-06-11 22:06 UTC (permalink / raw)
To: netdev; +Cc: andrew, f.fainelli, hkallweit1, Robert Hancock
Commit "net: phy: Add detection of 1000BaseX link mode support" added
support for not filtering out 1000BaseX mode from the PHY's supported
modes in genphy_config_init, but we have to make a similar change in
genphy_read_abilities in order to actually detect it as a supported mode
in the first place. Add this in.
Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
---
drivers/net/phy/phy_device.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 03c885e..5387890 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -1984,6 +1984,8 @@ int genphy_read_abilities(struct phy_device *phydev)
phydev->supported, val & ESTATUS_1000_TFULL);
linkmode_mod_bit(ETHTOOL_LINK_MODE_1000baseT_Half_BIT,
phydev->supported, val & ESTATUS_1000_THALF);
+ linkmode_mod_bit(ETHTOOL_LINK_MODE_1000baseX_Full_BIT,
+ phydev->supported, val & ESTATUS_1000_XFULL);
}
return 0;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: Add more 1000BaseX support detection
2019-06-11 22:06 [PATCH net-next] net: phy: Add more 1000BaseX support detection Robert Hancock
@ 2019-06-11 22:55 ` Florian Fainelli
2019-06-15 1:47 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2019-06-11 22:55 UTC (permalink / raw)
To: Robert Hancock, netdev; +Cc: andrew, hkallweit1
On 6/11/19 3:06 PM, Robert Hancock wrote:
> Commit "net: phy: Add detection of 1000BaseX link mode support" added
> support for not filtering out 1000BaseX mode from the PHY's supported
> modes in genphy_config_init, but we have to make a similar change in
> genphy_read_abilities in order to actually detect it as a supported mode
> in the first place. Add this in.
>
> Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: Add more 1000BaseX support detection
2019-06-11 22:06 [PATCH net-next] net: phy: Add more 1000BaseX support detection Robert Hancock
2019-06-11 22:55 ` Florian Fainelli
@ 2019-06-15 1:47 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-06-15 1:47 UTC (permalink / raw)
To: hancock; +Cc: netdev, andrew, f.fainelli, hkallweit1
From: Robert Hancock <hancock@sedsystems.ca>
Date: Tue, 11 Jun 2019 16:06:09 -0600
> Commit "net: phy: Add detection of 1000BaseX link mode support" added
> support for not filtering out 1000BaseX mode from the PHY's supported
> modes in genphy_config_init, but we have to make a similar change in
> genphy_read_abilities in order to actually detect it as a supported mode
> in the first place. Add this in.
>
> Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-15 1:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-11 22:06 [PATCH net-next] net: phy: Add more 1000BaseX support detection Robert Hancock
2019-06-11 22:55 ` Florian Fainelli
2019-06-15 1:47 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).