* [PATCH net-next] netfilter: nft_redir: Make nft_redir_dump static
@ 2019-03-19 14:40 Yue Haibing
2019-04-08 21:22 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Yue Haibing @ 2019-03-19 14:40 UTC (permalink / raw)
To: davem, pablo, kadlec, fw
Cc: linux-kernel, netdev, coreteam, netfilter-devel, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
net/netfilter/nft_redir.c:85:5:
warning: symbol 'nft_redir_dump' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/netfilter/nft_redir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nft_redir.c b/net/netfilter/nft_redir.c
index a340cd8..02f4b4a 100644
--- a/net/netfilter/nft_redir.c
+++ b/net/netfilter/nft_redir.c
@@ -82,7 +82,7 @@ static int nft_redir_init(const struct nft_ctx *ctx,
return nf_ct_netns_get(ctx->net, ctx->family);
}
-int nft_redir_dump(struct sk_buff *skb, const struct nft_expr *expr)
+static int nft_redir_dump(struct sk_buff *skb, const struct nft_expr *expr)
{
const struct nft_redir *priv = nft_expr_priv(expr);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] netfilter: nft_redir: Make nft_redir_dump static
2019-03-19 14:40 [PATCH net-next] netfilter: nft_redir: Make nft_redir_dump static Yue Haibing
@ 2019-04-08 21:22 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2019-04-08 21:22 UTC (permalink / raw)
To: Yue Haibing
Cc: davem, kadlec, fw, linux-kernel, netdev, coreteam, netfilter-devel
On Tue, Mar 19, 2019 at 10:40:21PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> net/netfilter/nft_redir.c:85:5:
> warning: symbol 'nft_redir_dump' was not declared. Should it be static?
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-08 21:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 14:40 [PATCH net-next] netfilter: nft_redir: Make nft_redir_dump static Yue Haibing
2019-04-08 21:22 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).