xtables-addons akmods Builds Failing on Linux Kernel 5.3.6 - Log Sample - xt_DHCPMAC.c

xtables-addons akmods Builds Failing on Linux Kernel 5.3.6 - Log Sample - xt_DHCPMAC.c

[Matt Olson]

While troubleshooting why the xtables-addon module would not build, I 
ran across a specific build error that I thought may be useful for the 
maintainer.  The error appears to be

# akmods --kernels 5.3.6-200.fc30.x86_64

Log from 
/var/cache/akmods/xtables-addons/3.3-3-for-5.3.6-200.fc30.x86_64.failed.log:

2019/10/19 16:08:43 akmodsbuild: gcc 
-Wp,-MD,/tmp/akmodsbuild.A7wQddef/BUILD/xtables-addons-kmod-3.3/_kmod_build_5.3.6-200.fc30.x86_64/extensions/.xt_DHCPMAC.o.d 
-nostdinc -isystem /usr/lib/gcc/x86_64-redhat-linux/9/include 
-I./arch/x86/include -I./arch/x86/include/generated  -I./include 
-I./arch/x86/include/uapi -I./arch/x86/include/generated/uapi 
-I./include/uapi -I./include/generated/uapi -include 
./include/linux/kconfig.h -include ./include/linux/compiler_types.h 
-D__KERNEL__ -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs 
-fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE 
-Werror=implicit-function-declaration -Werror=implicit-int 
-Wno-format-security -Wno-address-of-packed-member -std=gnu89 -mno-sse 
-mno-mmx -mno-sse2 -mno-3dnow -mno-avx -m64 -falign-jumps=1 
-falign-loops=1 -mno-80387 -mno-fp-ret-in-387 
-mpreferred-stack-boundary=3 -mskip-rax-setup -mtune=generic 
-mno-red-zone -mcmodel=kernel -DCONFIG_AS_CFI=1 
-DCONFIG_AS_CFI_SIGNAL_FRAME=1 -DCONFIG_AS_CFI_SECTIONS=1 
-DCONFIG_AS_SSSE3=1 -DCONFIG_AS_AVX=1 -DCONFIG_AS_AVX2=1 
-DCONFIG_AS_AVX512=1 -DCONFIG_AS_SHA1_NI=1 -DCONFIG_AS_SHA256_NI=1 
-Wno-sign-compare -fno-asynchronous-unwind-tables 
-mindirect-branch=thunk-extern -mindirect-branch-register 
-fno-jump-tables -fno-delete-null-pointer-checks -Wno-frame-address 
-Wno-format-truncation -Wno-format-overflow 
-Wno-address-of-packed-member -O2 --param=allow-store-data-races=0 
-Wframe-larger-than=2048 -fstack-protector-strong 
-Wno-unused-but-set-variable -Wimplicit-fallthrough 
-Wno-unused-const-variable -fvar-tracking-assignments -g -pg 
-mrecord-mcount -mfentry -DCC_USING_FENTRY -Wdeclaration-after-statement 
-Wvla -Wno-pointer-sign -Wno-stringop-truncation -fno-strict-overflow 
-fno-merge-all-constants -fmerge-constants -fno-stack-check 
-fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types 
-Werror=designated-init -fmacro-prefix-map=./= -fcf-protection=none 
-Wno-packed-not-aligned  -DMODULE -DKBUILD_BASENAME='"xt_DHCPMAC"' 
-DKBUILD_MODNAME='"xt_DHCPMAC"' -c -o 
/tmp/akmodsbuild.A7wQddef/BUILD/xtables-addons-kmod-3.3/_kmod_build_5.3.6-200.fc30.x86_64/extensions/xt_DHCPMAC.o 
/tmp/akmodsbuild.A7wQddef/BUILD/xtables-addons-kmod-3.3/_kmod_build_5.3.6-200.fc30.x86_64/extensions/xt_DHCPMAC.c
2019/10/19 16:08:43 akmodsbuild: 
/tmp/akmodsbuild.A7wQddef/BUILD/xtables-addons-kmod-3.3/_kmod_build_5.3.6-200.fc30.x86_64/extensions/xt_DHCPMAC.c: 
In function 'dhcpmac_tg':
2019/10/19 16:08:43 akmodsbuild: 
/tmp/akmodsbuild.A7wQddef/BUILD/xtables-addons-kmod-3.3/_kmod_build_5.3.6-200.fc30.x86_64/extensions/xt_DHCPMAC.c:99:7: 
error: implicit declaration of function 'skb_make_writable'; did you 
mean 'skb_try_make_writable'? [-Werror=implicit-function-declaration]
2019/10/19 16:08:43 akmodsbuild: 99 |  if (!skb_make_writable(skb, 0))
2019/10/19 16:08:43 akmodsbuild: |       ^~~~~~~~~~~~~~~~~
2019/10/19 16:08:43 akmodsbuild: |       skb_try_make_writable
2019/10/19 16:08:43 akmodsbuild: cc1: some warnings being treated as errors
2019/10/19 16:08:43 akmodsbuild: make[1]: *** 
[scripts/Makefile.build:281: 
/tmp/akmodsbuild.A7wQddef/BUILD/xtables-addons-kmod-3.3/_kmod_build_5.3.6-200.fc30.x86_64/extensions/xt_DHCPMAC.o] 
Error 1
2019/10/19 16:08:43 akmodsbuild: make[1]: *** Waiting for unfinished 
jobs....
2019/10/19 16:08:43 akmodsbuild: ./tools/objtool/objtool orc generate  
--module --no-fp --retpoline --uaccess 
/tmp/akmodsbuild.A7wQddef/BUILD/xtables-addons-kmod-3.3/_kmod_build_5.3.6-200.fc30.x86_64/extensions/xt_DELUDE.o
2019/10/19 16:08:43 akmodsbuild: make: *** [Makefile:1630: 
_module_/tmp/akmodsbuild.A7wQddef/BUILD/xtables-addons-kmod-3.3/_kmod_build_5.3.6-200.fc30.x86_64/extensions] 
Error 2
2019/10/19 16:08:43 akmodsbuild: make: Leaving directory 
'/usr/src/kernels/5.3.6-200.fc30.x86_64'
2019/10/19 16:08:43 akmodsbuild: error: Bad exit status from 
/var/tmp/rpm-tmp.VEFn5t (%build)
2019/10/19 16:08:43 akmodsbuild:
2019/10/19 16:08:43 akmodsbuild:
2019/10/19 16:08:43 akmodsbuild: RPM build errors:
2019/10/19 16:08:43 akmodsbuild: user mockbuild does not exist - using root
2019/10/19 16:08:43 akmodsbuild: group mock does not exist - using root
2019/10/19 16:08:43 akmodsbuild: user mockbuild does not exist - using root
2019/10/19 16:08:43 akmodsbuild: group mock does not exist - using root
2019/10/19 16:08:43 akmodsbuild: user mockbuild does not exist - using root
2019/10/19 16:08:43 akmodsbuild: group mock does not exist - using root
2019/10/19 16:08:43 akmodsbuild: Bad exit status from 
/var/tmp/rpm-tmp.VEFn5t (%build)
2019/10/19 16:08:43 akmodsbuild:
2019/10/19 16:08:43 akmods: Building rpms failed; see 
/var/cache/akmods/xtables-addons/3.3-3-for-5.3.6-200.fc30.x86_64.failed.log 
for details

This also fails on 5.3.5.

Matt

Re: xtables-addons akmods Builds Failing on Linux Kernel 5.3.6 - Log Sample - xt_DHCPMAC.c

[Jeremy Sowden]

[-- Attachment #1: Type: text/plain, Size: 916 bytes --]

On 2019-10-19, at 16:43:50 -0700, Matt Olson wrote:
> While troubleshooting why the xtables-addon module would not build, I
> ran across a specific build error that I thought may be useful for the
> maintainer.  The error appears to be
>
> [...]
> 2019/10/19 16:08:43 akmodsbuild: /tmp/akmodsbuild.A7wQddef/BUILD/xtables-addons-kmod-3.3/_kmod_build_5.3.6-200.fc30.x86_64/extensions/xt_DHCPMAC.c:99:7:
> error: implicit declaration of function 'skb_make_writable'; did you
> mean 'skb_try_make_writable'? [-Werror=implicit-function-declaration]
> 2019/10/19 16:08:43 akmodsbuild: 99 |  if (!skb_make_writable(skb, 0))
> 2019/10/19 16:08:43 akmodsbuild: |       ^~~~~~~~~~~~~~~~~
> 2019/10/19 16:08:43 akmodsbuild: |       skb_try_make_writable
> [...]

This was fixed in 3.4:

  https://sourceforge.net/p/xtables-addons/xtables-addons/ci/b14728691d73fc907839c04b9dff7e2595498546/

J.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]