From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: [nft PATCH 0/4] Two bugfixes around prefixes in sets
Date: Thu, 30 Apr 2020 17:14:04 +0200 [thread overview]
Message-ID: <20200430151408.32283-1-phil@nwl.cc> (raw)
Patch 1 fixes a pretty obvious typo, leading to prefixes not showing
their expiry time.
The remaining patches deal with wrong behaviour of 'get element' command
when looking up prefixes. This could have been simple, 'get element'
would return the prefix address but prefix length was missing.
While digging through the code, I eventually found out that
get_set_interval_find() and get_set_interval_end() didn't respect prefix
elements but cared about range elements only.
I am still not entirely sure how the code really works and why
everything is needed, but the test case added in patch 4 and some debug
output showed that things could be simplified quite a bit. Since this
also streamlined adding prefix support, I went ahead with it.
Phil Sutter (4):
segtree: Fix missing expires value in prefixes
segtree: Use expr_clone in get_set_interval_*()
segtree: Merge get_set_interval_find() and get_set_interval_end()
segtree: Fix get element command with prefixes
src/segtree.c | 70 +++++---------------
tests/shell/testcases/sets/0034get_element_0 | 51 +++++++++-----
2 files changed, 51 insertions(+), 70 deletions(-)
--
2.25.1
next reply other threads:[~2020-04-30 15:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 15:14 Phil Sutter [this message]
2020-04-30 15:14 ` [nft PATCH 1/4] segtree: Fix missing expires value in prefixes Phil Sutter
2020-04-30 15:14 ` [nft PATCH 2/4] segtree: Use expr_clone in get_set_interval_*() Phil Sutter
2020-04-30 15:14 ` [nft PATCH 3/4] segtree: Merge get_set_interval_find() and get_set_interval_end() Phil Sutter
2020-04-30 15:37 ` Pablo Neira Ayuso
2020-04-30 15:41 ` Pablo Neira Ayuso
2020-05-04 12:53 ` Phil Sutter
2020-04-30 15:48 ` Phil Sutter
2020-04-30 15:52 ` Pablo Neira Ayuso
2020-04-30 16:01 ` Phil Sutter
2020-05-01 11:05 ` Pablo Neira Ayuso
2020-04-30 15:14 ` [nft PATCH 4/4] segtree: Fix get element command with prefixes Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430151408.32283-1-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).