From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH 3/4] segtree: Merge get_set_interval_find() and get_set_interval_end()
Date: Thu, 30 Apr 2020 17:48:42 +0200 [thread overview]
Message-ID: <20200430154841.GP15009@orbyte.nwl.cc> (raw)
In-Reply-To: <20200430153729.GA3602@salvia>
On Thu, Apr 30, 2020 at 05:37:29PM +0200, Pablo Neira Ayuso wrote:
> On Thu, Apr 30, 2020 at 05:14:07PM +0200, Phil Sutter wrote:
> > Both functions were very similar already. Under the assumption that they
> > will always either see a range (or start of) that matches exactly or not
> > at all, reduce complexity and make get_set_interval_find() accept NULL
> > (left or) right values. This way it becomes a full replacement for
> > get_set_interval_end().
>
> I have to go back to the commit log of this patch, IIRC my intention
> here was to allow users to ask for a single element, then return the
> range that contains it.
That was my suspicion as well, but while testing I found out that no
matter what I passed to 'get element', I couldn't provoke a situation in
which get_set_interval_find() would have left and right elements which
didn't match exactly (or not at all).
There must be some preparation happening before the call to
get_set_decompose() which normalizes things. And still, If I disable the
call to get_set_decompose() entirely, tests start failing.
Cheers, Phil
next prev parent reply other threads:[~2020-04-30 15:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 15:14 [nft PATCH 0/4] Two bugfixes around prefixes in sets Phil Sutter
2020-04-30 15:14 ` [nft PATCH 1/4] segtree: Fix missing expires value in prefixes Phil Sutter
2020-04-30 15:14 ` [nft PATCH 2/4] segtree: Use expr_clone in get_set_interval_*() Phil Sutter
2020-04-30 15:14 ` [nft PATCH 3/4] segtree: Merge get_set_interval_find() and get_set_interval_end() Phil Sutter
2020-04-30 15:37 ` Pablo Neira Ayuso
2020-04-30 15:41 ` Pablo Neira Ayuso
2020-05-04 12:53 ` Phil Sutter
2020-04-30 15:48 ` Phil Sutter [this message]
2020-04-30 15:52 ` Pablo Neira Ayuso
2020-04-30 16:01 ` Phil Sutter
2020-05-01 11:05 ` Pablo Neira Ayuso
2020-04-30 15:14 ` [nft PATCH 4/4] segtree: Fix get element command with prefixes Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430154841.GP15009@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).