From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Edward Cree <ecree@solarflare.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, jiri@resnulli.us,
kuba@kernel.org
Subject: Re: [PATCH net-next v2] net: flow_offload: simplify hw stats check handling
Date: Tue, 19 May 2020 19:35:08 +0200 [thread overview]
Message-ID: <20200519173508.GA17141@salvia> (raw)
In-Reply-To: <6013b7ce-48c9-7169-c945-01b2226638e4@solarflare.com>
On Tue, May 19, 2020 at 06:23:35PM +0100, Edward Cree wrote:
> On 19/05/2020 18:19, Pablo Neira Ayuso wrote:
> > This is breaking netfilter again.
>
> Still waiting for you to explain what this "breaks". AFAICT the
> new DONT_CARE has exactly the same effect that the old DONT_CARE
> did, so as long as netfilter is using DONT_CARE rather than (say)
> a hard-coded 0, it should be fine.
Did you test your patch with netfilter? I don't think.
Netfilter is a client of this flow offload API, you have to test that
your core updates do not break any of existing clients.
Please, do not make me think this is intentional.
I am pretty sure your motivation is to help get things better.
next prev parent reply other threads:[~2020-05-19 17:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 17:02 [PATCH net-next v2] net: flow_offload: simplify hw stats check handling Edward Cree
2020-05-19 17:19 ` Pablo Neira Ayuso
2020-05-19 17:23 ` Edward Cree
2020-05-19 17:35 ` Pablo Neira Ayuso [this message]
2020-05-19 18:26 ` Edward Cree
2020-05-20 14:33 ` Pablo Neira Ayuso
2020-05-20 15:18 ` Edward Cree
2020-05-19 19:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519173508.GA17141@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).