From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Edward Cree <ecree@solarflare.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, jiri@resnulli.us,
kuba@kernel.org
Subject: Re: [PATCH net-next v2] net: flow_offload: simplify hw stats check handling
Date: Wed, 20 May 2020 16:33:30 +0200 [thread overview]
Message-ID: <20200520143330.GA23050@salvia> (raw)
In-Reply-To: <dc732572-6f69-6cbe-5df1-ca4d6e6ed131@solarflare.com>
On Tue, May 19, 2020 at 07:26:42PM +0100, Edward Cree wrote:
> On 19/05/2020 18:35, Pablo Neira Ayuso wrote:
[...]
> > Netfilter is a client of this flow offload API, you have to test that
> > your core updates do not break any of existing clients.
>
> Okay, but can we distinguish between "this needs to be tested with
> netfilter before it can be merged" and "this is breaking netfilter"?
> Or do you have a specific reason why you think this is broken, beyond
> merely 'it isn't tested'?
This breaks netfilter in two ways !
#1 Drivers calling flow_action_hw_stats_check() fall within the
second branch (check_allow_bit is set on).
} else if (check_allow_bit &&
@@ -340,11 +342,9 @@ __flow_action_hw_stats_check(const struct flow_action *action,
return false;
action_entry = flow_action_first_entry_get(action);
- if (action_entry->hw_stats == FLOW_ACTION_HW_STATS_DONT_CARE)
- return true;
if (!check_allow_bit &&
- action_entry->hw_stats != FLOW_ACTION_HW_STATS_ANY) {
+ ~action_entry->hw_stats & FLOW_ACTION_HW_STATS_ANY) {
NL_SET_ERR_MSG_MOD(extack, "Driver supports only default HW stats type \"any\"");
return false;
} else if (check_allow_bit && <------ HERE
These drivers are not honoring the _DONT_CARE bit,
__flow_action_hw_stats_check() with check_allow_bit set on does not
honor the _DONT_CARE bit.
#2 Your patch needs to update Netfilter to set hw_stats to
FLOW_ACTION_HW_STATS_DONT_CARE explicitly.
next prev parent reply other threads:[~2020-05-20 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 17:02 [PATCH net-next v2] net: flow_offload: simplify hw stats check handling Edward Cree
2020-05-19 17:19 ` Pablo Neira Ayuso
2020-05-19 17:23 ` Edward Cree
2020-05-19 17:35 ` Pablo Neira Ayuso
2020-05-19 18:26 ` Edward Cree
2020-05-20 14:33 ` Pablo Neira Ayuso [this message]
2020-05-20 15:18 ` Edward Cree
2020-05-19 19:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520143330.GA23050@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).