From: Kevin 'ldir' Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
To: "netfilter-devel@vger.kernel.org" <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH 1/1] netfilter: connmark: introduce set-dscpmark
Date: Mon, 9 Dec 2019 23:57:05 +0000 [thread overview]
Message-ID: <960F6D75-489D-41E7-AEF7-58D4013F9CFD@darbyshire-bryant.me.uk> (raw)
In-Reply-To: <20191203160652.44396-2-ldir@darbyshire-bryant.me.uk>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
> On 3 Dec 2019, at 16:06, Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk> wrote:
>
> set-dscpmark is a method of storing the DSCP of an ip packet into
> conntrack mark. In combination with a suitable tc filter action
> (act_ctinfo) DSCP values are able to be stored in the mark on egress and
> restored on ingress across links that otherwise alter or bleach DSCP.
>
<snip>
Well no one has yet screamed. I do think I’ve done this wrong:
>
> +enum {
> + XT_CONNMARK_VALUE = BIT(0),
> + XT_CONNMARK_DSCP = BIT(1)
> +};
and they should be = (1 << bit_number) instead.
I’ll send a v2 with that change (to nf-next) but anything else? or is it all too horrid
to contemplate :-)
Cheers,
Kevin
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-12-09 23:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 14:23 [RFC PATCH 0/1] netfilter: xt_connmark: add savedscp-mark action Kevin 'ldir' Darbyshire-Bryant
2019-03-24 14:23 ` [PATCH 1/1] netfilter: connmark: introduce savedscp Kevin 'ldir' Darbyshire-Bryant
2019-04-08 22:39 ` Pablo Neira Ayuso
2019-04-08 23:16 ` Kevin 'ldir' Darbyshire-Bryant
2019-04-09 14:23 ` [RFC nf-next v2 0/2] xt_connmark: add savedscp-mark action Kevin 'ldir' Darbyshire-Bryant
2019-04-09 14:23 ` [RFC nf-next v2 1/2] netfilter: connmark: introduce savedscp Kevin 'ldir' Darbyshire-Bryant
2019-04-30 12:29 ` Pablo Neira Ayuso
2019-04-30 20:40 ` Kevin 'ldir' Darbyshire-Bryant
2019-04-09 14:23 ` [RFC nf-next 2/2] iptables: connmark - add savedscp option Kevin 'ldir' Darbyshire-Bryant
2019-12-03 16:06 ` [PATCH 0/1] netfilter: connmark: introduce set-dscpmark Kevin Darbyshire-Bryant
2019-12-03 16:06 ` [PATCH 1/1] " Kevin Darbyshire-Bryant
2019-12-09 23:57 ` Kevin 'ldir' Darbyshire-Bryant [this message]
2019-12-05 8:56 ` [PATCH 0/1] " Jeremy Sowden
2019-12-05 9:46 ` Kevin 'ldir' Darbyshire-Bryant
2019-12-06 8:54 ` Jeremy Sowden
2019-12-05 10:49 ` Florian Westphal
2019-12-05 22:00 ` Jeremy Sowden
2019-12-09 21:42 ` [RFC PATCH nf-next] netfilter: conntrack: add support for storing DiffServ code-point as CT mark Jeremy Sowden
2019-12-09 21:42 ` [RFC PATCH nftables] Add "ct dscpmark" conntrack statement Jeremy Sowden
2019-12-09 22:47 ` [RFC PATCH nf-next] netfilter: conntrack: add support for storing DiffServ code-point as CT mark Florian Westphal
2019-12-09 23:23 ` Jeremy Sowden
2019-12-10 1:25 ` Florian Westphal
2019-12-10 11:01 ` Jeremy Sowden
2019-12-10 11:32 ` Florian Westphal
2019-12-10 19:52 ` Jeremy Sowden
2019-12-11 13:01 ` [PATCH nf-next v2] netfilter: connmark: introduce set-dscpmark Kevin Darbyshire-Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=960F6D75-489D-41E7-AEF7-58D4013F9CFD@darbyshire-bryant.me.uk \
--to=ldir@darbyshire-bryant.me.uk \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).