* [PATCH nf 1/3] netfilter: nft_dup: validate family and chains
@ 2022-08-21 15:53 Pablo Neira Ayuso
2022-08-21 15:54 ` [PATCH nf 2/3] netfilter: nft_osf: restrict osf to ipv4, ipv6 and inet families Pablo Neira Ayuso
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2022-08-21 15:53 UTC (permalink / raw)
To: netfilter-devel
This only supports for netdev family and ingress and egress hooks.
Fixes: 502061f81d3e ("netfilter: nf_tables: add packet duplication to the netdev family")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
net/netfilter/nft_dup_netdev.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/net/netfilter/nft_dup_netdev.c b/net/netfilter/nft_dup_netdev.c
index 63507402716d..1d5bbe8d2660 100644
--- a/net/netfilter/nft_dup_netdev.c
+++ b/net/netfilter/nft_dup_netdev.c
@@ -44,6 +44,14 @@ static int nft_dup_netdev_init(const struct nft_ctx *ctx,
sizeof(int));
}
+static int nft_dup_netdev_validate(const struct nft_ctx *ctx,
+ const struct nft_expr *expr,
+ const struct nft_data **data)
+{
+ return nft_chain_validate_hooks(ctx->chain, (1 << NF_NETDEV_INGRESS) |
+ (1 << NF_NETDEV_EGRESS));
+}
+
static int nft_dup_netdev_dump(struct sk_buff *skb, const struct nft_expr *expr)
{
struct nft_dup_netdev *priv = nft_expr_priv(expr);
@@ -79,6 +87,7 @@ static const struct nft_expr_ops nft_dup_netdev_ops = {
.eval = nft_dup_netdev_eval,
.init = nft_dup_netdev_init,
.dump = nft_dup_netdev_dump,
+ .validate = nft_dup_netdev_validate,
.reduce = NFT_REDUCE_READONLY,
.offload = nft_dup_netdev_offload,
.offload_action = nft_dup_netdev_offload_action,
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH nf 2/3] netfilter: nft_osf: restrict osf to ipv4, ipv6 and inet families
2022-08-21 15:53 [PATCH nf 1/3] netfilter: nft_dup: validate family and chains Pablo Neira Ayuso
@ 2022-08-21 15:54 ` Pablo Neira Ayuso
2022-08-21 15:54 ` [PATCH nf 3/3] netfilter: nft_tunnel: restrict it to netdev family Pablo Neira Ayuso
2022-08-21 16:02 ` [PATCH nf 1/3] netfilter: nft_dup: validate family and chains Pablo Neira Ayuso
2 siblings, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2022-08-21 15:54 UTC (permalink / raw)
To: netfilter-devel
As it was originally intended, restrict extension to supported families.
Fixes: b96af92d6eaf ("netfilter: nf_tables: implement Passive OS fingerprint module in nft_osf")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
net/netfilter/nft_osf.c | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/net/netfilter/nft_osf.c b/net/netfilter/nft_osf.c
index 0053a697c931..89342ccccdcc 100644
--- a/net/netfilter/nft_osf.c
+++ b/net/netfilter/nft_osf.c
@@ -115,9 +115,21 @@ static int nft_osf_validate(const struct nft_ctx *ctx,
const struct nft_expr *expr,
const struct nft_data **data)
{
- return nft_chain_validate_hooks(ctx->chain, (1 << NF_INET_LOCAL_IN) |
- (1 << NF_INET_PRE_ROUTING) |
- (1 << NF_INET_FORWARD));
+ unsigned int hooks;
+
+ switch (ctx->family) {
+ case NFPROTO_IPV4:
+ case NFPROTO_IPV6:
+ case NFPROTO_INET:
+ hooks = (1 << NF_INET_LOCAL_IN) |
+ (1 << NF_INET_PRE_ROUTING) |
+ (1 << NF_INET_FORWARD);
+ break;
+ default:
+ return -EOPNOTSUPP;
+ }
+
+ return nft_chain_validate_hooks(ctx->chain, hooks);
}
static bool nft_osf_reduce(struct nft_regs_track *track,
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH nf 3/3] netfilter: nft_tunnel: restrict it to netdev family
2022-08-21 15:53 [PATCH nf 1/3] netfilter: nft_dup: validate family and chains Pablo Neira Ayuso
2022-08-21 15:54 ` [PATCH nf 2/3] netfilter: nft_osf: restrict osf to ipv4, ipv6 and inet families Pablo Neira Ayuso
@ 2022-08-21 15:54 ` Pablo Neira Ayuso
2022-08-21 16:02 ` [PATCH nf 1/3] netfilter: nft_dup: validate family and chains Pablo Neira Ayuso
2 siblings, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2022-08-21 15:54 UTC (permalink / raw)
To: netfilter-devel
Only allow to use this expression from NFPROTO_NETDEV family.
Fixes: af308b94a2a4 ("netfilter: nf_tables: add tunnel support")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
net/netfilter/nft_tunnel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/netfilter/nft_tunnel.c b/net/netfilter/nft_tunnel.c
index 5edaaded706d..983ade4be3b3 100644
--- a/net/netfilter/nft_tunnel.c
+++ b/net/netfilter/nft_tunnel.c
@@ -161,6 +161,7 @@ static const struct nft_expr_ops nft_tunnel_get_ops = {
static struct nft_expr_type nft_tunnel_type __read_mostly = {
.name = "tunnel",
+ .family = NFPROTO_NETDEV,
.ops = &nft_tunnel_get_ops,
.policy = nft_tunnel_policy,
.maxattr = NFTA_TUNNEL_MAX,
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH nf 1/3] netfilter: nft_dup: validate family and chains
2022-08-21 15:53 [PATCH nf 1/3] netfilter: nft_dup: validate family and chains Pablo Neira Ayuso
2022-08-21 15:54 ` [PATCH nf 2/3] netfilter: nft_osf: restrict osf to ipv4, ipv6 and inet families Pablo Neira Ayuso
2022-08-21 15:54 ` [PATCH nf 3/3] netfilter: nft_tunnel: restrict it to netdev family Pablo Neira Ayuso
@ 2022-08-21 16:02 ` Pablo Neira Ayuso
2 siblings, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2022-08-21 16:02 UTC (permalink / raw)
To: netfilter-devel
On Sun, Aug 21, 2022 at 05:53:59PM +0200, Pablo Neira Ayuso wrote:
> This only supports for netdev family and ingress and egress hooks.
Not really required since this is already restricted to
NFPROTO_NETDEV, withdraw.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-21 16:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-21 15:53 [PATCH nf 1/3] netfilter: nft_dup: validate family and chains Pablo Neira Ayuso
2022-08-21 15:54 ` [PATCH nf 2/3] netfilter: nft_osf: restrict osf to ipv4, ipv6 and inet families Pablo Neira Ayuso
2022-08-21 15:54 ` [PATCH nf 3/3] netfilter: nft_tunnel: restrict it to netdev family Pablo Neira Ayuso
2022-08-21 16:02 ` [PATCH nf 1/3] netfilter: nft_dup: validate family and chains Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).