* [PATCH] drm/gpu/nouveau/dispnv50: Restore pushing of all data.
@ 2021-01-18 12:40 Bastian Beranek
[not found] ` <20210118124048.8772-1-bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Bastian Beranek @ 2021-01-18 12:40 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: Bastian Beranek, bskeggs-H+wXaHxf7aLQT0dZR+AlfA
Commit f844eb485eb056ad3b67e49f95cbc6c685a73db4 introduced a regression for
NV50, which lead to visual artifacts, tearing and eventual crashes.
In the changes of f844eb485eb056ad3b67e49f95cbc6c685a73db4 only the first line
was correctly translated to the new NVIDIA header macros:
- PUSH_NVSQ(push, NV827C, 0x0110, 0,
- 0x0114, 0);
+ PUSH_MTHD(push, NV827C, SET_PROCESSING,
+ NVDEF(NV827C, SET_PROCESSING, USE_GAIN_OFS, DISABLE));
The lower part ("0x0114, 0") was probably omitted by accident.
This patch restores the push of the missing data and fixes the regression.
Signed-off-by: Bastian Beranek <bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>
Fixes: f844eb485eb056ad3b67e49f95cbc6c685a73db4
Link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/14
---
drivers/gpu/drm/nouveau/dispnv50/base827c.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/base827c.c b/drivers/gpu/drm/nouveau/dispnv50/base827c.c
index 18d34096f125..093d4ba6910e 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/base827c.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/base827c.c
@@ -49,7 +49,11 @@ base827c_image_set(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw)
NVVAL(NV827C, SET_CONVERSION, OFS, 0x64));
} else {
PUSH_MTHD(push, NV827C, SET_PROCESSING,
- NVDEF(NV827C, SET_PROCESSING, USE_GAIN_OFS, DISABLE));
+ NVDEF(NV827C, SET_PROCESSING, USE_GAIN_OFS, DISABLE),
+
+ SET_CONVERSION,
+ NVVAL(NV827C, SET_CONVERSION, GAIN, 0) |
+ NVVAL(NV827C, SET_CONVERSION, OFS, 0));
}
PUSH_MTHD(push, NV827C, SURFACE_SET_OFFSET(0, 0), asyw->image.offset[0] >> 8,
--
2.30.0
^ permalink raw reply related [flat|nested] 6+ messages in thread[parent not found: <20210118124048.8772-1-bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>]
* [PATCH v2] drm/gpu/nouveau/dispnv50: Restore pushing of all data. [not found] ` <20210118124048.8772-1-bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> @ 2021-01-21 11:11 ` Bastian Beranek [not found] ` <20210121111118.34587-1-bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Bastian Beranek @ 2021-01-21 11:11 UTC (permalink / raw) To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Cc: Bastian Beranek, bskeggs-H+wXaHxf7aLQT0dZR+AlfA Commit f844eb485eb056ad3b67e49f95cbc6c685a73db4 introduced a regression for NV50, which lead to visual artifacts, tearing and eventual crashes. In the changes of f844eb485eb056ad3b67e49f95cbc6c685a73db4 only the first line was correctly translated to the new NVIDIA header macros: - PUSH_NVSQ(push, NV827C, 0x0110, 0, - 0x0114, 0); + PUSH_MTHD(push, NV827C, SET_PROCESSING, + NVDEF(NV827C, SET_PROCESSING, USE_GAIN_OFS, DISABLE)); The lower part ("0x0114, 0") was probably omitted by accident. This patch restores the push of the missing data and fixes the regression. Signed-off-by: Bastian Beranek <bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> Fixes: f844eb485eb056ad3b67e49f95cbc6c685a73db4 Link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/14 --- drivers/gpu/drm/nouveau/dispnv50/base507c.c | 6 +++++- drivers/gpu/drm/nouveau/dispnv50/base827c.c | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/base507c.c b/drivers/gpu/drm/nouveau/dispnv50/base507c.c index 302d4e6fc52f..2d1825a5d751 100644 --- a/drivers/gpu/drm/nouveau/dispnv50/base507c.c +++ b/drivers/gpu/drm/nouveau/dispnv50/base507c.c @@ -88,7 +88,11 @@ base507c_image_set(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw) NVVAL(NV507C, SET_CONVERSION, OFS, 0x64)); } else { PUSH_MTHD(push, NV507C, SET_PROCESSING, - NVDEF(NV507C, SET_PROCESSING, USE_GAIN_OFS, DISABLE)); + NVDEF(NV507C, SET_PROCESSING, USE_GAIN_OFS, DISABLE)), + + SET_CONVERSION, + NVVAL(NV507C, SET_CONVERSION, GAIN, 0) | + NVVAL(NV507C, SET_CONVERSION, OFS, 0)); } PUSH_MTHD(push, NV507C, SURFACE_SET_OFFSET(0, 0), asyw->image.offset[0] >> 8); diff --git a/drivers/gpu/drm/nouveau/dispnv50/base827c.c b/drivers/gpu/drm/nouveau/dispnv50/base827c.c index 18d34096f125..093d4ba6910e 100644 --- a/drivers/gpu/drm/nouveau/dispnv50/base827c.c +++ b/drivers/gpu/drm/nouveau/dispnv50/base827c.c @@ -49,7 +49,11 @@ base827c_image_set(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw) NVVAL(NV827C, SET_CONVERSION, OFS, 0x64)); } else { PUSH_MTHD(push, NV827C, SET_PROCESSING, - NVDEF(NV827C, SET_PROCESSING, USE_GAIN_OFS, DISABLE)); + NVDEF(NV827C, SET_PROCESSING, USE_GAIN_OFS, DISABLE), + + SET_CONVERSION, + NVVAL(NV827C, SET_CONVERSION, GAIN, 0) | + NVVAL(NV827C, SET_CONVERSION, OFS, 0)); } PUSH_MTHD(push, NV827C, SURFACE_SET_OFFSET(0, 0), asyw->image.offset[0] >> 8, -- 2.30.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <20210121111118.34587-1-bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>]
* Re: [PATCH v2] drm/gpu/nouveau/dispnv50: Restore pushing of all data. [not found] ` <20210121111118.34587-1-bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> @ 2021-01-21 11:14 ` Karol Herbst 2021-01-21 14:27 ` [PATCH v3] " Bastian Beranek 1 sibling, 0 replies; 6+ messages in thread From: Karol Herbst @ 2021-01-21 11:14 UTC (permalink / raw) To: Bastian Beranek; +Cc: nouveau, Ben Skeggs ohh, at first I thought this was a resend, but it's in a different file :) On Thu, Jan 21, 2021 at 12:11 PM Bastian Beranek <bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> wrote: > > Commit f844eb485eb056ad3b67e49f95cbc6c685a73db4 introduced a regression for > NV50, which lead to visual artifacts, tearing and eventual crashes. > > In the changes of f844eb485eb056ad3b67e49f95cbc6c685a73db4 only the first line > was correctly translated to the new NVIDIA header macros: > > - PUSH_NVSQ(push, NV827C, 0x0110, 0, > - 0x0114, 0); > + PUSH_MTHD(push, NV827C, SET_PROCESSING, > + NVDEF(NV827C, SET_PROCESSING, USE_GAIN_OFS, DISABLE)); > > The lower part ("0x0114, 0") was probably omitted by accident. > > This patch restores the push of the missing data and fixes the regression. > > Signed-off-by: Bastian Beranek <bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> > Fixes: f844eb485eb056ad3b67e49f95cbc6c685a73db4 > Link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/14 > --- > drivers/gpu/drm/nouveau/dispnv50/base507c.c | 6 +++++- > drivers/gpu/drm/nouveau/dispnv50/base827c.c | 6 +++++- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/base507c.c b/drivers/gpu/drm/nouveau/dispnv50/base507c.c > index 302d4e6fc52f..2d1825a5d751 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/base507c.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/base507c.c > @@ -88,7 +88,11 @@ base507c_image_set(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw) > NVVAL(NV507C, SET_CONVERSION, OFS, 0x64)); > } else { > PUSH_MTHD(push, NV507C, SET_PROCESSING, > - NVDEF(NV507C, SET_PROCESSING, USE_GAIN_OFS, DISABLE)); > + NVDEF(NV507C, SET_PROCESSING, USE_GAIN_OFS, DISABLE)), > + > + SET_CONVERSION, > + NVVAL(NV507C, SET_CONVERSION, GAIN, 0) | > + NVVAL(NV507C, SET_CONVERSION, OFS, 0)); > } > > PUSH_MTHD(push, NV507C, SURFACE_SET_OFFSET(0, 0), asyw->image.offset[0] >> 8); > diff --git a/drivers/gpu/drm/nouveau/dispnv50/base827c.c b/drivers/gpu/drm/nouveau/dispnv50/base827c.c > index 18d34096f125..093d4ba6910e 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/base827c.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/base827c.c > @@ -49,7 +49,11 @@ base827c_image_set(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw) > NVVAL(NV827C, SET_CONVERSION, OFS, 0x64)); > } else { > PUSH_MTHD(push, NV827C, SET_PROCESSING, > - NVDEF(NV827C, SET_PROCESSING, USE_GAIN_OFS, DISABLE)); > + NVDEF(NV827C, SET_PROCESSING, USE_GAIN_OFS, DISABLE), > + > + SET_CONVERSION, > + NVVAL(NV827C, SET_CONVERSION, GAIN, 0) | > + NVVAL(NV827C, SET_CONVERSION, OFS, 0)); > } > > PUSH_MTHD(push, NV827C, SURFACE_SET_OFFSET(0, 0), asyw->image.offset[0] >> 8, > -- > 2.30.0 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3] drm/gpu/nouveau/dispnv50: Restore pushing of all data. [not found] ` <20210121111118.34587-1-bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> 2021-01-21 11:14 ` Karol Herbst @ 2021-01-21 14:27 ` Bastian Beranek [not found] ` <20210121142736.9525-1-bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> 1 sibling, 1 reply; 6+ messages in thread From: Bastian Beranek @ 2021-01-21 14:27 UTC (permalink / raw) To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Cc: Bastian Beranek, bskeggs-H+wXaHxf7aLQT0dZR+AlfA Commit f844eb485eb056ad3b67e49f95cbc6c685a73db4 introduced a regression for NV50, which lead to visual artifacts, tearing and eventual crashes. In the changes of f844eb485eb056ad3b67e49f95cbc6c685a73db4 only the first line was correctly translated to the new NVIDIA header macros: - PUSH_NVSQ(push, NV827C, 0x0110, 0, - 0x0114, 0); + PUSH_MTHD(push, NV827C, SET_PROCESSING, + NVDEF(NV827C, SET_PROCESSING, USE_GAIN_OFS, DISABLE)); The lower part ("0x0114, 0") was probably omitted by accident. This patch restores the push of the missing data and fixes the regression. Signed-off-by: Bastian Beranek <bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> Fixes: f844eb485eb056ad3b67e49f95cbc6c685a73db4 Link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/14 --- drivers/gpu/drm/nouveau/dispnv50/base507c.c | 6 +++++- drivers/gpu/drm/nouveau/dispnv50/base827c.c | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/base507c.c b/drivers/gpu/drm/nouveau/dispnv50/base507c.c index 302d4e6fc52f..788db043a342 100644 --- a/drivers/gpu/drm/nouveau/dispnv50/base507c.c +++ b/drivers/gpu/drm/nouveau/dispnv50/base507c.c @@ -88,7 +88,11 @@ base507c_image_set(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw) NVVAL(NV507C, SET_CONVERSION, OFS, 0x64)); } else { PUSH_MTHD(push, NV507C, SET_PROCESSING, - NVDEF(NV507C, SET_PROCESSING, USE_GAIN_OFS, DISABLE)); + NVDEF(NV507C, SET_PROCESSING, USE_GAIN_OFS, DISABLE), + + SET_CONVERSION, + NVVAL(NV507C, SET_CONVERSION, GAIN, 0) | + NVVAL(NV507C, SET_CONVERSION, OFS, 0)); } PUSH_MTHD(push, NV507C, SURFACE_SET_OFFSET(0, 0), asyw->image.offset[0] >> 8); diff --git a/drivers/gpu/drm/nouveau/dispnv50/base827c.c b/drivers/gpu/drm/nouveau/dispnv50/base827c.c index 18d34096f125..093d4ba6910e 100644 --- a/drivers/gpu/drm/nouveau/dispnv50/base827c.c +++ b/drivers/gpu/drm/nouveau/dispnv50/base827c.c @@ -49,7 +49,11 @@ base827c_image_set(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw) NVVAL(NV827C, SET_CONVERSION, OFS, 0x64)); } else { PUSH_MTHD(push, NV827C, SET_PROCESSING, - NVDEF(NV827C, SET_PROCESSING, USE_GAIN_OFS, DISABLE)); + NVDEF(NV827C, SET_PROCESSING, USE_GAIN_OFS, DISABLE), + + SET_CONVERSION, + NVVAL(NV827C, SET_CONVERSION, GAIN, 0) | + NVVAL(NV827C, SET_CONVERSION, OFS, 0)); } PUSH_MTHD(push, NV827C, SURFACE_SET_OFFSET(0, 0), asyw->image.offset[0] >> 8, -- 2.30.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <20210121142736.9525-1-bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>]
* Re: [PATCH v3] drm/gpu/nouveau/dispnv50: Restore pushing of all data. [not found] ` <20210121142736.9525-1-bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> @ 2021-01-21 16:05 ` Bastian Beranek 2021-01-27 8:56 ` Karol Herbst 1 sibling, 0 replies; 6+ messages in thread From: Bastian Beranek @ 2021-01-21 16:05 UTC (permalink / raw) To: nouveau; +Cc: Ben Skeggs Sorry, please use v3, I made a mistake in v2 and v1 was incomplete. Apologies for the inconveniences! On Thu, Jan 21, 2021 at 3:27 PM Bastian Beranek <bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> wrote: > > Commit f844eb485eb056ad3b67e49f95cbc6c685a73db4 introduced a regression for > NV50, which lead to visual artifacts, tearing and eventual crashes. > > In the changes of f844eb485eb056ad3b67e49f95cbc6c685a73db4 only the first line > was correctly translated to the new NVIDIA header macros: > > - PUSH_NVSQ(push, NV827C, 0x0110, 0, > - 0x0114, 0); > + PUSH_MTHD(push, NV827C, SET_PROCESSING, > + NVDEF(NV827C, SET_PROCESSING, USE_GAIN_OFS, DISABLE)); > > The lower part ("0x0114, 0") was probably omitted by accident. > > This patch restores the push of the missing data and fixes the regression. > > Signed-off-by: Bastian Beranek <bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> > Fixes: f844eb485eb056ad3b67e49f95cbc6c685a73db4 > Link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/14 > --- > drivers/gpu/drm/nouveau/dispnv50/base507c.c | 6 +++++- > drivers/gpu/drm/nouveau/dispnv50/base827c.c | 6 +++++- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/base507c.c b/drivers/gpu/drm/nouveau/dispnv50/base507c.c > index 302d4e6fc52f..788db043a342 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/base507c.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/base507c.c > @@ -88,7 +88,11 @@ base507c_image_set(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw) > NVVAL(NV507C, SET_CONVERSION, OFS, 0x64)); > } else { > PUSH_MTHD(push, NV507C, SET_PROCESSING, > - NVDEF(NV507C, SET_PROCESSING, USE_GAIN_OFS, DISABLE)); > + NVDEF(NV507C, SET_PROCESSING, USE_GAIN_OFS, DISABLE), > + > + SET_CONVERSION, > + NVVAL(NV507C, SET_CONVERSION, GAIN, 0) | > + NVVAL(NV507C, SET_CONVERSION, OFS, 0)); > } > > PUSH_MTHD(push, NV507C, SURFACE_SET_OFFSET(0, 0), asyw->image.offset[0] >> 8); > diff --git a/drivers/gpu/drm/nouveau/dispnv50/base827c.c b/drivers/gpu/drm/nouveau/dispnv50/base827c.c > index 18d34096f125..093d4ba6910e 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/base827c.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/base827c.c > @@ -49,7 +49,11 @@ base827c_image_set(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw) > NVVAL(NV827C, SET_CONVERSION, OFS, 0x64)); > } else { > PUSH_MTHD(push, NV827C, SET_PROCESSING, > - NVDEF(NV827C, SET_PROCESSING, USE_GAIN_OFS, DISABLE)); > + NVDEF(NV827C, SET_PROCESSING, USE_GAIN_OFS, DISABLE), > + > + SET_CONVERSION, > + NVVAL(NV827C, SET_CONVERSION, GAIN, 0) | > + NVVAL(NV827C, SET_CONVERSION, OFS, 0)); > } > > PUSH_MTHD(push, NV827C, SURFACE_SET_OFFSET(0, 0), asyw->image.offset[0] >> 8, > -- > 2.30.0 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] drm/gpu/nouveau/dispnv50: Restore pushing of all data. [not found] ` <20210121142736.9525-1-bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> 2021-01-21 16:05 ` Bastian Beranek @ 2021-01-27 8:56 ` Karol Herbst 1 sibling, 0 replies; 6+ messages in thread From: Karol Herbst @ 2021-01-27 8:56 UTC (permalink / raw) To: Bastian Beranek; +Cc: nouveau, Ben Skeggs Reviewed-by: Karol Herbst <kherbst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> On Thu, Jan 21, 2021 at 3:28 PM Bastian Beranek <bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> wrote: > > Commit f844eb485eb056ad3b67e49f95cbc6c685a73db4 introduced a regression for > NV50, which lead to visual artifacts, tearing and eventual crashes. > > In the changes of f844eb485eb056ad3b67e49f95cbc6c685a73db4 only the first line > was correctly translated to the new NVIDIA header macros: > > - PUSH_NVSQ(push, NV827C, 0x0110, 0, > - 0x0114, 0); > + PUSH_MTHD(push, NV827C, SET_PROCESSING, > + NVDEF(NV827C, SET_PROCESSING, USE_GAIN_OFS, DISABLE)); > > The lower part ("0x0114, 0") was probably omitted by accident. > > This patch restores the push of the missing data and fixes the regression. > > Signed-off-by: Bastian Beranek <bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> > Fixes: f844eb485eb056ad3b67e49f95cbc6c685a73db4 > Link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/14 > --- > drivers/gpu/drm/nouveau/dispnv50/base507c.c | 6 +++++- > drivers/gpu/drm/nouveau/dispnv50/base827c.c | 6 +++++- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/base507c.c b/drivers/gpu/drm/nouveau/dispnv50/base507c.c > index 302d4e6fc52f..788db043a342 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/base507c.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/base507c.c > @@ -88,7 +88,11 @@ base507c_image_set(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw) > NVVAL(NV507C, SET_CONVERSION, OFS, 0x64)); > } else { > PUSH_MTHD(push, NV507C, SET_PROCESSING, > - NVDEF(NV507C, SET_PROCESSING, USE_GAIN_OFS, DISABLE)); > + NVDEF(NV507C, SET_PROCESSING, USE_GAIN_OFS, DISABLE), > + > + SET_CONVERSION, > + NVVAL(NV507C, SET_CONVERSION, GAIN, 0) | > + NVVAL(NV507C, SET_CONVERSION, OFS, 0)); > } > > PUSH_MTHD(push, NV507C, SURFACE_SET_OFFSET(0, 0), asyw->image.offset[0] >> 8); > diff --git a/drivers/gpu/drm/nouveau/dispnv50/base827c.c b/drivers/gpu/drm/nouveau/dispnv50/base827c.c > index 18d34096f125..093d4ba6910e 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/base827c.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/base827c.c > @@ -49,7 +49,11 @@ base827c_image_set(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw) > NVVAL(NV827C, SET_CONVERSION, OFS, 0x64)); > } else { > PUSH_MTHD(push, NV827C, SET_PROCESSING, > - NVDEF(NV827C, SET_PROCESSING, USE_GAIN_OFS, DISABLE)); > + NVDEF(NV827C, SET_PROCESSING, USE_GAIN_OFS, DISABLE), > + > + SET_CONVERSION, > + NVVAL(NV827C, SET_CONVERSION, GAIN, 0) | > + NVVAL(NV827C, SET_CONVERSION, OFS, 0)); > } > > PUSH_MTHD(push, NV827C, SURFACE_SET_OFFSET(0, 0), asyw->image.offset[0] >> 8, > -- > 2.30.0 > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-27 8:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-18 12:40 [PATCH] drm/gpu/nouveau/dispnv50: Restore pushing of all data Bastian Beranek
[not found] ` <20210118124048.8772-1-bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>
2021-01-21 11:11 ` [PATCH v2] " Bastian Beranek
[not found] ` <20210121111118.34587-1-bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>
2021-01-21 11:14 ` Karol Herbst
2021-01-21 14:27 ` [PATCH v3] " Bastian Beranek
[not found] ` <20210121142736.9525-1-bastian.beischer-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>
2021-01-21 16:05 ` Bastian Beranek
2021-01-27 8:56 ` Karol Herbst
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).