* [PATCH] ntb_perf: Fix printk format
@ 2023-09-10 7:34 Max Hawking
2023-09-10 15:04 ` Jon Mason
2023-09-10 19:18 ` Randy Dunlap
0 siblings, 2 replies; 3+ messages in thread
From: Max Hawking @ 2023-09-10 7:34 UTC (permalink / raw)
To: Jon Mason, Dave Jiang, Allen Hubbe, Serge Semin, Minjie Du, ntb,
linux-kernel
The correct printk format is %pa or %pap, but not %pa[p].
Fixes: 99a06056124d ("NTB: ntb_perf: Fix address err in perf_copy_chunk")
Signed-off-by: Max Hawking <maxahawking@sonnenkinder.org>
---
drivers/ntb/test/ntb_perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
index 553f1f46bc66..72bc1d017a46 100644
--- a/drivers/ntb/test/ntb_perf.c
+++ b/drivers/ntb/test/ntb_perf.c
@@ -1227,7 +1227,7 @@ static ssize_t perf_dbgfs_read_info(struct file
*filep, char __user *ubuf,
"\tOut buffer addr 0x%pK\n", peer->outbuf);
pos += scnprintf(buf + pos, buf_size - pos,
- "\tOut buff phys addr %pa[p]\n", &peer->out_phys_addr);
+ "\tOut buff phys addr %pap\n", &peer->out_phys_addr);
pos += scnprintf(buf + pos, buf_size - pos,
"\tOut buffer size %pa\n", &peer->outbuf_size);
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ntb_perf: Fix printk format
2023-09-10 7:34 [PATCH] ntb_perf: Fix printk format Max Hawking
@ 2023-09-10 15:04 ` Jon Mason
2023-09-10 19:18 ` Randy Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Jon Mason @ 2023-09-10 15:04 UTC (permalink / raw)
To: Max Hawking
Cc: Dave Jiang, Allen Hubbe, Serge Semin, Minjie Du, ntb, linux-kernel
On Sun, Sep 10, 2023 at 12:34:34AM -0700, Max Hawking wrote:
> The correct printk format is %pa or %pap, but not %pa[p].
>
> Fixes: 99a06056124d ("NTB: ntb_perf: Fix address err in perf_copy_chunk")
> Signed-off-by: Max Hawking <maxahawking@sonnenkinder.org>
> ---
> drivers/ntb/test/ntb_perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> index 553f1f46bc66..72bc1d017a46 100644
> --- a/drivers/ntb/test/ntb_perf.c
> +++ b/drivers/ntb/test/ntb_perf.c
> @@ -1227,7 +1227,7 @@ static ssize_t perf_dbgfs_read_info(struct file
> *filep, char __user *ubuf,
> "\tOut buffer addr 0x%pK\n", peer->outbuf);
>
> pos += scnprintf(buf + pos, buf_size - pos,
> - "\tOut buff phys addr %pa[p]\n", &peer->out_phys_addr);
> + "\tOut buff phys addr %pap\n", &peer->out_phys_addr);
>
> pos += scnprintf(buf + pos, buf_size - pos,
> "\tOut buffer size %pa\n", &peer->outbuf_size);
> --
> 2.41.0
For some reason this patch isn't applying cleanly for me, I'm seeing
the following issue:
$ b4 am -o - f2fb85b9-278d-9e12-b61c-d951c71bf2f6@gmx.net | patch -p1
...
patching file drivers/ntb/test/ntb_perf.c
patch: **** malformed patch at line 23: *filep, char __user *ubuf,
Please rebase and resend.
Thanks,
Jon
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ntb_perf: Fix printk format
2023-09-10 7:34 [PATCH] ntb_perf: Fix printk format Max Hawking
2023-09-10 15:04 ` Jon Mason
@ 2023-09-10 19:18 ` Randy Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-09-10 19:18 UTC (permalink / raw)
To: Max Hawking, Jon Mason, Dave Jiang, Allen Hubbe, Serge Semin,
Minjie Du, ntb, linux-kernel
Hi--
On 9/10/23 00:34, Max Hawking wrote:
> The correct printk format is %pa or %pap, but not %pa[p].
>
> Fixes: 99a06056124d ("NTB: ntb_perf: Fix address err in perf_copy_chunk")
> Signed-off-by: Max Hawking <maxahawking@sonnenkinder.org>
> ---
> drivers/ntb/test/ntb_perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> index 553f1f46bc66..72bc1d017a46 100644
> --- a/drivers/ntb/test/ntb_perf.c
> +++ b/drivers/ntb/test/ntb_perf.c
> @@ -1227,7 +1227,7 @@ static ssize_t perf_dbgfs_read_info(struct file
> *filep, char __user *ubuf,
Those 2 lines above should be on one line.
(i.e., they should not wrap, so set tbird's wrap length to 0)
Documentation/process/email-clients.rst has some info about
how to coerce Thunderbird into working for patches.
> "\tOut buffer addr 0x%pK\n", peer->outbuf);
>
> pos += scnprintf(buf + pos, buf_size - pos,
> - "\tOut buff phys addr %pa[p]\n", &peer->out_phys_addr);
> + "\tOut buff phys addr %pap\n", &peer->out_phys_addr);
>
> pos += scnprintf(buf + pos, buf_size - pos,
> "\tOut buffer size %pa\n", &peer->outbuf_size);
> --
> 2.41.0
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-10 19:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-10 7:34 [PATCH] ntb_perf: Fix printk format Max Hawking
2023-09-10 15:04 ` Jon Mason
2023-09-10 19:18 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).