* [PATCH] NTB: ntb_transport: fix all kernel-doc warnings
@ 2024-01-19 3:28 Randy Dunlap
2024-01-19 15:36 ` Dave Jiang
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2024-01-19 3:28 UTC (permalink / raw)
To: linux-kernel; +Cc: Randy Dunlap, Jon Mason, Dave Jiang, Allen Hubbe, ntb
Fix all kernel-doc warnings in ntb_transport.c.
The function parameters for ntb_transport_create_queue() changed, so
update them in the kernel-doc comments.
Add a Returns: comment for ntb_transport_register_client_dev().
ntb_transport.c:382: warning: No description found for return value of 'ntb_transport_register_client_dev'
ntb_transport.c:1984: warning: Excess function parameter 'rx_handler' description in 'ntb_transport_create_queue'
ntb_transport.c:1984: warning: Excess function parameter 'tx_handler' description in 'ntb_transport_create_queue'
ntb_transport.c:1984: warning: Excess function parameter 'event_handler' description in 'ntb_transport_create_queue'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jon Mason <jdmason@kudzu.us>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Allen Hubbe <allenbh@gmail.com>
Cc: ntb@lists.linux.dev
---
drivers/ntb/ntb_transport.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff -- a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
--- a/drivers/ntb/ntb_transport.c
+++ b/drivers/ntb/ntb_transport.c
@@ -377,6 +377,8 @@ EXPORT_SYMBOL_GPL(ntb_transport_unregist
* @device_name: Name of NTB client device
*
* Register an NTB client device with the NTB transport layer
+ *
+ * Returns: %0 on success or -errno code on error
*/
int ntb_transport_register_client_dev(char *device_name)
{
@@ -1966,9 +1968,9 @@ static bool ntb_dma_filter_fn(struct dma
/**
* ntb_transport_create_queue - Create a new NTB transport layer queue
- * @rx_handler: receive callback function
- * @tx_handler: transmit callback function
- * @event_handler: event callback function
+ * @data: pointer for callback data
+ * @client_dev: &struct device pointer
+ * @handlers: pointer to various ntb queue (callback) handlers
*
* Create a new NTB transport layer queue and provide the queue with a callback
* routine for both transmit and receive. The receive callback routine will be
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] NTB: ntb_transport: fix all kernel-doc warnings
2024-01-19 3:28 [PATCH] NTB: ntb_transport: fix all kernel-doc warnings Randy Dunlap
@ 2024-01-19 15:36 ` Dave Jiang
0 siblings, 0 replies; 2+ messages in thread
From: Dave Jiang @ 2024-01-19 15:36 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel; +Cc: Jon Mason, Allen Hubbe, ntb
On 1/18/24 20:28, Randy Dunlap wrote:
> Fix all kernel-doc warnings in ntb_transport.c.
>
> The function parameters for ntb_transport_create_queue() changed, so
> update them in the kernel-doc comments.
> Add a Returns: comment for ntb_transport_register_client_dev().
>
> ntb_transport.c:382: warning: No description found for return value of 'ntb_transport_register_client_dev'
> ntb_transport.c:1984: warning: Excess function parameter 'rx_handler' description in 'ntb_transport_create_queue'
> ntb_transport.c:1984: warning: Excess function parameter 'tx_handler' description in 'ntb_transport_create_queue'
> ntb_transport.c:1984: warning: Excess function parameter 'event_handler' description in 'ntb_transport_create_queue'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jon Mason <jdmason@kudzu.us>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Allen Hubbe <allenbh@gmail.com>
> Cc: ntb@lists.linux.dev
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Thanks Randy!
> ---
> drivers/ntb/ntb_transport.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff -- a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> --- a/drivers/ntb/ntb_transport.c
> +++ b/drivers/ntb/ntb_transport.c
> @@ -377,6 +377,8 @@ EXPORT_SYMBOL_GPL(ntb_transport_unregist
> * @device_name: Name of NTB client device
> *
> * Register an NTB client device with the NTB transport layer
> + *
> + * Returns: %0 on success or -errno code on error
> */
> int ntb_transport_register_client_dev(char *device_name)
> {
> @@ -1966,9 +1968,9 @@ static bool ntb_dma_filter_fn(struct dma
>
> /**
> * ntb_transport_create_queue - Create a new NTB transport layer queue
> - * @rx_handler: receive callback function
> - * @tx_handler: transmit callback function
> - * @event_handler: event callback function
> + * @data: pointer for callback data
> + * @client_dev: &struct device pointer
> + * @handlers: pointer to various ntb queue (callback) handlers
> *
> * Create a new NTB transport layer queue and provide the queue with a callback
> * routine for both transmit and receive. The receive callback routine will be
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-19 15:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-19 3:28 [PATCH] NTB: ntb_transport: fix all kernel-doc warnings Randy Dunlap
2024-01-19 15:36 ` Dave Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).