nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: Andreas Hasenack <andreas@canonical.com>, linux-nvdimm@lists.01.org
Subject: Re: [ndctl PATCH 1/2] ndctl, monitor: fix the severity of the "daemon started" message
Date: Fri, 05 Oct 2018 13:08:25 +0900	[thread overview]
Message-ID: <20181005130821.2E72.E1E9C6FF@jp.fujitsu.com> (raw)
In-Reply-To: <20181005000057.30186-1-vishal.l.verma@intel.com>

Hi, Vishal-san,

> The above message was printed as an error, but it is just an
> informational message. Change it to dbg().

Hmmmmmmm.

When I was a engineer for trouble-shooting of customer's Linux system,
the starting time and the ending time of any daemon was very helpful
for investigating their trouble.

So, I think it is not only for developer, but also it is essential for
trouble-shooter for custmer support. 
(It may be also same with system operator)


> 
> Cc: QI Fuli <qi.fuli@jp.fujitsu.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
>  ndctl/monitor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ndctl/monitor.c b/ndctl/monitor.c
> index d29e378..b44f946 100644
> --- a/ndctl/monitor.c
> +++ b/ndctl/monitor.c
> @@ -660,7 +660,7 @@ int cmd_monitor(int argc, const char **argv, void *ctx)
>  			err((struct ndctl_ctx *)ctx, "daemon start failed\n");
>  			goto out;
>  		}
> -		err((struct ndctl_ctx *)ctx, "ndctl monitor daemon started\n");
> +		dbg((struct ndctl_ctx *)ctx, "ndctl monitor daemon started\n");

Though I agree its message is not "error" certainly,
I would like to keep it as normal status level message.

Thanks,
---
Yasunori Goto



_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  parent reply	other threads:[~2018-10-05  4:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05  0:00 [ndctl PATCH 1/2] ndctl, monitor: fix the severity of the "daemon started" message Vishal Verma
2018-10-05  0:00 ` [ndctl PATCH 2/2] ndctl, monitor: in daemon mode, exit successfully if no DIMMs are found Vishal Verma
2018-10-05  0:05   ` Williams, Dan J
2018-10-05  5:15   ` Qi, Fuli
2018-10-05  0:04 ` [ndctl PATCH 1/2] ndctl, monitor: fix the severity of the "daemon started" message Williams, Dan J
2018-10-05  4:08 ` Yasunori Goto [this message]
2018-10-05  4:23   ` Dan Williams
2018-10-05  4:59     ` Qi, Fuli
     [not found]       ` <4adb62046776c34d28172a94aa95157774e41644.camel@intel.com>
2018-10-05  6:15         ` Qi, Fuli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181005130821.2E72.E1E9C6FF@jp.fujitsu.com \
    --to=y-goto@jp.fujitsu.com \
    --cc=andreas@canonical.com \
    --cc=linux-nvdimm@lists.01.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).