From: "Williams, Dan J" <dan.j.williams@intel.com>
To: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"Verma, Vishal L" <vishal.l.verma@intel.com>
Cc: "andreas@canonical.com" <andreas@canonical.com>
Subject: Re: [ndctl PATCH 2/2] ndctl, monitor: in daemon mode, exit successfully if no DIMMs are found
Date: Fri, 5 Oct 2018 00:05:37 +0000 [thread overview]
Message-ID: <ae5d56a43ee6fa728643dfeb8815e3c00cbb7e1e.camel@intel.com> (raw)
In-Reply-To: <20181005000057.30186-2-vishal.l.verma@intel.com>
On Thu, 2018-10-04 at 18:00 -0600, Vishal Verma wrote:
> When we are running as a daemon, it is preferred to exit successfully
> when no DIMMs are found. When running in the foreground, retain an
> error
> return so that the user can be notified that nothing was found to
> monitor.
>
> In the longer term, replace this with a libudev uevent monitor that
> will
> look for DIMM addition/removal events, and update the running
> monitor(s)
> if the DIMMs match the active filter spec.
>
> Link: https://bugs.launchpad.net/ubuntu/+source/ndctl/+bug/1781268
> Reported-by: Andreas Hasenack <andreas@canonical.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
Looks good to me, if no one is sticking around to reap the error might
as well claim success.
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-10-05 0:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 0:00 [ndctl PATCH 1/2] ndctl, monitor: fix the severity of the "daemon started" message Vishal Verma
2018-10-05 0:00 ` [ndctl PATCH 2/2] ndctl, monitor: in daemon mode, exit successfully if no DIMMs are found Vishal Verma
2018-10-05 0:05 ` Williams, Dan J [this message]
2018-10-05 5:15 ` Qi, Fuli
2018-10-05 0:04 ` [ndctl PATCH 1/2] ndctl, monitor: fix the severity of the "daemon started" message Williams, Dan J
2018-10-05 4:08 ` Yasunori Goto
2018-10-05 4:23 ` Dan Williams
2018-10-05 4:59 ` Qi, Fuli
[not found] ` <4adb62046776c34d28172a94aa95157774e41644.camel@intel.com>
2018-10-05 6:15 ` Qi, Fuli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae5d56a43ee6fa728643dfeb8815e3c00cbb7e1e.camel@intel.com \
--to=dan.j.williams@intel.com \
--cc=andreas@canonical.com \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).