From: Geliang Tang <geliang.tang@suse.com>
To: Coly Li <colyli@suse.de>
Cc: Dan Williams <dan.j.williams@intel.com>,
Hannes Reinecke <hare@suse.de>, Jens Axboe <axboe@kernel.dk>,
NeilBrown <neilb@suse.de>, Richard Fan <richard.fan@suse.com>,
Vishal L Verma <vishal.l.verma@intel.com>,
Wols Lists <antlists@youngman.org.uk>, Xiao Ni <xni@redhat.com>,
linux-raid@vger.kernel.org, nvdimm@lists.linux.dev,
linux-block@vger.kernel.org
Subject: Re: [PATCH v7 0/6] badblocks improvement for multiple bad block ranges
Date: Tue, 26 Sep 2023 09:47:19 +0800 [thread overview]
Message-ID: <20230926014719.GA5275@localhost> (raw)
In-Reply-To: <20230811170513.2300-1-colyli@suse.de>
On Sat, Aug 12, 2023 at 01:05:06AM +0800, Coly Li wrote:
> This is the v7 version of the badblocks improvement series, which makes
> badblocks APIs to handle multiple ranges in bad block table.
>
> The change comparing to previous v6 version is the modifications
> enlightened by the code review comments from Xiao Ni,
> - Typo fixes in code comments and commit logs.
> - Tiny but useful optimzation in prev_badblocks(), front_overwrite(),
> _badblocks_clear().
>
> There is NO in-memory or on-disk format change in the whole series, all
> existing API and data structures are consistent. This series just only
> improve the code algorithm to handle more corner cases, the interfaces
> are same and consistency to all existing callers (md raid and nvdimm
> drivers).
>
> The original motivation of the change is from the requirement from our
> customer, that current badblocks routines don't handle multiple ranges.
> For example if the bad block setting range covers multiple ranges from
> bad block table, only the first two bad block ranges merged and rested
> ranges are intact. The expected behavior should be all the covered
> ranges to be handled.
>
> All the patches are tested by modified user space code and the code
> logic works as expected. The modified user space testing code is
> provided in the last patch, which is not listed in the cover letter. The
> testing code is an example how the improved code is tested.
>
> The whole change is divided into 6 patches to make the code review more
> clear and easier. If people prefer, I'd like to post a single large
> patch finally after the code review accomplished.
>
> Please review the code and response. Thank you all in advance.
>
> Coly Li
>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Geliang Tang <geliang.tang@suse.com>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: NeilBrown <neilb@suse.de>
> Cc: Richard Fan <richard.fan@suse.com>
> Cc: Vishal L Verma <vishal.l.verma@intel.com>
> Cc: Wols Lists <antlists@youngman.org.uk>
> Cc: Xiao Ni <xni@redhat.com>
This series LGTM, thanks Coly.
Acked-by: Geliang Tang <geliang.tang@suse.com>
> ---
>
> Coly Li (6):
> badblocks: add more helper structure and routines in badblocks.h
> badblocks: add helper routines for badblock ranges handling
> badblocks: improve badblocks_set() for multiple ranges handling
> badblocks: improve badblocks_clear() for multiple ranges handling
> badblocks: improve badblocks_check() for multiple ranges handling
> badblocks: switch to the improved badblock handling code
>
> block/badblocks.c | 1618 ++++++++++++++++++++++++++++++-------
> include/linux/badblocks.h | 30 +
> 2 files changed, 1354 insertions(+), 294 deletions(-)
>
> --
> 2.35.3
>
next prev parent reply other threads:[~2023-09-26 1:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 17:05 [PATCH v7 0/6] badblocks improvement for multiple bad block ranges Coly Li
2023-08-11 17:05 ` [PATCH v7 1/6] badblocks: add more helper structure and routines in badblocks.h Coly Li
2023-08-11 17:05 ` [PATCH v7 2/6] badblocks: add helper routines for badblock ranges handling Coly Li
2023-09-02 14:21 ` Xiao Ni
2023-08-11 17:05 ` [PATCH v7 3/6] badblocks: improve badblocks_set() for multiple " Coly Li
2023-09-03 1:20 ` Xiao Ni
2023-08-11 17:05 ` [PATCH v7 4/6] badblocks: improve badblocks_clear() " Coly Li
2023-09-03 1:56 ` Xiao Ni
2023-08-11 17:05 ` [PATCH v7 5/6] badblocks: improve badblocks_check() " Coly Li
2023-09-03 3:26 ` Xiao Ni
2023-08-11 17:05 ` [PATCH v7 6/6] badblocks: switch to the improved badblock handling code Coly Li
2023-09-03 3:27 ` Xiao Ni
2023-08-11 17:05 ` [PATCH] test: user space code to test badblocks APIs Coly Li
2023-09-26 1:47 ` Geliang Tang [this message]
2023-09-26 6:44 ` [PATCH v7 0/6] badblocks improvement for multiple bad block ranges Jens Axboe
2023-12-22 19:01 ` Ira Weiny
2023-12-23 6:46 ` Li Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926014719.GA5275@localhost \
--to=geliang.tang@suse.com \
--cc=antlists@youngman.org.uk \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=dan.j.williams@intel.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=nvdimm@lists.linux.dev \
--cc=richard.fan@suse.com \
--cc=vishal.l.verma@intel.com \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).