oe-kbuild-all.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [linux-next:master 11772/12060] fs/coredump.c:67:27: warning: unused variable 'core_file_note_size_min'
@ 2024-05-08 10:30 kernel test robot
  2024-05-08 16:53 ` Kees Cook
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2024-05-08 10:30 UTC (permalink / raw)
  To: Allen Pais
  Cc: llvm, oe-kbuild-all, Linux Memory Management List, Kees Cook, Vijay Nag

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   e7b4ef8fffaca247809337bb78daceb406659f2d
commit: 13513eafc3ea08cdb70aebe56a7e43083302a809 [11772/12060] fs/coredump: Enable dynamic configuration of max file note size
config: i386-buildonly-randconfig-005-20240508 (https://download.01.org/0day-ci/archive/20240508/202405081838.tuETPvPf-lkp@intel.com/config)
compiler: clang version 18.1.4 (https://github.com/llvm/llvm-project e6c3289804a67ea0bb6a86fadbe454dd93b8d855)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240508/202405081838.tuETPvPf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405081838.tuETPvPf-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/coredump.c:67:27: warning: unused variable 'core_file_note_size_min' [-Wunused-const-variable]
      67 | static const unsigned int core_file_note_size_min = CORE_FILE_NOTE_SIZE_DEFAULT;
         |                           ^~~~~~~~~~~~~~~~~~~~~~~
   fs/coredump.c:68:27: warning: unused variable 'core_file_note_size_max' [-Wunused-const-variable]
      68 | static const unsigned int core_file_note_size_max = CORE_FILE_NOTE_SIZE_MAX;
         |                           ^~~~~~~~~~~~~~~~~~~~~~~
   2 warnings generated.


vim +/core_file_note_size_min +67 fs/coredump.c

    62	
    63	static int core_uses_pid;
    64	static unsigned int core_pipe_limit;
    65	static char core_pattern[CORENAME_MAX_SIZE] = "core";
    66	static int core_name_size = CORENAME_MAX_SIZE;
  > 67	static const unsigned int core_file_note_size_min = CORE_FILE_NOTE_SIZE_DEFAULT;
    68	static const unsigned int core_file_note_size_max = CORE_FILE_NOTE_SIZE_MAX;
    69	unsigned int core_file_note_size_limit = CORE_FILE_NOTE_SIZE_DEFAULT;
    70	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [linux-next:master 11772/12060] fs/coredump.c:67:27: warning: unused variable 'core_file_note_size_min'
  2024-05-08 10:30 [linux-next:master 11772/12060] fs/coredump.c:67:27: warning: unused variable 'core_file_note_size_min' kernel test robot
@ 2024-05-08 16:53 ` Kees Cook
  0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2024-05-08 16:53 UTC (permalink / raw)
  To: kernel test robot
  Cc: Allen Pais, llvm, oe-kbuild-all, Linux Memory Management List, Vijay Nag

On Wed, May 08, 2024 at 06:30:25PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   e7b4ef8fffaca247809337bb78daceb406659f2d
> commit: 13513eafc3ea08cdb70aebe56a7e43083302a809 [11772/12060] fs/coredump: Enable dynamic configuration of max file note size
> config: i386-buildonly-randconfig-005-20240508 (https://download.01.org/0day-ci/archive/20240508/202405081838.tuETPvPf-lkp@intel.com/config)
> compiler: clang version 18.1.4 (https://github.com/llvm/llvm-project e6c3289804a67ea0bb6a86fadbe454dd93b8d855)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240508/202405081838.tuETPvPf-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202405081838.tuETPvPf-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> fs/coredump.c:67:27: warning: unused variable 'core_file_note_size_min' [-Wunused-const-variable]
>       67 | static const unsigned int core_file_note_size_min = CORE_FILE_NOTE_SIZE_DEFAULT;
>          |                           ^~~~~~~~~~~~~~~~~~~~~~~
>    fs/coredump.c:68:27: warning: unused variable 'core_file_note_size_max' [-Wunused-const-variable]
>       68 | static const unsigned int core_file_note_size_max = CORE_FILE_NOTE_SIZE_MAX;
>          |                           ^~~~~~~~~~~~~~~~~~~~~~~
>    2 warnings generated.

Thanks. I folded in a fix to move these under CONFIG_SYSCTL.

-Kees

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-05-08 16:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-08 10:30 [linux-next:master 11772/12060] fs/coredump.c:67:27: warning: unused variable 'core_file_note_size_min' kernel test robot
2024-05-08 16:53 ` Kees Cook

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).