[bcachefs:bcachefs-testing 167/167] fs/bcachefs/bkey_sort.c:170:28: warning: unused variable 'f'

[bcachefs:bcachefs-testing 167/167] fs/bcachefs/bkey_sort.c:170:28: warning: unused variable 'f'

[kernel test robot]

tree:   https://evilpiepirate.org/git/bcachefs.git bcachefs-testing
head:   820055ea04424d9c5d0d58322888ee46fefb55bc
commit: 820055ea04424d9c5d0d58322888ee46fefb55bc [167/167] bcachefs: whiteout fix
config: s390-defconfig (https://download.01.org/0day-ci/archive/20240508/202405081651.dAvosJcU-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 0ab4458df0688955620b72cc2c72a32dffad3615)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240508/202405081651.dAvosJcU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405081651.dAvosJcU-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from fs/bcachefs/bkey_sort.c:2:
   In file included from fs/bcachefs/bcachefs.h:188:
   In file included from include/linux/bio.h:10:
   In file included from include/linux/blk_types.h:10:
   In file included from include/linux/bvec.h:10:
   In file included from include/linux/highmem.h:10:
   In file included from include/linux/mm.h:2210:
   include/linux/vmstat.h:508:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     508 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     509 |                            item];
         |                            ~~~~
   include/linux/vmstat.h:515:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     515 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     516 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     522 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
   include/linux/vmstat.h:527:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     527 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     528 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   include/linux/vmstat.h:536:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     536 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     537 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
>> fs/bcachefs/bkey_sort.c:170:28: warning: unused variable 'f' [-Wunused-variable]
     170 |         const struct bkey_format *f = &iter->b->format;
         |                                   ^
   6 warnings generated.


vim +/f +170 fs/bcachefs/bkey_sort.c

820055ea04424d Kent Overstreet 2024-05-08  167  
820055ea04424d Kent Overstreet 2024-05-08  168  unsigned bch2_sort_keys_keep_unwritten_whiteouts(struct bkey_packed *dst, struct sort_iter *iter)
5b8a9227f8a4ac Kent Overstreet 2018-11-27  169  {
5b8a9227f8a4ac Kent Overstreet 2018-11-27 @170  	const struct bkey_format *f = &iter->b->format;
5b8a9227f8a4ac Kent Overstreet 2018-11-27  171  	struct bkey_packed *in, *next, *out = dst;
5b8a9227f8a4ac Kent Overstreet 2018-11-27  172  
820055ea04424d Kent Overstreet 2024-05-08  173  	sort_iter_sort(iter, keep_unwritten_whiteouts_cmp);
5b8a9227f8a4ac Kent Overstreet 2018-11-27  174  
820055ea04424d Kent Overstreet 2024-05-08  175  	while ((in = sort_iter_next(iter, keep_unwritten_whiteouts_cmp))) {
820055ea04424d Kent Overstreet 2024-05-08  176  		if (bkey_deleted(in) && in < unwritten_whiteouts_start(iter->b))
820055ea04424d Kent Overstreet 2024-05-08  177  			continue;
a965ef4986243b Kent Overstreet 2020-01-15  178  
820055ea04424d Kent Overstreet 2024-05-08  179  		if ((next = sort_iter_peek(iter)) &&
820055ea04424d Kent Overstreet 2024-05-08  180  		    !bch2_bkey_cmp_packed_inlined(iter->b, in, next))
5b8a9227f8a4ac Kent Overstreet 2018-11-27  181  			continue;
5b8a9227f8a4ac Kent Overstreet 2018-11-27  182  
820055ea04424d Kent Overstreet 2024-05-08  183  		bkey_p_copy(out, in);
820055ea04424d Kent Overstreet 2024-05-08  184  		out = bkey_p_next(out);
5b8a9227f8a4ac Kent Overstreet 2018-11-27  185  	}
5b8a9227f8a4ac Kent Overstreet 2018-11-27  186  
820055ea04424d Kent Overstreet 2024-05-08  187  	return (u64 *) out - (u64 *) dst;
5b8a9227f8a4ac Kent Overstreet 2018-11-27  188  }
820055ea04424d Kent Overstreet 2024-05-08  189  

:::::: The code at line 170 was first introduced by commit
:::::: 5b8a9227f8a4acd9652d6d89a608fbf4c39c6f44 bcachefs: Split out bkey_sort.c

:::::: TO: Kent Overstreet <kent.overstreet@gmail.com>
:::::: CC: Kent Overstreet <kent.overstreet@linux.dev>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki