* Re: [PATCH v4 1/5] Bluetooth: btmtk: add the function to get the fw name
[not found] <965cd14922aea67e2750ff2c2ecad773f8ba485a.1715109394.git.sean.wang@kernel.org>
@ 2024-05-08 7:12 ` kernel test robot
2024-05-08 14:37 ` Luiz Augusto von Dentz
2024-05-08 11:22 ` kernel test robot
1 sibling, 1 reply; 4+ messages in thread
From: kernel test robot @ 2024-05-08 7:12 UTC (permalink / raw)
To: sean.wang, marcel, johan.hedberg, luiz.dentz
Cc: oe-kbuild-all, linux-bluetooth, linux-mediatek, linux-kernel, Sean Wang
Hi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bluetooth/master]
[also build test WARNING on bluetooth-next/master linus/master v6.9-rc7 next-20240507]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/sean-wang-kernel-org/Bluetooth-btmtk-apply-the-common-btmtk_fw_get_filename/20240508-032333
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link: https://lore.kernel.org/r/965cd14922aea67e2750ff2c2ecad773f8ba485a.1715109394.git.sean.wang%40kernel.org
patch subject: [PATCH v4 1/5] Bluetooth: btmtk: add the function to get the fw name
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240508/202405081456.v2MvcQ0P-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240508/202405081456.v2MvcQ0P-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405081456.v2MvcQ0P-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/bluetooth/btmtk.c: In function 'btmtk_fw_get_filename':
>> drivers/bluetooth/btmtk.c:115:35: warning: 'mediatek/BT_RAM_CODE_MT' directive output truncated writing 23 bytes into a region of size 8 [-Wformat-truncation=]
115 | "mediatek/BT_RAM_CODE_MT%04x_1a_%x_hdr.bin",
| ~~~~~~~~^~~~~~~~~~~~~~~
drivers/bluetooth/btmtk.c:115:26: note: directive argument in the range [1, 256]
115 | "mediatek/BT_RAM_CODE_MT%04x_1a_%x_hdr.bin",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/bluetooth/btmtk.c:114:17: note: 'snprintf' output between 41 and 43 bytes into a destination of size 8
114 | snprintf(buf, sizeof(size),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
115 | "mediatek/BT_RAM_CODE_MT%04x_1a_%x_hdr.bin",
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
116 | dev_id & 0xffff, (fw_ver & 0xff) + 1);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +115 drivers/bluetooth/btmtk.c
105
106 void btmtk_fw_get_filename(char *buf, size_t size, u32 dev_id, u32 fw_ver,
107 u32 fw_flavor)
108 {
109 if (dev_id == 0x7925)
110 snprintf(buf, size,
111 "mediatek/mt%04x/BT_RAM_CODE_MT%04x_1_%x_hdr.bin",
112 dev_id & 0xffff, dev_id & 0xffff, (fw_ver & 0xff) + 1);
113 else if (dev_id == 0x7961 && fw_flavor)
114 snprintf(buf, sizeof(size),
> 115 "mediatek/BT_RAM_CODE_MT%04x_1a_%x_hdr.bin",
116 dev_id & 0xffff, (fw_ver & 0xff) + 1);
117 else
118 snprintf(buf, size,
119 "mediatek/BT_RAM_CODE_MT%04x_1_%x_hdr.bin",
120 dev_id & 0xffff, (fw_ver & 0xff) + 1);
121 }
122 EXPORT_SYMBOL_GPL(btmtk_fw_get_filename);
123
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 1/5] Bluetooth: btmtk: add the function to get the fw name
[not found] <965cd14922aea67e2750ff2c2ecad773f8ba485a.1715109394.git.sean.wang@kernel.org>
2024-05-08 7:12 ` [PATCH v4 1/5] Bluetooth: btmtk: add the function to get the fw name kernel test robot
@ 2024-05-08 11:22 ` kernel test robot
1 sibling, 0 replies; 4+ messages in thread
From: kernel test robot @ 2024-05-08 11:22 UTC (permalink / raw)
To: sean.wang, marcel, johan.hedberg, luiz.dentz
Cc: llvm, oe-kbuild-all, linux-bluetooth, linux-mediatek,
linux-kernel, Sean Wang
Hi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bluetooth/master]
[also build test WARNING on bluetooth-next/master linus/master v6.9-rc7 next-20240508]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/sean-wang-kernel-org/Bluetooth-btmtk-apply-the-common-btmtk_fw_get_filename/20240508-032333
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link: https://lore.kernel.org/r/965cd14922aea67e2750ff2c2ecad773f8ba485a.1715109394.git.sean.wang%40kernel.org
patch subject: [PATCH v4 1/5] Bluetooth: btmtk: add the function to get the fw name
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20240508/202405081828.e6IMNKPn-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 0ab4458df0688955620b72cc2c72a32dffad3615)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240508/202405081828.e6IMNKPn-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405081828.e6IMNKPn-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/bluetooth/btmtk.c:8:
In file included from include/net/bluetooth/bluetooth.h:30:
In file included from include/net/sock.h:38:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
547 | val = __raw_readb(PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
560 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
| ^
In file included from drivers/bluetooth/btmtk.c:8:
In file included from include/net/bluetooth/bluetooth.h:30:
In file included from include/net/sock.h:38:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
573 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
| ^
In file included from drivers/bluetooth/btmtk.c:8:
In file included from include/net/bluetooth/bluetooth.h:30:
In file included from include/net/sock.h:38:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
584 | __raw_writeb(value, PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
594 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
604 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
In file included from drivers/bluetooth/btmtk.c:8:
In file included from include/net/bluetooth/bluetooth.h:30:
In file included from include/net/sock.h:46:
In file included from include/linux/netdevice.h:38:
In file included from include/net/net_namespace.h:43:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:10:
In file included from include/linux/mm.h:2210:
include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
>> drivers/bluetooth/btmtk.c:114:3: warning: 'snprintf' will always be truncated; specified size is 4, but format string expands to at least 41 [-Wformat-truncation]
114 | snprintf(buf, sizeof(size),
| ^
8 warnings generated.
vim +/snprintf +114 drivers/bluetooth/btmtk.c
105
106 void btmtk_fw_get_filename(char *buf, size_t size, u32 dev_id, u32 fw_ver,
107 u32 fw_flavor)
108 {
109 if (dev_id == 0x7925)
110 snprintf(buf, size,
111 "mediatek/mt%04x/BT_RAM_CODE_MT%04x_1_%x_hdr.bin",
112 dev_id & 0xffff, dev_id & 0xffff, (fw_ver & 0xff) + 1);
113 else if (dev_id == 0x7961 && fw_flavor)
> 114 snprintf(buf, sizeof(size),
115 "mediatek/BT_RAM_CODE_MT%04x_1a_%x_hdr.bin",
116 dev_id & 0xffff, (fw_ver & 0xff) + 1);
117 else
118 snprintf(buf, size,
119 "mediatek/BT_RAM_CODE_MT%04x_1_%x_hdr.bin",
120 dev_id & 0xffff, (fw_ver & 0xff) + 1);
121 }
122 EXPORT_SYMBOL_GPL(btmtk_fw_get_filename);
123
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 1/5] Bluetooth: btmtk: add the function to get the fw name
2024-05-08 7:12 ` [PATCH v4 1/5] Bluetooth: btmtk: add the function to get the fw name kernel test robot
@ 2024-05-08 14:37 ` Luiz Augusto von Dentz
2024-05-08 20:38 ` Sean Wang
0 siblings, 1 reply; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2024-05-08 14:37 UTC (permalink / raw)
To: kernel test robot
Cc: sean.wang, marcel, johan.hedberg, oe-kbuild-all, linux-bluetooth,
linux-mediatek, linux-kernel, Sean Wang
Hi Sean,
On Wed, May 8, 2024 at 3:13 AM kernel test robot <lkp@intel.com> wrote:
>
> Hi,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on bluetooth/master]
> [also build test WARNING on bluetooth-next/master linus/master v6.9-rc7 next-20240507]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/sean-wang-kernel-org/Bluetooth-btmtk-apply-the-common-btmtk_fw_get_filename/20240508-032333
> base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
> patch link: https://lore.kernel.org/r/965cd14922aea67e2750ff2c2ecad773f8ba485a.1715109394.git.sean.wang%40kernel.org
> patch subject: [PATCH v4 1/5] Bluetooth: btmtk: add the function to get the fw name
> config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240508/202405081456.v2MvcQ0P-lkp@intel.com/config)
> compiler: aarch64-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240508/202405081456.v2MvcQ0P-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202405081456.v2MvcQ0P-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> drivers/bluetooth/btmtk.c: In function 'btmtk_fw_get_filename':
> >> drivers/bluetooth/btmtk.c:115:35: warning: 'mediatek/BT_RAM_CODE_MT' directive output truncated writing 23 bytes into a region of size 8 [-Wformat-truncation=]
> 115 | "mediatek/BT_RAM_CODE_MT%04x_1a_%x_hdr.bin",
> | ~~~~~~~~^~~~~~~~~~~~~~~
> drivers/bluetooth/btmtk.c:115:26: note: directive argument in the range [1, 256]
> 115 | "mediatek/BT_RAM_CODE_MT%04x_1a_%x_hdr.bin",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/bluetooth/btmtk.c:114:17: note: 'snprintf' output between 41 and 43 bytes into a destination of size 8
> 114 | snprintf(buf, sizeof(size),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> 115 | "mediatek/BT_RAM_CODE_MT%04x_1a_%x_hdr.bin",
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 116 | dev_id & 0xffff, (fw_ver & 0xff) + 1);
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
>
> vim +115 drivers/bluetooth/btmtk.c
>
> 105
> 106 void btmtk_fw_get_filename(char *buf, size_t size, u32 dev_id, u32 fw_ver,
> 107 u32 fw_flavor)
> 108 {
> 109 if (dev_id == 0x7925)
> 110 snprintf(buf, size,
> 111 "mediatek/mt%04x/BT_RAM_CODE_MT%04x_1_%x_hdr.bin",
> 112 dev_id & 0xffff, dev_id & 0xffff, (fw_ver & 0xff) + 1);
> 113 else if (dev_id == 0x7961 && fw_flavor)
> 114 snprintf(buf, sizeof(size),
> > 115 "mediatek/BT_RAM_CODE_MT%04x_1a_%x_hdr.bin",
> 116 dev_id & 0xffff, (fw_ver & 0xff) + 1);
> 117 else
> 118 snprintf(buf, size,
> 119 "mediatek/BT_RAM_CODE_MT%04x_1_%x_hdr.bin",
> 120 dev_id & 0xffff, (fw_ver & 0xff) + 1);
> 121 }
> 122 EXPORT_SYMBOL_GPL(btmtk_fw_get_filename);
> 123
Could you please fix the above?
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 1/5] Bluetooth: btmtk: add the function to get the fw name
2024-05-08 14:37 ` Luiz Augusto von Dentz
@ 2024-05-08 20:38 ` Sean Wang
0 siblings, 0 replies; 4+ messages in thread
From: Sean Wang @ 2024-05-08 20:38 UTC (permalink / raw)
To: Luiz Augusto von Dentz
Cc: kernel test robot, marcel, johan.hedberg, oe-kbuild-all,
linux-bluetooth, linux-mediatek, linux-kernel, Sean Wang
Hi,
On Wed, May 8, 2024 at 7:37 AM Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> Hi Sean,
>
> On Wed, May 8, 2024 at 3:13 AM kernel test robot <lkp@intel.com> wrote:
> >
> > Hi,
> >
> > kernel test robot noticed the following build warnings:
> >
> > [auto build test WARNING on bluetooth/master]
> > [also build test WARNING on bluetooth-next/master linus/master v6.9-rc7 next-20240507]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> >
> > url: https://github.com/intel-lab-lkp/linux/commits/sean-wang-kernel-org/Bluetooth-btmtk-apply-the-common-btmtk_fw_get_filename/20240508-032333
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
> > patch link: https://lore.kernel.org/r/965cd14922aea67e2750ff2c2ecad773f8ba485a.1715109394.git.sean.wang%40kernel.org
> > patch subject: [PATCH v4 1/5] Bluetooth: btmtk: add the function to get the fw name
> > config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240508/202405081456.v2MvcQ0P-lkp@intel.com/config)
> > compiler: aarch64-linux-gcc (GCC) 13.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240508/202405081456.v2MvcQ0P-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202405081456.v2MvcQ0P-lkp@intel.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> > drivers/bluetooth/btmtk.c: In function 'btmtk_fw_get_filename':
> > >> drivers/bluetooth/btmtk.c:115:35: warning: 'mediatek/BT_RAM_CODE_MT' directive output truncated writing 23 bytes into a region of size 8 [-Wformat-truncation=]
> > 115 | "mediatek/BT_RAM_CODE_MT%04x_1a_%x_hdr.bin",
> > | ~~~~~~~~^~~~~~~~~~~~~~~
> > drivers/bluetooth/btmtk.c:115:26: note: directive argument in the range [1, 256]
> > 115 | "mediatek/BT_RAM_CODE_MT%04x_1a_%x_hdr.bin",
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/bluetooth/btmtk.c:114:17: note: 'snprintf' output between 41 and 43 bytes into a destination of size 8
> > 114 | snprintf(buf, sizeof(size),
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 115 | "mediatek/BT_RAM_CODE_MT%04x_1a_%x_hdr.bin",
> > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 116 | dev_id & 0xffff, (fw_ver & 0xff) + 1);
> > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> >
> > vim +115 drivers/bluetooth/btmtk.c
> >
> > 105
> > 106 void btmtk_fw_get_filename(char *buf, size_t size, u32 dev_id, u32 fw_ver,
> > 107 u32 fw_flavor)
> > 108 {
> > 109 if (dev_id == 0x7925)
> > 110 snprintf(buf, size,
> > 111 "mediatek/mt%04x/BT_RAM_CODE_MT%04x_1_%x_hdr.bin",
> > 112 dev_id & 0xffff, dev_id & 0xffff, (fw_ver & 0xff) + 1);
> > 113 else if (dev_id == 0x7961 && fw_flavor)
> > 114 snprintf(buf, sizeof(size),
> > > 115 "mediatek/BT_RAM_CODE_MT%04x_1a_%x_hdr.bin",
> > 116 dev_id & 0xffff, (fw_ver & 0xff) + 1);
> > 117 else
> > 118 snprintf(buf, size,
> > 119 "mediatek/BT_RAM_CODE_MT%04x_1_%x_hdr.bin",
> > 120 dev_id & 0xffff, (fw_ver & 0xff) + 1);
> > 121 }
> > 122 EXPORT_SYMBOL_GPL(btmtk_fw_get_filename);
> > 123
>
> Could you please fix the above?
No problem, I'll take care of it and send it over later.
Sean
>
> --
> Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-08 20:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <965cd14922aea67e2750ff2c2ecad773f8ba485a.1715109394.git.sean.wang@kernel.org>
2024-05-08 7:12 ` [PATCH v4 1/5] Bluetooth: btmtk: add the function to get the fw name kernel test robot
2024-05-08 14:37 ` Luiz Augusto von Dentz
2024-05-08 20:38 ` Sean Wang
2024-05-08 11:22 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).