oe-kbuild-all.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [conor:qwip 12/15] drivers/gpio/gpio-mpfs.c:209:22: warning: unused variable 'irq'
@ 2024-05-09 23:40 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-05-09 23:40 UTC (permalink / raw)
  To: Conor Dooley; +Cc: oe-kbuild-all

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git qwip
head:   520f2563214599bc3abdd1aa6f127f67e084e65f
commit: 92e2da2f671866ae934e08c8e1e31e50d77729b7 [12/15] gpio: mpfs: pass gpio line number as irq data
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240510/202405100710.NLaOfsa7-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240510/202405100710.NLaOfsa7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405100710.NLaOfsa7-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/gpio/gpio-mpfs.c: In function 'mpfs_gpio_irq_handler':
>> drivers/gpio/gpio-mpfs.c:209:22: warning: unused variable 'irq' [-Wunused-variable]
     209 |         unsigned int irq;
         |                      ^~~
>> drivers/gpio/gpio-mpfs.c:207:26: warning: unused variable 'child_desc' [-Wunused-variable]
     207 |         struct irq_desc *child_desc;
         |                          ^~~~~~~~~~


vim +/irq +209 drivers/gpio/gpio-mpfs.c

   199	
   200	static void mpfs_gpio_irq_handler(struct irq_desc *desc)
   201	{
   202		struct irq_chip *irqchip = irq_desc_get_chip(desc);
   203		void *handler_data = irq_desc_get_handler_data(desc);
   204		struct gpio_chip *gc = irq_data_get_irq_chip_data(&desc->irq_data);
   205		struct mpfs_gpio_chip *mpfs_gpio = gpiochip_get_data(gc);
   206		u8 gpio_index = *((u8 *)handler_data);
 > 207		struct irq_desc *child_desc;
   208		unsigned long status;
 > 209		unsigned int irq;
   210	
   211		/*
   212		 * Since the parent may be a muxed/"non-direct" interrupt, this
   213		 * interrupt may not be for us.
   214		 */
   215		status = readl(mpfs_gpio->base + MPFS_IRQ_REG);
   216		if (!(status & BIT(gpio_index)))
   217			return;
   218	
   219		chained_irq_enter(irqchip, desc);
   220	
   221		generic_handle_irq(irq_find_mapping(mpfs_gpio->gc.irq.domain, gpio_index));
   222		mpfs_gpio_assign_bit(mpfs_gpio->base + MPFS_IRQ_REG, gpio_index, 1);
   223	
   224		chained_irq_exit(irqchip, desc);
   225	}
   226	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-05-09 23:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-09 23:40 [conor:qwip 12/15] drivers/gpio/gpio-mpfs.c:209:22: warning: unused variable 'irq' kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).