[PATCH v1] ARM: dts: aspeed: yosemite4: add I3C config in DTS

[PATCH v1] ARM: dts: aspeed: yosemite4: add I3C config in DTS

[Delphine CC Chiu]

Set I3C config in yosemite4 DTS.

Test plan:
Tested with aspeed I3C patches and I3C hub driver.

Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
---
 .../aspeed/aspeed-bmc-facebook-yosemite4.dts  | 86 +++++++++++++++++++
 1 file changed, 86 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
index 64075cc41d92..6a30c424d745 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
@@ -595,6 +595,92 @@ i2c-mux@72 {
 	};
 };
 
+&i3c0 {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i3c1_default>;
+	i3c-pp-scl-hi-period-ns = <40>;
+	i3c-pp-scl-lo-period-ns = <40>;
+	i3c-od-scl-hi-period-ns = <380>;
+	i3c-od-scl-lo-period-ns = <620>;
+	sda-tx-hold-ns = <10>;
+
+	mctp-controller;
+	hub@0x70 {
+		reg = <0x70 0x3c0 0x00700000>;
+		cp0-ldo-en = "enabled";
+		cp1-ldo-en = "enabled";
+		cp0-ldo-volt = "1.2V";
+		cp1-ldo-volt = "1.2V";
+		tp0145-ldo-en = "enabled";
+		tp2367-ldo-en = "enabled";
+		tp0145-ldo-volt = "1.2V";
+		tp2367-ldo-volt = "1.2V";
+		tp0145-pullup = "2k";
+		tp2367-pullup = "2k";
+
+		target-port@0 {
+			mode = "i3c";
+			pullup = "enabled";
+		};
+		target-port@1 {
+			mode = "i3c";
+			pullup = "enabled";
+		};
+		target-port@2 {
+			mode = "i3c";
+			pullup = "enabled";
+		};
+		target-port@3 {
+			mode = "i3c";
+			pullup = "enabled";
+		};
+	};
+};
+
+&i3c1 {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i3c2_default>;
+	i3c-pp-scl-hi-period-ns = <40>;
+	i3c-pp-scl-lo-period-ns = <40>;
+	i3c-od-scl-hi-period-ns = <380>;
+	i3c-od-scl-lo-period-ns = <620>;
+	sda-tx-hold-ns = <10>;
+
+	mctp-controller;
+	hub@0x70 {
+		reg = <0x70 0x3c0 0x00700000>;
+		cp0-ldo-en = "enabled";
+		cp1-ldo-en = "enabled";
+		cp0-ldo-volt = "1.2V";
+		cp1-ldo-volt = "1.2V";
+		tp0145-ldo-en = "enabled";
+		tp2367-ldo-en = "enabled";
+		tp0145-ldo-volt = "1.2V";
+		tp2367-ldo-volt = "1.2V";
+		tp0145-pullup = "2k";
+		tp2367-pullup = "2k";
+
+		target-port@0 {
+			mode = "i3c";
+			pullup = "enabled";
+		};
+		target-port@1 {
+			mode = "i3c";
+			pullup = "enabled";
+		};
+		target-port@2 {
+			mode = "i3c";
+			pullup = "enabled";
+		};
+		target-port@3 {
+			mode = "i3c";
+			pullup = "enabled";
+		};
+	};
+};
+
 &adc0 {
 	ref_voltage = <2500>;
 	status = "okay";
-- 
2.25.1

Re: [PATCH v1] ARM: dts: aspeed: yosemite4: add I3C config in DTS

[Krzysztof Kozlowski]

On 06/05/2024 13:33, Delphine CC Chiu wrote:
> Set I3C config in yosemite4 DTS.
> 
> Test plan:
> Tested with aspeed I3C patches and I3C hub driver.
> 
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
> ---
>  .../aspeed/aspeed-bmc-facebook-yosemite4.dts  | 86 +++++++++++++++++++
>  1 file changed, 86 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> index 64075cc41d92..6a30c424d745 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> @@ -595,6 +595,92 @@ i2c-mux@72 {
>  	};
>  };
>  
> +&i3c0 {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i3c1_default>;
> +	i3c-pp-scl-hi-period-ns = <40>;
> +	i3c-pp-scl-lo-period-ns = <40>;
> +	i3c-od-scl-hi-period-ns = <380>;
> +	i3c-od-scl-lo-period-ns = <620>;
> +	sda-tx-hold-ns = <10>;
> +
> +	mctp-controller;
> +	hub@0x70 {

That's not a valid unit address.


> +		reg = <0x70 0x3c0 0x00700000>;
> +		cp0-ldo-en = "enabled";
> +		cp1-ldo-en = "enabled";
> +		cp0-ldo-volt = "1.2V";
> +		cp1-ldo-volt = "1.2V";
> +		tp0145-ldo-en = "enabled";
> +		tp2367-ldo-en = "enabled";
> +		tp0145-ldo-volt = "1.2V";
> +		tp2367-ldo-volt = "1.2V";
> +		tp0145-pullup = "2k";
> +		tp2367-pullup = "2k";

Where are bindings for all this?



Best regards,
Krzysztof

Re: [PATCH v1] ARM: dts: aspeed: yosemite4: add I3C config in DTS

[kernel test robot]

Hi Delphine,

kernel test robot noticed the following build errors:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v6.9-rc7 next-20240507]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Delphine-CC-Chiu/ARM-dts-aspeed-yosemite4-add-I3C-config-in-DTS/20240506-193458
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20240506113306.1283179-1-Delphine_CC_Chiu%40wiwynn.com
patch subject: [PATCH v1] ARM: dts: aspeed: yosemite4: add I3C config in DTS
config: arm-multi_v5_defconfig (https://download.01.org/0day-ci/archive/20240507/202405072003.qTcMKOm3-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240507/202405072003.qTcMKOm3-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405072003.qTcMKOm3-lkp@intel.com/

All errors (new ones prefixed by >>):

>> Error: arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:598.1-6 Label or path i3c0 not found
>> Error: arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:641.1-6 Label or path i3c1 not found
   FATAL ERROR: Syntax error parsing input tree

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

RE: [PATCH v1] ARM: dts: aspeed: yosemite4: add I3C config in DTS

[Delphine_CC_Chiu/WYHQ/Wiwynn]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Monday, May 6, 2024 11:38 PM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
> patrick@stwcx.xyz; joel@jms.id.au; openbmc@lists.ozlabs.org; Rob Herring
> <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley
> <conor+dt@kernel.org>; Andrew Jeffery <andrew@codeconstruct.com.au>
> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: add I3C config in DTS
> 
>   Security Reminder: Please be aware that this email is sent by an external
> sender.
> 
> On 06/05/2024 13:33, Delphine CC Chiu wrote:
> > Set I3C config in yosemite4 DTS.
> >
> > Test plan:
> > Tested with aspeed I3C patches and I3C hub driver.
> >
> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
> > ---
> >  .../aspeed/aspeed-bmc-facebook-yosemite4.dts  | 86
> +++++++++++++++++++
> >  1 file changed, 86 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> > index 64075cc41d92..6a30c424d745 100644
> > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> > @@ -595,6 +595,92 @@ i2c-mux@72 {
> >       };
> >  };
> >
> > +&i3c0 {
> > +     status = "okay";
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_i3c1_default>;
> > +     i3c-pp-scl-hi-period-ns = <40>;
> > +     i3c-pp-scl-lo-period-ns = <40>;
> > +     i3c-od-scl-hi-period-ns = <380>;
> > +     i3c-od-scl-lo-period-ns = <620>;
> > +     sda-tx-hold-ns = <10>;
> > +
> > +     mctp-controller;
> > +     hub@0x70 {
> 
> That's not a valid unit address.
> 
> 
Will update in the next patch. Thanks.

> > +             reg = <0x70 0x3c0 0x00700000>;
> > +             cp0-ldo-en = "enabled";
> > +             cp1-ldo-en = "enabled";
> > +             cp0-ldo-volt = "1.2V";
> > +             cp1-ldo-volt = "1.2V";
> > +             tp0145-ldo-en = "enabled";
> > +             tp2367-ldo-en = "enabled";
> > +             tp0145-ldo-volt = "1.2V";
> > +             tp2367-ldo-volt = "1.2V";
> > +             tp0145-pullup = "2k";
> > +             tp2367-pullup = "2k";
> 
> Where are bindings for all this?
> 
The bindings are from the following binding document.
https://patchwork.kernel.org/project/linux-i3c/patch/20240217131412.4145506-1-steven.niu.uj@renesas.com/