* [PATCH v1] gpio: nuvoton: Fix sgpio irq handle error
@ 2024-04-09 9:14 Jim Liu
2024-04-09 13:11 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Jim Liu @ 2024-04-09 9:14 UTC (permalink / raw)
To: JJLIU0, KWLIU, linus.walleij, brgl, jim.t90615
Cc: linux-gpio, openbmc, linux-kernel
Remove irq_find_mapping and use generic_handle_domain_irq
Signed-off-by: Jim Liu <JJLIU0@nuvoton.com>
---
drivers/gpio/gpio-npcm-sgpio.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpio/gpio-npcm-sgpio.c b/drivers/gpio/gpio-npcm-sgpio.c
index d31788b43abc..136838c25756 100644
--- a/drivers/gpio/gpio-npcm-sgpio.c
+++ b/drivers/gpio/gpio-npcm-sgpio.c
@@ -443,11 +443,9 @@ static void npcm_sgpio_irq_handler(struct irq_desc *desc)
const struct npcm_sgpio_bank *bank = &npcm_sgpio_banks[i];
reg = ioread8(bank_reg(gpio, bank, EVENT_STS));
- for_each_set_bit(j, ®, 8) {
- girq = irq_find_mapping(gc->irq.domain,
- i * 8 + gpio->nout_sgpio + j);
- generic_handle_domain_irq(gc->irq.domain, girq);
- }
+ for_each_set_bit(j, ®, 8)
+ generic_handle_domain_irq(gc->irq.domain,
+ i * 8 + gpio->nout_sgpio + j);
}
chained_irq_exit(ic, desc);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] gpio: nuvoton: Fix sgpio irq handle error
2024-04-09 9:14 [PATCH v1] gpio: nuvoton: Fix sgpio irq handle error Jim Liu
@ 2024-04-09 13:11 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2024-04-09 13:11 UTC (permalink / raw)
To: Jim Liu
Cc: KWLIU, linus.walleij, JJLIU0, linux-kernel, openbmc, linux-gpio, brgl
On Tue, Apr 09, 2024 at 05:14:19PM +0800, Jim Liu wrote:
> Remove irq_find_mapping and use generic_handle_domain_irq
>
The subject says that it's a fix, but the commit message doesn't tell
us what the problem is. And there is no fixes tag.
> Signed-off-by: Jim Liu <JJLIU0@nuvoton.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-09 13:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-09 9:14 [PATCH v1] gpio: nuvoton: Fix sgpio irq handle error Jim Liu
2024-04-09 13:11 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).