From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Duje Mihanović" <duje.mihanovic@skole.hr>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
~postmarketos/upstreaming@lists.sr.ht
Cc: phone-devel@vger.kernel.org, afaerber@suse.com
Subject: Re: [PATCH v2 4/9] dt-bindings: clock: Add Marvell PXA1908 clock bindings
Date: Mon, 31 Jul 2023 09:08:07 +0200 [thread overview]
Message-ID: <e3d692d9-82a3-22d0-7fa0-4e89876ef8f4@linaro.org> (raw)
In-Reply-To: <2897221.e9J7NaK4W3@radijator>
On 30/07/2023 23:18, Duje Mihanović wrote:
> On Friday, July 28, 2023 9:18:44 AM CEST Krzysztof Kozlowski wrote:
>>> +/* axi (apmu) peripherals */
>>> +#define PXA1908_CLK_CCIC1 9
>>> +#define PXA1908_CLK_ISP 14
>>
>> Why do you have gaps between IDs? The clock IDs are supposed to be
>> continuous, otherwise it is not an ID.
>
> Similarly to the PXA1928 clock driver, each clock's ID is its register offset
> divided by 4. Should I use continuous IDs and put the register offsets in the
> clock driver instead?
Either that or drop the bindings file, because otherwise what is the
point of having it in the bindings?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-31 7:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 16:28 [PATCH v2 0/9] Initial Marvell PXA1908 support Duje Mihanović
2023-07-27 16:28 ` [PATCH v2 1/9] gpio: pxa: disable pinctrl calls for MMP_GPIO Duje Mihanović
2023-07-27 16:39 ` Andy Shevchenko
2023-07-27 16:29 ` [PATCH v2 2/9] gpio: pxa: use dynamic allocation of base Duje Mihanović
2023-07-27 16:40 ` Andy Shevchenko
2023-07-30 21:18 ` Duje Mihanović
2023-08-07 13:31 ` Linus Walleij
2023-08-07 13:49 ` Andy Shevchenko
2023-08-07 15:19 ` Duje Mihanović
2023-07-27 16:29 ` [PATCH v2 3/9] clk: mmp: Switch to use struct u32_fract instead of custom one Duje Mihanović
2023-07-27 16:42 ` Andy Shevchenko
2023-07-27 16:29 ` [PATCH v2 4/9] dt-bindings: clock: Add Marvell PXA1908 clock bindings Duje Mihanović
2023-07-28 7:18 ` Krzysztof Kozlowski
2023-07-30 21:18 ` Duje Mihanović
2023-07-31 7:08 ` Krzysztof Kozlowski [this message]
2023-07-27 16:29 ` [PATCH v2 5/9] clk: mmp: Add Marvell PXA1908 clock driver Duje Mihanović
2023-07-27 16:29 ` [PATCH v2 6/9] dt-bindings: marvell: Document PXA1908 SoC Duje Mihanović
2023-07-28 7:19 ` Krzysztof Kozlowski
2023-07-30 21:18 ` Duje Mihanović
2023-07-31 7:09 ` Krzysztof Kozlowski
2023-07-27 16:29 ` [PATCH v2 7/9] arm64: Kconfig.platforms: Add config for Marvell PXA1908 platform Duje Mihanović
2023-07-27 16:29 ` [PATCH v2 8/9] arm64: dts: Add DTS for Marvell PXA1908 and samsung,coreprimevelte Duje Mihanović
2023-07-27 16:29 ` [PATCH v2 9/9] MAINTAINERS: add myself as Marvell PXA1908 maintainer Duje Mihanović
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3d692d9-82a3-22d0-7fa0-4e89876ef8f4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=afaerber@suse.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=duje.mihanovic@skole.hr \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).