From: Lyndon Sanche <lsanche@lyndeno.ca>
To: "Shen, Yijun" <Yijun.Shen@dell.com>
Cc: "Mario Limonciello" <mario.limonciello@amd.com>,
"Pali Rohár" <pali@kernel.org>, "Armin Wolf" <W_Armin@gmx.de>,
srinivas.pandruvada@linux.intel.com,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"kernel test robot" <lkp@intel.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Vegard Nossum" <vegard.nossum@oracle.com>,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
"Dell Client Kernel" <Dell.Client.Kernel@dell.com>
Subject: Re: [PATCH v5] platform/x86: dell-laptop: Implement platform_profile
Date: Fri, 10 May 2024 19:49:09 -0600 [thread overview]
Message-ID: <X1TADS.8PTII3LXSHHX1@lyndeno.ca> (raw)
In-Reply-To: <aaa1ebb5-3e0a-40ef-b53d-d8adc1589085@app.fastmail.com>
On Thu, May 9 2024 at 09:10:51 AM -06:00:00, Lyndon Sanche
<lsanche@lyndeno.ca> wrote:
> On Wed, May 8, 2024, at 8:24 AM, Shen, Yijun wrote:
>> Hi Lyndon,
>>
>> Thanks for working on this patch.
>>
>>
>> Dell side has an initial testing with this patch on some laptops,
>> it
>> looks good. While changing the platform profile:
>> 1. The corresponding USTT option in BIOS will be changed.
>> 2. thermald will not be impacted. The related PSVT and ITMT will be
>> loaded.
>> Some Dell DTs does not have the USTT, Dell'll have a check if
>> nothing
>> is broken.
>>
>> Additional, with this patch, follow behavior is found:
>> 1. For example, the platform profile is quiet.
>> 2. Reboot the system and change the USTT to performance.
>> 3. Boot to desktop, the platform profile is "quiet", the USTT will
>> be
>> changed back to "quiet".
>> This looks like not a proper user experience. The platform profile
>> should honor the BIOS setting, aka, the platform profile should be
>> switched to "performance".
>
> Hello:
>
> Thank you for your email. This is definitely undesirable behaviour, I
> will have a look at the code to see why this is happening. Does it
> always revert to quiet on boot, or always the mode that you had
> switched to prior to reboot?
>
> Do you happen to have power-profiles-daemon or something similar
> running? My understanding is it remembers profiles across reboots,
> this could potentially also revert the profile back to what it was.
> See this release for details:
> https://gitlab.freedesktop.org/upower/power-profiles-daemon/-/releases/0.9.0
>
> I will assume there is a bug in my code at this point. I will test
> with and without ppd running on my system to see if it changes across
> reboots.
>
> Are USTT settings exposed in your BIOS configuration menu? On my
> laptop they are not and I have to use smbios-thermal-ctl.
>
> Thank you,
>
> Lyndon
Hi Yijun:
I tested this on my computer (XPS 9560). I do not have access to the
USTT settings in the BIOS screen so to substitute that, I booted
without the patch and set the USTT manually using smbios-thermal-ctl.
Here are my findings:
Scenario #1: Without power-profiles-daemon (ppd) running
1. Boot with patch, set platform_profile to quiet
2. Boot without patch applied (no platform_profile)
- smbios-thermal-ctl confirms USTT is set to quiet
- use smbios-thermal-ctl to set USTT to performance
- confirm set to performance
3. Boot with patch again
- platform_profile is set to performance
Scenario #2: With ppd running
1. Boot with patch, set platform_profile to performance with ppd
- Confirm platform_profile is performance
2. Boot without patch applied (no platform_profile)
- smbios-thermal-ctl confirms USTT is set to performance
- ppd reverts to balanced (only controlling intel_pstate in this case)
- use smbios-thermal-ctl to set USTT to quiet
- confirm set to quiet
3. Boot with patch again
- platform_profile and ppd is set to performance
In my case, the setting in the smbios is honored if it was switched
with another method. When using a userspace program that manipulates
the platform_profile, the program seems to remember the previous state
and switch to that.
So I do not think there is a bug in this patch related to this issue,
at least in my case. Please let me know if you have any questions.
Thanks,
Lyndon
next prev parent reply other threads:[~2024-05-11 1:49 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 17:27 [PATCH] platform/x86: dell-laptop: Implement platform_profile Lyndon Sanche
2024-04-25 20:07 ` Mario Limonciello
2024-04-25 20:24 ` Lyndon Sanche
2024-04-25 20:28 ` Mario Limonciello
2024-04-25 21:51 ` Srinivas Pandruvada
2024-04-26 0:38 ` Lyndon Sanche
2024-04-26 16:14 ` srinivas pandruvada
2024-04-26 18:23 ` Lyndon Sanche
2024-04-26 18:24 ` srinivas pandruvada
2024-04-25 20:12 ` Pali Rohár
2024-04-25 20:27 ` Lyndon Sanche
2024-04-25 20:31 ` Pali Rohár
2024-04-25 21:07 ` Armin Wolf
2024-04-26 0:54 ` Lyndon Sanche
2024-04-26 2:04 ` [PATCH v2] " Lyndon Sanche
2024-04-26 9:23 ` Ilpo Järvinen
2024-04-26 18:05 ` Lyndon Sanche
2024-05-13 20:09 ` kernel test robot
2024-04-26 6:57 ` [PATCH] " Ilpo Järvinen
2024-04-29 16:48 ` [PATCH v3] " Lyndon Sanche
2024-04-29 17:45 ` Mario Limonciello
2024-04-29 17:51 ` Mario Limonciello
2024-04-29 21:25 ` Lyndon Sanche
2024-04-29 21:21 ` Lyndon Sanche
2024-04-30 10:31 ` Ilpo Järvinen
2024-04-30 18:38 ` Lyndon Sanche
2024-04-30 15:36 ` kernel test robot
2024-05-01 8:16 ` kernel test robot
2024-05-01 16:35 ` kernel test robot
2024-05-01 17:07 ` kernel test robot
2024-05-01 1:14 ` [PATCH v4] " Lyndon Sanche
2024-05-01 1:36 ` Pali Rohár
2024-05-01 1:42 ` Lyndon Sanche
2024-05-01 21:58 ` [PATCH v5] " Lyndon Sanche
2024-05-03 10:19 ` kernel test robot
2024-05-04 1:03 ` Lyndon Sanche
2024-05-06 10:18 ` Hans de Goede
2024-05-07 16:00 ` Lyndon Sanche
2024-05-03 21:19 ` Armin Wolf
2024-05-04 0:59 ` Lyndon Sanche
2024-05-08 14:24 ` Shen, Yijun
2024-05-08 15:53 ` Mario Limonciello
2024-05-11 15:05 ` Shen, Yijun
2024-05-11 15:12 ` Limonciello, Mario
2024-05-11 15:56 ` Shen, Yijun
2024-05-12 17:53 ` Armin Wolf
2024-05-12 17:58 ` Limonciello, Mario
2024-05-12 18:47 ` Armin Wolf
2024-05-12 22:14 ` Limonciello, Mario
2024-05-11 16:02 ` Lyndon Sanche
2024-05-09 15:10 ` Lyndon Sanche
2024-05-11 1:49 ` Lyndon Sanche [this message]
2024-05-11 15:22 ` Shen, Yijun
2024-05-11 15:54 ` Lyndon Sanche
2024-05-11 16:12 ` Shen, Yijun
2024-05-11 2:36 ` [PATCH v6 0/2] " Lyndon Sanche
2024-05-11 2:36 ` [PATCH v6 1/2] platform/x86: dell-smbios: Add helper for checking supported commands Lyndon Sanche
2024-05-11 15:13 ` Limonciello, Mario
2024-05-12 18:00 ` Armin Wolf
2024-05-11 2:36 ` [PATCH v6 2/2] platform/x86: dell-laptop: Implement platform_profile Lyndon Sanche
2024-05-11 15:16 ` Limonciello, Mario
2024-05-11 15:59 ` Lyndon Sanche
[not found] ` <48JCDS.E4RT1F9DTKFU1@lyndeno.ca>
2024-05-12 1:43 ` Limonciello, Mario
2024-05-12 15:25 ` Hans de Goede
2024-05-12 0:14 ` Lyndon Sanche
2024-05-12 18:05 ` Armin Wolf
2024-05-15 17:06 ` Lyndon Sanche
2024-05-17 22:42 ` [PATCH v7 0/3] platform/x86: dell: " Lyndon Sanche
2024-05-17 22:42 ` [PATCH v7 1/3] platform/x86: dell-smbios: Add helper for checking supported class Lyndon Sanche
2024-05-17 22:42 ` [PATCH v7 2/3] platform/x86: dell-smbios: Move request functions for reuse Lyndon Sanche
2024-05-17 22:42 ` [PATCH v7 3/3] platform/x86: dell-pc: Implement platform_profile Lyndon Sanche
2024-05-21 20:50 ` [PATCH v7 0/3] platform/x86: dell: " Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X1TADS.8PTII3LXSHHX1@lyndeno.ca \
--to=lsanche@lyndeno.ca \
--cc=Dell.Client.Kernel@dell.com \
--cc=W_Armin@gmx.de \
--cc=Yijun.Shen@dell.com \
--cc=corbet@lwn.net \
--cc=hdegoede@redhat.com \
--cc=hkallweit1@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mario.limonciello@amd.com \
--cc=mjg59@srcf.ucam.org \
--cc=pali@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).