From: "Limonciello, Mario" <mario.limonciello@amd.com>
To: Armin Wolf <W_Armin@gmx.de>, "Shen, Yijun" <Yijun.Shen@dell.com>,
Lyndon Sanche <lsanche@lyndeno.ca>
Cc: "pali@kernel.org" <pali@kernel.org>,
"srinivas.pandruvada@linux.intel.com"
<srinivas.pandruvada@linux.intel.com>,
"ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
"lkp@intel.com" <lkp@intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Jonathan Corbet <corbet@lwn.net>,
Heiner Kallweit <hkallweit1@gmail.com>,
Vegard Nossum <vegard.nossum@oracle.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dell Client Kernel <Dell.Client.Kernel@dell.com>
Subject: Re: [PATCH v5] platform/x86: dell-laptop: Implement platform_profile
Date: Sun, 12 May 2024 12:58:28 -0500 [thread overview]
Message-ID: <d38043cd-7fc2-4255-a795-23e64ee4a8c2@amd.com> (raw)
In-Reply-To: <4d8de625-9018-4926-9519-37f5a90a96e5@gmx.de>
On 5/12/2024 12:53 PM, Armin Wolf wrote:
> Am 11.05.24 um 17:56 schrieb Shen, Yijun:
>
>> Internal Use - Confidential
>>> -----Original Message-----
>>> From: Limonciello, Mario <mario.limonciello@amd.com>
>>> Sent: Saturday, May 11, 2024 11:13 PM
>>> To: Shen, Yijun <Yijun_Shen@Dell.com>; Lyndon Sanche
>>> <lsanche@lyndeno.ca>
>>> Cc: pali@kernel.org; W_Armin@gmx.de;
>>> srinivas.pandruvada@linux.intel.com; ilpo.jarvinen@linux.intel.com;
>>> lkp@intel.com; Hans de Goede <hdegoede@redhat.com>; Matthew Garrett
>>> <mjg59@srcf.ucam.org>; Jonathan Corbet <corbet@lwn.net>; Heiner Kallweit
>>> <hkallweit1@gmail.com>; Vegard Nossum <vegard.nossum@oracle.com>;
>>> platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org;
>>> Dell Client
>>> Kernel <Dell.Client.Kernel@dell.com>
>>> Subject: Re: [PATCH v5] platform/x86: dell-laptop: Implement
>>> platform_profile
>>>
>>>
>>> [EXTERNAL EMAIL]
>>>
>>>
>>>
>>> On 5/11/2024 10:05 AM, Shen, Yijun wrote:
>>>> Internal Use - Confidential
>>>>> -----Original Message-----
>>>>> From: Mario Limonciello <mario.limonciello@amd.com>
>>>>> Sent: Wednesday, May 8, 2024 11:53 PM
>>>>> To: Shen, Yijun <Yijun_Shen@Dell.com>; Lyndon Sanche
>>>>> <lsanche@lyndeno.ca>
>>>>> Cc: pali@kernel.org; W_Armin@gmx.de;
>>>>> srinivas.pandruvada@linux.intel.com; ilpo.jarvinen@linux.intel.com;
>>>>> lkp@intel.com; Hans de Goede <hdegoede@redhat.com>; Matthew
>>> Garrett
>>>>> <mjg59@srcf.ucam.org>; Jonathan Corbet <corbet@lwn.net>; Heiner
>>>>> Kallweit <hkallweit1@gmail.com>; Vegard Nossum
>>>>> <vegard.nossum@oracle.com>; platform-driver-x86@vger.kernel.org;
>>>>> linux-kernel@vger.kernel.org; Dell Client Kernel
>>>>> <Dell.Client.Kernel@dell.com>
>>>>> Subject: Re: RE: [PATCH v5] platform/x86: dell-laptop: Implement
>>>>> platform_profile
>>>>>
>>>>>
>>>>> [EXTERNAL EMAIL]
>>>>>
>>>>> On 5/8/2024 09:24, Shen, Yijun wrote:
>>>>>> Hi Lyndon,
>>>>>>
>>>>>> Thanks for working on this patch.
>>>>>>
>>>>>> Dell side has an initial testing with this patch on some laptops,
>>>>>> it looks
>>>>> good. While changing the platform profile:
>>>>>> 1. The corresponding USTT option in BIOS will be changed.
>>>>>> 2. thermald will not be impacted. The related PSVT and ITMT will be
>>> loaded.
>>>>>> Some Dell DTs does not have the USTT, Dell'll have a check if
>>>>>> nothing is
>>>>> broken.
>>>>>
>>>>> Hi Alex!
>>>>>
>>>>> Have you had a check both on both your AMD laptops and workstations
>>>>> too, or just the Intel ones? I think it would be good to make sure
>>>>> it's getting the correct experience in both cases.
>>>>>
>>>> Hi Mario,
>>>>
>>>> I've a check for this, for both laptop and workstation, the
>>>> dell_laptop
>>> module will not be loaded. So, AMD platform will not be impacted by this
>>> patch series.
>>>> Follow is one example output with workstation.
>>>> #lsmod | grep dell
>>>> dell_wmi 28672 0
>>>> dell_smbios 32768 1 dell_wmi
>>>> dcdbas 20480 1 dell_smbios
>>>> dell_wmi_descriptor 20480 2 dell_wmi,dell_smbios
>>>> sparse_keymap 12288 1 dell_wmi
>>>> ledtrig_audio 12288 3
>>>> snd_ctl_led,snd_hda_codec_generic,dell_wmi
>>>> video 73728 2 dell_wmi,nvidia_modeset
>>>> wmi 40960 5
>>> video,dell_wmi,wmi_bmof,dell_smbios,dell_wmi_descriptor
>>> Ah; right that makes sense. In that case, is dell-laptop even the
>>> right place for
>>> this patch series? I would think the same policies for the platform
>>> profile
>>> should be able to apply to desktop/workstation.
>>>
>>> The v6 of this series would block smbios-thermal-ctl from working on a
>>> workstation too.
>>>
>>>>>> Additional, with this patch, follow behavior is found:
>>>>>> 1. For example, the platform profile is quiet.
>>>>>> 2. Reboot the system and change the USTT to performance.
>>>>>> 3. Boot to desktop, the platform profile is "quiet", the USTT
>>>>>> will be
>>>>> changed back to "quiet".
>>>>>> This looks like not a proper user experience. The platform
>>>>>> profile should
>>>>> honor the BIOS setting, aka, the platform profile should be switched
>>>>> to "performance".
>>>>> I agree, this sounds like the initial profile needs to be read from
>>>>> the BIOS settings too.
>>>>>
>>>>> Furthermore I wanted to ask is there also a WMI setting that
>>>>> corresponds to this that dell-wmi-sysman offers?
>>>> Yes, Mario, you're right. This thermal setting could also be
>>>> toggled by dell-
>>> wmi-sysman.
>>>> But, for the Dell consumer AMD laptops, like Alienware, the BIOS is
>>>> another
>>> variant which is different with the workstation one.
>>>> With this variant BIOS, there is no USTT and also no dell_wmi/dell-wmi-
>>> sysman.
>>>>> I'm wondering if both should be probed in case the SMBIOS one goes
>>> away one day.
>>>> Yep, I think this is a good suggestion.
>>>>
>>> Great! Although something I wonder is if the policy when changed with
>>> dell-
>>> wmi-sysman is immediate or requires a reboot. A lot of the settings
>>> in there
>>> aren't effective until after a reboot.
>>>
>>> If this is one of them then it might not be a good idea to make it
>>> work for
>>> both.
>> Hi Mario,
>>
>> Just have a check, the check steps are:
>> 1. stop the thermald
>> 2. run the stress test
>> 3. Toggle the thermal setting between UltraPerformance and Quiet via
>> dell-wmi-sysman
>> 4. Check the CPU FAN speed
>> The system reboot is not needed, the CPU fan speed changes immediately.
>> A screen recorder here:
>> https://dell.box.com/s/p2bhd2b6cv8z5buk9eao3bosgrrp1lf9
>>
>> Thanks
>>
> Hi,
>
> i believe it should be the responsibility of the manufacturer (in this
> case Dell) that
> the thermal state remains consistent across both interfaces.
>
> I think that the official Windows utility only checks the thermal state
> reported by
> the USTT interface, so we should match this behavior.
>
> Thanks,
> Armin Wolf
>
Why? Windows also does ACPI-WMI differently than Linux. It's not as
easy to check both from a Windows utility due to that.
next prev parent reply other threads:[~2024-05-12 17:58 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 17:27 [PATCH] platform/x86: dell-laptop: Implement platform_profile Lyndon Sanche
2024-04-25 20:07 ` Mario Limonciello
2024-04-25 20:24 ` Lyndon Sanche
2024-04-25 20:28 ` Mario Limonciello
2024-04-25 21:51 ` Srinivas Pandruvada
2024-04-26 0:38 ` Lyndon Sanche
2024-04-26 16:14 ` srinivas pandruvada
2024-04-26 18:23 ` Lyndon Sanche
2024-04-26 18:24 ` srinivas pandruvada
2024-04-25 20:12 ` Pali Rohár
2024-04-25 20:27 ` Lyndon Sanche
2024-04-25 20:31 ` Pali Rohár
2024-04-25 21:07 ` Armin Wolf
2024-04-26 0:54 ` Lyndon Sanche
2024-04-26 2:04 ` [PATCH v2] " Lyndon Sanche
2024-04-26 9:23 ` Ilpo Järvinen
2024-04-26 18:05 ` Lyndon Sanche
2024-05-13 20:09 ` kernel test robot
2024-04-26 6:57 ` [PATCH] " Ilpo Järvinen
2024-04-29 16:48 ` [PATCH v3] " Lyndon Sanche
2024-04-29 17:45 ` Mario Limonciello
2024-04-29 17:51 ` Mario Limonciello
2024-04-29 21:25 ` Lyndon Sanche
2024-04-29 21:21 ` Lyndon Sanche
2024-04-30 10:31 ` Ilpo Järvinen
2024-04-30 18:38 ` Lyndon Sanche
2024-04-30 15:36 ` kernel test robot
2024-05-01 8:16 ` kernel test robot
2024-05-01 16:35 ` kernel test robot
2024-05-01 17:07 ` kernel test robot
2024-05-01 1:14 ` [PATCH v4] " Lyndon Sanche
2024-05-01 1:36 ` Pali Rohár
2024-05-01 1:42 ` Lyndon Sanche
2024-05-01 21:58 ` [PATCH v5] " Lyndon Sanche
2024-05-03 10:19 ` kernel test robot
2024-05-04 1:03 ` Lyndon Sanche
2024-05-06 10:18 ` Hans de Goede
2024-05-07 16:00 ` Lyndon Sanche
2024-05-03 21:19 ` Armin Wolf
2024-05-04 0:59 ` Lyndon Sanche
2024-05-08 14:24 ` Shen, Yijun
2024-05-08 15:53 ` Mario Limonciello
2024-05-11 15:05 ` Shen, Yijun
2024-05-11 15:12 ` Limonciello, Mario
2024-05-11 15:56 ` Shen, Yijun
2024-05-12 17:53 ` Armin Wolf
2024-05-12 17:58 ` Limonciello, Mario [this message]
2024-05-12 18:47 ` Armin Wolf
2024-05-12 22:14 ` Limonciello, Mario
2024-05-11 16:02 ` Lyndon Sanche
2024-05-09 15:10 ` Lyndon Sanche
2024-05-11 1:49 ` Lyndon Sanche
2024-05-11 15:22 ` Shen, Yijun
2024-05-11 15:54 ` Lyndon Sanche
2024-05-11 16:12 ` Shen, Yijun
2024-05-11 2:36 ` [PATCH v6 0/2] " Lyndon Sanche
2024-05-11 2:36 ` [PATCH v6 1/2] platform/x86: dell-smbios: Add helper for checking supported commands Lyndon Sanche
2024-05-11 15:13 ` Limonciello, Mario
2024-05-12 18:00 ` Armin Wolf
2024-05-11 2:36 ` [PATCH v6 2/2] platform/x86: dell-laptop: Implement platform_profile Lyndon Sanche
2024-05-11 15:16 ` Limonciello, Mario
2024-05-11 15:59 ` Lyndon Sanche
[not found] ` <48JCDS.E4RT1F9DTKFU1@lyndeno.ca>
2024-05-12 1:43 ` Limonciello, Mario
2024-05-12 15:25 ` Hans de Goede
2024-05-12 0:14 ` Lyndon Sanche
2024-05-12 18:05 ` Armin Wolf
2024-05-15 17:06 ` Lyndon Sanche
2024-05-17 22:42 ` [PATCH v7 0/3] platform/x86: dell: " Lyndon Sanche
2024-05-17 22:42 ` [PATCH v7 1/3] platform/x86: dell-smbios: Add helper for checking supported class Lyndon Sanche
2024-05-17 22:42 ` [PATCH v7 2/3] platform/x86: dell-smbios: Move request functions for reuse Lyndon Sanche
2024-05-17 22:42 ` [PATCH v7 3/3] platform/x86: dell-pc: Implement platform_profile Lyndon Sanche
2024-05-21 20:50 ` [PATCH v7 0/3] platform/x86: dell: " Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d38043cd-7fc2-4255-a795-23e64ee4a8c2@amd.com \
--to=mario.limonciello@amd.com \
--cc=Dell.Client.Kernel@dell.com \
--cc=W_Armin@gmx.de \
--cc=Yijun.Shen@dell.com \
--cc=corbet@lwn.net \
--cc=hdegoede@redhat.com \
--cc=hkallweit1@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lsanche@lyndeno.ca \
--cc=mjg59@srcf.ucam.org \
--cc=pali@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).