Re: [PATCH v7 00/14] target/mips: Misc cleanups for September/October 2019

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/1571826227-10583-1-git-send-email-aleksandar.markovic@rt-rk.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v7 00/14] target/mips: Misc cleanups for September/October 2019
Type: series
Message-id: 1571826227-10583-1-git-send-email-aleksandar.markovic@rt-rk.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
7ec7c3a target/mips: Demacro LMI decoder
4fc17e3 target/mips: Add support for emulation of CRC32 group of instructions
e96918e target/mips: msa: Split helpers for ASUB_<S|U>.<B|H|W|D>
d7f7bd6 target/mips: msa: Split helpers for HSUB_<S|U>.<H|W|D>
7249cb7 target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D>
07e71ba target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D>
56e3978 target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D>
1e4e614 target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>
2e7b6b9 target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>
5c7c560 target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>
0a73de1 target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>
cdecb4d MAINTAINERS: Update mail address of Aleksandar Rikalo
2e158cc target/mips: Clean up op_helper.c
8f48cdd target/mips: Clean up helper.c

=== OUTPUT BEGIN ===
1/14 Checking commit 8f48cdd5eeff (target/mips: Clean up helper.c)
2/14 Checking commit 2e158cc201b0 (target/mips: Clean up op_helper.c)
ERROR: spaces required around that '*' (ctx:WxV)
#1059: FILE: target/mips/op_helper.c:3871:
+                                  float_status *status)              \
                                                ^

total: 1 errors, 0 warnings, 1681 lines checked

Patch 2/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/14 Checking commit cdecb4d2b939 (MAINTAINERS: Update mail address of Aleksandar Rikalo)
4/14 Checking commit 0a73de15e1da (target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>)
5/14 Checking commit 5c7c5604af5a (target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>)
6/14 Checking commit 2e7b6b975619 (target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>)
7/14 Checking commit 1e4e614a7140 (target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>)
8/14 Checking commit 56e397811d1c (target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D>)
9/14 Checking commit 07e71ba61252 (target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D>)
10/14 Checking commit 7249cb7ea32e (target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D>)
11/14 Checking commit d7f7bd6e74d2 (target/mips: msa: Split helpers for HSUB_<S|U>.<H|W|D>)
12/14 Checking commit e96918e60aa2 (target/mips: msa: Split helpers for ASUB_<S|U>.<B|H|W|D>)
13/14 Checking commit 4fc17e3d3450 (target/mips: Add support for emulation of CRC32 group of instructions)
14/14 Checking commit 7ec7c3a29c8d (target/mips: Demacro LMI decoder)
ERROR: trailing statements should be on next line
#64: FILE: target/mips/translate.c:5574:
+    case OPC_PSUBSH: gen_helper_psubsh(t0, t0, t1);

total: 1 errors, 0 warnings, 251 lines checked

Patch 14/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1571826227-10583-1-git-send-email-aleksandar.markovic@rt-rk.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com