From: no-reply@patchew.org
To: laurent@vivier.eu
Cc: fam@euphon.net, kwolf@redhat.com, qemu-block@nongnu.org,
jasowang@redhat.com, qemu-devel@nongnu.org, laurent@vivier.eu,
pbonzini@redhat.com, mreitz@redhat.com
Subject: Re: [PULL 00/11] Q800 branch patches
Date: Mon, 28 Oct 2019 16:55:01 -0700 (PDT) [thread overview]
Message-ID: <157230690007.12254.13906808936182823844@37313f22b938> (raw)
In-Reply-To: <20191028181643.5143-1-laurent@vivier.eu>
Patchew URL: https://patchew.org/QEMU/20191028181643.5143-1-laurent@vivier.eu/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PULL 00/11] Q800 branch patches
Type: series
Message-id: 20191028181643.5143-1-laurent@vivier.eu
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
0aafe33 BootLinuxConsoleTest: Test the Quadra 800
6578d05 hw/m68k: define Macintosh Quadra 800
8d92411 hw/m68k: add a dummy SWIM floppy controller
33e127e hw/m68k: add Nubus macfb video card
9e5413f hw/m68k: add Nubus support
777b85a hw/m68k: implement ADB bus support for via
d23cb98 hw/m68k: add VIA support
477391a dp8393x: manage big endian bus
a5915a5 esp: add pseudo-DMA as used by Macintosh
324dd11 esp: move get_cmd() post-DMA code to get_cmd_cb()
447e0b9 esp: move handle_ti_cmd() cleanup code to esp_do_dma().
=== OUTPUT BEGIN ===
1/11 Checking commit 447e0b9e7e82 (esp: move handle_ti_cmd() cleanup code to esp_do_dma().)
2/11 Checking commit 324dd11bd843 (esp: move get_cmd() post-DMA code to get_cmd_cb())
3/11 Checking commit a5915a587841 (esp: add pseudo-DMA as used by Macintosh)
4/11 Checking commit 477391a3299a (dp8393x: manage big endian bus)
5/11 Checking commit d23cb98ca175 (hw/m68k: add VIA support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#84:
new file mode 100644
ERROR: space prohibited after that '&&' (ctx:WxW)
#456: FILE: hw/misc/mac_via.c:368:
+ if (!(v1s->last_b & VIA1B_vRTCClk) && (s->b & VIA1B_vRTCClk)) {
^
total: 1 errors, 1 warnings, 912 lines checked
Patch 5/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/11 Checking commit 777b85a4403d (hw/m68k: implement ADB bus support for via)
7/11 Checking commit 9e5413fe652c (hw/m68k: add Nubus support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#65:
new file mode 100644
total: 0 errors, 1 warnings, 531 lines checked
Patch 7/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/11 Checking commit 33e127ea8c90 (hw/m68k: add Nubus macfb video card)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#76:
new file mode 100644
total: 0 errors, 1 warnings, 597 lines checked
Patch 8/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/11 Checking commit 8d9241120f8f (hw/m68k: add a dummy SWIM floppy controller)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#63:
new file mode 100644
total: 0 errors, 1 warnings, 593 lines checked
Patch 9/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/11 Checking commit 6578d05b2deb (hw/m68k: define Macintosh Quadra 800)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#72:
new file mode 100644
total: 0 errors, 1 warnings, 537 lines checked
Patch 10/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/11 Checking commit 0aafe3328f0b (BootLinuxConsoleTest: Test the Quadra 800)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20191028181643.5143-1-laurent@vivier.eu/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
next prev parent reply other threads:[~2019-10-29 0:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 18:16 [PULL 00/11] Q800 branch patches Laurent Vivier
2019-10-28 18:16 ` [PULL 01/11] esp: move handle_ti_cmd() cleanup code to esp_do_dma() Laurent Vivier
2019-10-28 18:16 ` [PULL 02/11] esp: move get_cmd() post-DMA code to get_cmd_cb() Laurent Vivier
2019-10-28 18:16 ` [PULL 03/11] esp: add pseudo-DMA as used by Macintosh Laurent Vivier
2019-10-28 18:16 ` [PULL 04/11] dp8393x: manage big endian bus Laurent Vivier
2019-10-28 18:16 ` [PULL 05/11] hw/m68k: add VIA support Laurent Vivier
2019-10-28 18:16 ` [PULL 06/11] hw/m68k: implement ADB bus support for via Laurent Vivier
2019-10-28 18:16 ` [PULL 07/11] hw/m68k: add Nubus support Laurent Vivier
2019-10-28 18:16 ` [PULL 08/11] hw/m68k: add Nubus macfb video card Laurent Vivier
2019-10-28 18:16 ` [PULL 09/11] hw/m68k: add a dummy SWIM floppy controller Laurent Vivier
2019-10-28 18:16 ` [PULL 10/11] hw/m68k: define Macintosh Quadra 800 Laurent Vivier
2019-10-28 18:16 ` [PULL 11/11] BootLinuxConsoleTest: Test the " Laurent Vivier
2019-10-29 23:23 ` [PATCH 0/2] Acceptance test: update kernel used on m68k/q800 test Cleber Rosa
2019-10-29 23:23 ` [PATCH 1/2] Acceptance test: cancel test if m68k kernel packages goes missing Cleber Rosa
2019-10-31 8:06 ` Alex Bennée
2019-10-29 23:23 ` [PATCH 2/2] Acceptance test: update kernel for m68k/q800 test Cleber Rosa
2019-10-31 6:08 ` Alex Bennée
2019-11-07 15:08 ` Wainer dos Santos Moschetta
2019-10-31 8:06 ` Alex Bennée
2019-10-31 9:57 ` [PATCH 0/2] Acceptance test: update kernel used on " Alex Bennée
2019-11-07 15:43 ` Eric Blake
2019-11-07 16:38 ` Cleber Rosa
2019-11-07 17:18 ` Laurent Vivier
2019-11-07 18:00 ` Philippe Mathieu-Daudé
2019-11-07 18:25 ` Laurent Vivier
2019-10-28 23:55 ` no-reply [this message]
2019-10-29 18:06 ` [PULL 00/11] Q800 branch patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157230690007.12254.13906808936182823844@37313f22b938 \
--to=no-reply@patchew.org \
--cc=fam@euphon.net \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).